From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752259AbbIOBGC (ORCPT ); Mon, 14 Sep 2015 21:06:02 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:36434 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940AbbIOBFg (ORCPT ); Mon, 14 Sep 2015 21:05:36 -0400 From: John Stultz To: LKML Cc: John Stultz , "Theodore Ts'o" , Andreas Dilger , Ingo Molnar , linux-ext4@vger.kernel.org Subject: [RFC][PATCH 3/5] ext4: Fix abs() usage in ext4_mb_check_group_pa Date: Mon, 14 Sep 2015 18:05:22 -0700 Message-Id: <1442279124-7309-4-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1442279124-7309-1-git-send-email-john.stultz@linaro.org> References: <1442279124-7309-1-git-send-email-john.stultz@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ext4_fsblk_t type is a long long, which should not be used with abs(), as is done in ext4_mb_check_group_pa(). This patch modifies ext4_mb_check_group_pa() to use abs64() instead. Cc: "Theodore Ts'o" Cc: Andreas Dilger Cc: Ingo Molnar Cc: linux-ext4@vger.kernel.org Signed-off-by: John Stultz --- fs/ext4/mballoc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 34b610e..4780ab1 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -3331,8 +3331,8 @@ ext4_mb_check_group_pa(ext4_fsblk_t goal_block, atomic_inc(&pa->pa_count); return pa; } - cur_distance = abs(goal_block - cpa->pa_pstart); - new_distance = abs(goal_block - pa->pa_pstart); + cur_distance = abs64(goal_block - cpa->pa_pstart); + new_distance = abs64(goal_block - pa->pa_pstart); if (cur_distance <= new_distance) return cpa; -- 1.9.1