From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752651AbbIPC6p (ORCPT ); Tue, 15 Sep 2015 22:58:45 -0400 Received: from mail.windriver.com ([147.11.1.11]:36590 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752519AbbIPC6k (ORCPT ); Tue, 15 Sep 2015 22:58:40 -0400 From: To: CC: , , , Subject: [PATCH] vmcore: replace Elf64_Ehdr/Elf32_Ehdr with elfhdr Date: Wed, 16 Sep 2015 10:58:41 +0800 Message-ID: <1442372321-16334-2-git-send-email-yanjiang.jin@windriver.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1442372321-16334-1-git-send-email-yanjiang.jin@windriver.com> References: <1442372321-16334-1-git-send-email-yanjiang.jin@windriver.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yanjiang Jin Function parse_crash_elf_headers() reads e_ident[EI_CLASS] then decides to call parse_crash_elf64_headers() or parse_crash_elf32_headers(). But this happens in run time, not compile time. So compiler will report the below warning: In file included from include/linux/elf.h:4:0, from fs/proc/vmcore.c:13: fs/proc/vmcore.c: In function 'parse_crash_elf32_headers': arch/mips/include/asm/elf.h:258:23: warning: initializatio n from incompatible pointer type struct elfhdr *__h = (hdr); \ ^ fs/proc/vmcore.c:1071:4: note: in expansion of macro 'elf_ check_arch' !elf_check_arch(&ehdr) || ^ Signed-off-by: Yanjiang Jin --- fs/proc/vmcore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index 4e61388..576bb26 100644 --- a/fs/proc/vmcore.c +++ b/fs/proc/vmcore.c @@ -999,7 +999,7 @@ static void free_elfcorebuf(void) static int __init parse_crash_elf64_headers(void) { int rc=0; - Elf64_Ehdr ehdr; + struct elfhdr ehdr; u64 addr; addr = elfcorehdr_addr; @@ -1055,7 +1055,7 @@ fail: static int __init parse_crash_elf32_headers(void) { int rc=0; - Elf32_Ehdr ehdr; + struct elfhdr ehdr; u64 addr; addr = elfcorehdr_addr; -- 1.9.1