linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: eu@felipetonello.com
To: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Peter Chen <Peter.Chen@freescale.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <balbi@ti.com>,
	Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
	"Felipe F. Tonello" <eu@felipetonello.com>
Subject: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue
Date: Fri, 18 Sep 2015 18:30:21 +0100	[thread overview]
Message-ID: <1442597421-3641-3-git-send-email-eu@felipetonello.com> (raw)
In-Reply-To: <1442597421-3641-1-git-send-email-eu@felipetonello.com>

From: "Felipe F. Tonello" <eu@felipetonello.com>

f_midi is not checking weather the is an error on usb_ep_queue
request, ignoring potential problems, such as memory leaks.

Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---

Changes for v2:
  - Update code style.

 drivers/usb/gadget/function/f_midi.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index ad50a67..c04133422 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -543,10 +543,16 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
 		}
 	}
 
-	if (req->length > 0)
-		usb_ep_queue(ep, req, GFP_ATOMIC);
-	else
+	if (req->length > 0) {
+		int err;
+
+		err = usb_ep_queue(ep, req, GFP_ATOMIC);
+		if (err < 0)
+			ERROR(midi, "%s queue req: %d\n",
+			      midi->out_ep->name, err);
+	} else {
 		free_ep_req(ep, req);
+	}
 }
 
 static void f_midi_in_tasklet(unsigned long data)
-- 
2.1.4


  parent reply	other threads:[~2015-09-18 17:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 17:30 [PATCH 1/3] usb: chipidea: udc: _ep_queue and _hw_queue cleanup eu
2015-09-18 17:30 ` [PATCH 2/3] usb: chipidea: udc: improve error handling on ep_queue eu
2015-10-22  1:41   ` Peter Chen
2015-10-27  9:27   ` Felipe Ferreri Tonello
2015-10-27  9:29     ` Peter Chen
2015-09-18 17:30 ` eu [this message]
2015-09-18 17:32   ` [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue Felipe Tonello
2015-09-18 17:36 eu
2015-09-21  9:21 ` Felipe Tonello
2015-09-22  4:04   ` Felipe Balbi
2015-09-22  5:39     ` Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442597421-3641-3-git-send-email-eu@felipetonello.com \
    --to=eu@felipetonello.com \
    --cc=Peter.Chen@freescale.com \
    --cc=andrzej.p@samsung.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).