From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932795AbbIUNvd (ORCPT ); Mon, 21 Sep 2015 09:51:33 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:43643 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932085AbbIUNgR (ORCPT ); Mon, 21 Sep 2015 09:36:17 -0400 X-AuditID: cbfec7f5-f794b6d000001495-31-560007ce4444 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Matt Mackall , Herbert Xu , linux-crypto@vger.kernel.org Subject: [PATCH 10/38] hwrng: fix handling platform_get_irq Date: Mon, 21 Sep 2015 15:33:42 +0200 Message-id: <1442842450-29769-11-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmluLIzCtJLcpLzFFi42I5/e/4Vd1z7AxhBl9OS1jcWneO1WLjjPWs Ft2vZCzu3/vJZHF51xw2i7VH7rJbLNjWx+jA7rHtgKpH35ZVjB59LzcwenzeJBfAEsVlk5Ka k1mWWqRvl8CVMfnKIuaCNRwVt/5aNzD+Z+ti5OSQEDCRmH6ziR3CFpO4cG89UJyLQ0hgKaPE +sszmSCcJiaJ1X23WUCq2AQ0Jf5uvgnWLSKgILG59xkrSBGzwA9GiScbbwCN4uAQFrCWOLE3 FaSGRUBVYsqns4wgYV4BF4lvS2IhlslJnDw2mRXE5gQKHzj4BWy8kICzxIElR5gmMPIuYGRY xSiaWppcUJyUnmukV5yYW1yal66XnJ+7iRESRF93MC49ZnWIUYCDUYmH11Hgf6gQa2JZcWXu IUYJDmYlEV6dWUAh3pTEyqrUovz4otKc1OJDjNIcLErivDN3vQ8REkhPLEnNTk0tSC2CyTJx cEo1MJZd2ONxO9h+X8bURMZFvceeJH7a4Xy+V3Ki/7G5ZzxW5Sxc+Xnxj/wLTh7CZR8d76w/ a81ZNVXC0uhkK9O+k9HWyikJCzN7kmMy5pzwvKe62mBv6In3jtMmdrs9fVKeedvlk3XHDXOb ufbmRzf+PcGw6cbbuOV7j/W7Py0/4B9S5JVzMX5b6h0lluKMREMt5qLiRABBlZhUHgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/char/hw_random/xgene-rng.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c index c37cf75..3c77645 100644 --- a/drivers/char/hw_random/xgene-rng.c +++ b/drivers/char/hw_random/xgene-rng.c @@ -344,11 +344,12 @@ static int xgene_rng_probe(struct platform_device *pdev) if (IS_ERR(ctx->csr_base)) return PTR_ERR(ctx->csr_base); - ctx->irq = platform_get_irq(pdev, 0); - if (ctx->irq < 0) { + rc = platform_get_irq(pdev, 0); + if (rc < 0) { dev_err(&pdev->dev, "No IRQ resource\n"); - return ctx->irq; + return rc; } + ctx->irq = rc; dev_dbg(&pdev->dev, "APM X-Gene RNG BASE %p ALARM IRQ %d", ctx->csr_base, ctx->irq); -- 1.9.1