From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756881AbbIUNgP (ORCPT ); Mon, 21 Sep 2015 09:36:15 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:40457 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752860AbbIUNgN (ORCPT ); Mon, 21 Sep 2015 09:36:13 -0400 X-AuditID: cbfec7f5-f794b6d000001495-1c-560007ca8dc7 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "Suzuki K. Poulose" , Punit Agrawal , Will Deacon , Arnd Bergmann , Mark Rutland Subject: [PATCH 01/38] arm-cci: fix handling cpumask_any_but return value Date: Mon, 21 Sep 2015 15:33:33 +0200 Message-id: <1442842450-29769-2-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBLMWRmVeSWpSXmKPExsVy+t/xq7qn2BnCDP7M0rO4te4cq8XfScfY LTbOWM9qcXnXHDaLtUfuslssvX6RyeL5+9NMFjNv32a0ePnxBIsDp8eaeWsYPX7/msTo0bdl FaPH501yASxRXDYpqTmZZalF+nYJXBmrZ8QULGOvWHA5r4Gxna2LkZNDQsBE4vzpFYwQtpjE hXvrgeJcHEICSxkl/m3ZxQrhNDFJLFh7jBmkik1AU+Lv5ptg3SICChKbe5+BFTELXGCSmL/v EFiRsICnROP8I0wgNouAqsTS58vAGngFnCXmzz/PCrFOTuLksclgNqeAi8SBg19YQGwhoJoD S44wTWDkXcDIsIpRNLU0uaA4KT3XSK84Mbe4NC9dLzk/dxMjJLy+7mBceszqEKMAB6MSD6+j wP9QIdbEsuLK3EOMEhzMSiK8OrOAQrwpiZVVqUX58UWlOanFhxilOViUxHln7nofIiSQnliS mp2aWpBaBJNl4uCUamDsjg2a9PfOfsbkdaEtdYabf57aWLvi1cITU7OTf53h9E7rndElyPTf Z87r3Bes7R1v45gSFz9b/FK1ollt4cv/6RO6VkZn6wY/yNLa1Ltaqfjy35pjHSt43q3bm7d0 x9LKDVufGufu3bcm/rT99K3ZW8vvTnpgfTL/4aHkO5Wz1vzY6Jf2ZG5jkRJLcUaioRZzUXEi AHtc5OkrAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cpumask_any_but returns value >= nr_cpu_ids if there are no more CPUs. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/bus/arm-cci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c index 577cc4b..22754d0 100644 --- a/drivers/bus/arm-cci.c +++ b/drivers/bus/arm-cci.c @@ -1314,7 +1314,7 @@ static int cci_pmu_cpu_notifier(struct notifier_block *self, if (!cpumask_test_and_clear_cpu(cpu, &cci_pmu->cpus)) break; target = cpumask_any_but(cpu_online_mask, cpu); - if (target < 0) // UP, last CPU + if (target >= nr_cpu_ids) // UP, last CPU break; /* * TODO: migrate context once core races on event->ctx have -- 1.9.1