From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932619AbbIUNn6 (ORCPT ); Mon, 21 Sep 2015 09:43:58 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:40457 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932420AbbIUNgZ (ORCPT ); Mon, 21 Sep 2015 09:36:25 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-ed-560007d43931 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org Subject: [PATCH 26/38] staging: lustre: remove invalid check Date: Mon, 21 Sep 2015 15:33:58 +0200 Message-id: <1442842450-29769-27-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrELMWRmVeSWpSXmKPExsVy+t/xq7pX2BnCDH5N0be4te4cq0XDtVes FhtnrGe12HPmF7tF8+L1bBaXd81hszh1+AGLxdojd9ktFn9qZnTg9Li37zCLx+I9L5k89s9d w+7RvOgGm0ffllWMHp83yQWwRXHZpKTmZJalFunbJXBlTNonUnCKrWLqnUWMDYynWbsYOTkk BEwkzp/fzwxhi0lcuLeerYuRi0NIYCmjxOvzy9ghnCYmidatjxhBqtgENCX+br7JBmKLCChI bO59xgpSxCxwiUnix4R5QEUcHMICNhJ/PtmD1LAIqEpMb1wGtoFXwEXi5rer7BDb5CROHpsM dgUnUPzAwS8sILaQgLPEgSVHmCYw8i5gZFjFKJpamlxQnJSea6hXnJhbXJqXrpecn7uJERJy X3YwLj5mdYhRgINRiYfXQeB/qBBrYllxZe4hRgkOZiURXp1ZQCHelMTKqtSi/Pii0pzU4kOM 0hwsSuK8c3e9DxESSE8sSc1OTS1ILYLJMnFwSjUwNh/tP3HLoyxUK/vNba6+6w7fmNREjofb +gn5rp62+93TJWyGpmIsy6757I1eVZJinr8194Ufi3dBulWfW4airFBQzK+EpnLOsGuvJvB0 /5tzak/nVsMjsgqhb28c/ODBP/WNwNSmVl5dw//6DJ9fKLN/48r4cnVB8eZdwov23e6X159x ZaGoEktxRqKhFnNRcSIAVXnuhjUCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Unsigned cannot be negative. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/staging/lustre/lustre/osc/lproc_osc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/staging/lustre/lustre/osc/lproc_osc.c index c504d15..f3eb39f 100644 --- a/drivers/staging/lustre/lustre/osc/lproc_osc.c +++ b/drivers/staging/lustre/lustre/osc/lproc_osc.c @@ -451,9 +451,6 @@ static ssize_t resend_count_store(struct kobject *kobj, if (rc) return rc; - if (val < 0) - return -EINVAL; - atomic_set(&obd->u.cli.cl_resends, val); return count; -- 1.9.1