From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932717AbbIUNsM (ORCPT ); Mon, 21 Sep 2015 09:48:12 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:37352 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932349AbbIUNgX (ORCPT ); Mon, 21 Sep 2015 09:36:23 -0400 X-AuditID: cbfec7f5-f794b6d000001495-64-560007d5bc0e From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Tomi Valkeinen , Jean-Christophe Plagniol-Villard , linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org Subject: [PATCH 28/38] video/omap: remove invalid check Date: Mon, 21 Sep 2015 15:34:00 +0200 Message-id: <1442842450-29769-29-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprELMWRmVeSWpSXmKPExsVy+t/xq7pX2RnCDG5cUbO4te4cq8XGGetZ LU70fWC1uLxrDpvF7CX9LBZrj9xlt1j38AWTxfr5t9gcODxeXbjD4tG3ZRWjx/Eb25k8Pm+S C2CJ4rJJSc3JLEst0rdL4Mr4eNCs4Btbxdu3i1kaGC+zdjFyckgImEh8b33ICGGLSVy4t54N xBYSWMooce5sThcjF5DdxCRxbMM+sASbgKbE3803wWwRAQWJzb3PWEGKmAXWM0msv/sXbKqw gLnE2j1fwIpYBFQlvm3bx97FyMHBK+AicWNvFsQyOYmTxyaDlXMChQ8c/MICsdhZ4sCSI0wT GHkXMDKsYhRNLU0uKE5KzzXSK07MLS7NS9dLzs/dxAgJqa87GJceszrEKMDBqMTD6yjwP1SI NbGsuDL3EKMEB7OSCK/OLKAQb0piZVVqUX58UWlOavEhRmkOFiVx3pm73ocICaQnlqRmp6YW pBbBZJk4OKUaGDXUDf3OPljV1uL/sF449Z66kb3ex8XtUVZ1H4XDGfzEToU8yr32eaWeieec uXoaDTwR7Z3vpK+9KeG/V7jcJf2nRZqy2Kf3khcackzOJdmw6zZzLsk6GJZfvlrf8VzcFO63 5cIvLcTfeE6ys2EqsVz1fn/Fx1XmSu/8pq1hLGZyjbyV9claiaU4I9FQi7moOBEAcB7u1CUC AAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org regno is unsigned so it cannot be negative. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/video/fbdev/omap/omapfb_main.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c index 1fb3ea3..393ae1b 100644 --- a/drivers/video/fbdev/omap/omapfb_main.c +++ b/drivers/video/fbdev/omap/omapfb_main.c @@ -276,11 +276,6 @@ static int _setcolreg(struct fb_info *info, u_int regno, u_int red, u_int green, if (r != 0) break; - if (regno < 0) { - r = -EINVAL; - break; - } - if (regno < 16) { u16 pal; pal = ((red >> (16 - var->red.length)) << -- 1.9.1