From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932665AbbIUNoA (ORCPT ); Mon, 21 Sep 2015 09:44:00 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:37352 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932390AbbIUNgY (ORCPT ); Mon, 21 Sep 2015 09:36:24 -0400 X-AuditID: cbfec7f5-f794b6d000001495-66-560007d50fd4 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Nick Dyer , Dmitry Torokhov , linux-input@vger.kernel.org Subject: [PATCH 29/38] Input: touchscreen: atmel: remove invalid check Date: Mon, 21 Sep 2015 15:34:01 +0200 Message-id: <1442842450-29769-30-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplluLIzCtJLcpLzFFi42I5/e/4Vd1r7AxhBhulLG6tO8dqsXHGelaL w4teMFrc/PSN1eLyrjlsFmuP3GW3OP0h2YHdY+esu+wehz+0snj0bVnF6PF5k1wASxSXTUpq TmZZapG+XQJXRtv6qawFu9grjh95ztzAuJCti5GDQ0LARKLplVQXIyeQKSZx4d56oDAXh5DA UkaJI/9fsUM4TUwSxzbsYwOpYhPQlPi7+SaYLSKgILG59xkrSBGzwH9GiaVzD7CCJIQF3CSW blrKDGKzCKhK9P16zQRi8wq4SGxZeYwVYp2cxMljk8FsTqD4gYNfWEBsIQFniQNLjjBNYORd wMiwilE0tTS5oDgpPddIrzgxt7g0L10vOT93EyMkkL7uYFx6zOoQowAHoxIPr6PA/1Ah1sSy 4srcQ4wSHMxKIrw6s4BCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeWfueh8iJJCeWJKanZpakFoE k2Xi4JRqYDTz91MJfr1S9jrfv6Dr19VUHs5LOdnZnezgqmTw78q3UM7F/93L5y/4t32ie014 naqk04w5oQJSNy+LLE2wvSjGzDeRS6f6kVHV2eL3wqWLRB+3L/zhaiDKE/eCj3uFvG62q6h/ 6fd9PSwLcsOK9d9eN4iwMK3wNDkdcGDfCSXueM6lG9xVlViKMxINtZiLihMB7UFSzyACAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org byte_offset is unsigned. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/input/touchscreen/atmel_mxt_ts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index c562205..c577f95 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -1267,7 +1267,7 @@ static int mxt_prepare_cfg_mem(struct mxt_data *data, byte_offset = reg + i - cfg_start_ofs; - if (byte_offset >= 0 && byte_offset < config_mem_size) { + if (byte_offset < config_mem_size) { *(config_mem + byte_offset) = val; } else { dev_err(dev, "Bad object: reg:%d, T%d, ofs=%d\n", -- 1.9.1