From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932461AbbIUNir (ORCPT ); Mon, 21 Sep 2015 09:38:47 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:40457 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932477AbbIUNg2 (ORCPT ); Mon, 21 Sep 2015 09:36:28 -0400 X-AuditID: cbfec7f5-f794b6d000001495-69-560007d6ec1f From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Richard Purdie , Jacek Anaszewski , linux-leds@vger.kernel.org Subject: [PATCH 30/38] leds: flash: remove invalid check Date: Mon, 21 Sep 2015 15:34:02 +0200 Message-id: <1442842450-29769-31-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupiluLIzCtJLcpLzFFi42I5/e/4Vd1r7AxhBs3TxSxurTvHarFxxnpW i96rzxktLu+aw2ax9c06Rou1R+6yW+ze9ZTVgd1jz/wfrB59W1YxenzeJBfAHMVlk5Kak1mW WqRvl8CVseNVWEE7W8XKC5NZGxgbWbsYOTkkBEwkvv1YwAJhi0lcuLeerYuRi0NIYCmjxJaL XxghnCYmiQvfjjCBVLEJaEr83XyTDcQWEVCQ2Nz7jBWkiFngP6PE5z+nmEESwgIWEtOXLwez WQRUJVpmLAdr4BVwkXj2+QozxDo5iZPHJoOdwQkUP3DwC9gZQgLOEgeWHGGawMi7gJFhFaNo amlyQXFSeq6RXnFibnFpXrpecn7uJkZICH3dwbj0mNUhRgEORiUeXkeB/6FCrIllxZW5hxgl OJiVRHh1ZgGFeFMSK6tSi/Lji0pzUosPMUpzsCiJ887c9T5ESCA9sSQ1OzW1ILUIJsvEwSnV wLjwqsiPArOaE49aN566OKd96osowSks27j0fW5EGH+bft9fLSFo1vxWp1iph67zVvbXdE16 In3r9+wDOj8cKk85K7lpyFrkOq/q/lN/7SvL9mC7iJqYdUeqF5YJ7Q++ebFXtXjmDJ3ZHzcv +m1zqKNwTrbxbFG7J9HvJTdmpZyufKG4c77x3d9KLMUZiYZazEXFiQDAN+DjHQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Unsigned cannot be lesser than zero. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/leds/led-class-flash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/led-class-flash.c b/drivers/leds/led-class-flash.c index 3b25734..c209077 100644 --- a/drivers/leds/led-class-flash.c +++ b/drivers/leds/led-class-flash.c @@ -108,7 +108,7 @@ static ssize_t flash_strobe_store(struct device *dev, if (ret) goto unlock; - if (state < 0 || state > 1) { + if (state > 1) { ret = -EINVAL; goto unlock; } -- 1.9.1