From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932513AbbIUNgb (ORCPT ); Mon, 21 Sep 2015 09:36:31 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:37352 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932421AbbIUNgZ (ORCPT ); Mon, 21 Sep 2015 09:36:25 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-fc-560007d79b20 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , David Howells , linux-cachefs@redhat.com Subject: [PATCH 32/38] fs/cachefiles: remove invalid checks Date: Mon, 21 Sep 2015 15:34:04 +0200 Message-id: <1442842450-29769-33-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphluLIzCtJLcpLzFFi42I5/e/4Vd3r7AxhBn0NrBa31p1jtdg4Yz2r xbum3ywWH5ecYre4vGsOm8XaI3fZHdg83u+7yubRt2UVo8fnTXIBzFFcNimpOZllqUX6dglc GUfnT2AsmCJccf1EaAPjWf4uRk4OCQETiSNLzjJB2GISF+6tZ+ti5OIQEljKKLFq+10op4lJ 4sGR/6wgVWwCmhJ/N99kA7FFBBQkNvc+YwUpYhY4zyjx+OdhsCJhAWuJM3NvAo3l4GARUJW4 OqcQJMwr4CIx8/ZPNohtchInj00GK+cEih84+IUFxBYScJY4sOQI0wRG3gWMDKsYRVNLkwuK k9JzDfWKE3OLS/PS9ZLzczcxQsLmyw7GxcesDjEKcDAq8fA6CPwPFWJNLCuuzD3EKMHBrCTC qzMLKMSbklhZlVqUH19UmpNafIhRmoNFSZx37q73IUIC6YklqdmpqQWpRTBZJg5OqQbGaeuu He0srS/Yrcas/llUYrGGSO63doslM1PqebSNg5Zbad/Na72rPYfNqMOGrd72+mkm3nNVMYue /9eRLdxoMCP2Q9ur1TeObfjY+pnjw5mcrMKTiSLT/ky78CL2q6HNpvxJGe6nL03xeiqx6PBW 6YUf3grEuK0sOf3hbK3jpo89mQ9Fl5ZcUGIpzkg01GIuKk4EAPmU6L0XAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Unsigned values cannot be lesser than zero. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- fs/cachefiles/bind.c | 9 +++------ fs/cachefiles/daemon.c | 6 +++--- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/fs/cachefiles/bind.c b/fs/cachefiles/bind.c index 6af790f..6b50c88 100644 --- a/fs/cachefiles/bind.c +++ b/fs/cachefiles/bind.c @@ -39,13 +39,10 @@ int cachefiles_daemon_bind(struct cachefiles_cache *cache, char *args) args); /* start by checking things over */ - ASSERT(cache->fstop_percent >= 0 && - cache->fstop_percent < cache->fcull_percent && - cache->fcull_percent < cache->frun_percent && - cache->frun_percent < 100); + ASSERT(cache->fstop_percent < cache->fcull_percent && + cache->fcull_percent < cache->frun_percent); - ASSERT(cache->bstop_percent >= 0 && - cache->bstop_percent < cache->bcull_percent && + ASSERT(cache->bstop_percent < cache->bcull_percent && cache->bcull_percent < cache->brun_percent && cache->brun_percent < 100); diff --git a/fs/cachefiles/daemon.c b/fs/cachefiles/daemon.c index f601def..996ecd2 100644 --- a/fs/cachefiles/daemon.c +++ b/fs/cachefiles/daemon.c @@ -222,7 +222,7 @@ static ssize_t cachefiles_daemon_write(struct file *file, if (test_bit(CACHEFILES_DEAD, &cache->flags)) return -EIO; - if (datalen < 0 || datalen > PAGE_SIZE - 1) + if (datalen > PAGE_SIZE - 1) return -EOPNOTSUPP; /* drag the command string into the kernel so we can parse it */ @@ -385,7 +385,7 @@ static int cachefiles_daemon_fstop(struct cachefiles_cache *cache, char *args) if (args[0] != '%' || args[1] != '\0') return -EINVAL; - if (fstop < 0 || fstop >= cache->fcull_percent) + if (fstop >= cache->fcull_percent) return cachefiles_daemon_range_error(cache, args); cache->fstop_percent = fstop; @@ -457,7 +457,7 @@ static int cachefiles_daemon_bstop(struct cachefiles_cache *cache, char *args) if (args[0] != '%' || args[1] != '\0') return -EINVAL; - if (bstop < 0 || bstop >= cache->bcull_percent) + if (bstop >= cache->bcull_percent) return cachefiles_daemon_range_error(cache, args); cache->bstop_percent = bstop; -- 1.9.1