From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932528AbbIUNgc (ORCPT ); Mon, 21 Sep 2015 09:36:32 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:37352 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932491AbbIUNg3 (ORCPT ); Mon, 21 Sep 2015 09:36:29 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-04-560007d8fb26 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Ralf Baechle , Markos Chandras , linux-mips@linux-mips.org Subject: [PATCH 36/38] MIPS: remove invalid check Date: Mon, 21 Sep 2015 15:34:08 +0200 Message-id: <1442842450-29769-37-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnluLIzCtJLcpLzFFi42I5/e/4Vd0b7AxhBuu/KVncWneO1WLjjPWs Fpd3zWGzmDB1ErvF2iN32S0+397OanFpj4oDu0fPzjOMHkdXrmXy6NuyitHj8ya5AJYoLpuU 1JzMstQifbsErozF7SsYC/6zVSx9uYKtgfEwaxcjJ4eEgInE262vGSFsMYkL99azdTFycQgJ LGWUaG+ewwjhNDFJnH67hQmkik1AU+Lv5ptsILaIgILE5t5nrCBFzAL/GSVubT0BNlZYwFDi /cvLYEUsAqoSv5fuYwaxeQVcJJ7MOMwEsU5O4uSxyWD1nEDxAwe/sIDYQgLOEgeWHGGawMi7 gJFhFaNoamlyQXFSeq6hXnFibnFpXrpecn7uJkZIMH3Zwbj4mNUhRgEORiUeXgeB/6FCrIll xZW5hxglOJiVRHh1ZgGFeFMSK6tSi/Lji0pzUosPMUpzsCiJ887d9T5ESCA9sSQ1OzW1ILUI JsvEwSnVwDiBcQI3k+Hv0wHrrhgXKu8SP3qtVZ0nT2CWbFYBQ1s3w06+ea873M1d9bfuXdk/ O+nB9SgfKbvgR6vv/F97sfKOc15yVl1/p7Dt+3iB5hfdvf2VS4ML5sWZxTF/TNauujYxpf+W JJ+FW9yzJY1TZ3Guk9RezjnlkOk0fevvS5Yt9Thy+N+r90osxRmJhlrMRcWJAP4I1kQiAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Unsigned values cannot be lesser than zero. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- arch/mips/mm/sc-mips.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/mm/sc-mips.c b/arch/mips/mm/sc-mips.c index 53ea839..1755187 100644 --- a/arch/mips/mm/sc-mips.c +++ b/arch/mips/mm/sc-mips.c @@ -162,13 +162,13 @@ static inline int __init mips_sc_probe(void) return 0; tmp = (config2 >> 8) & 0x0f; - if (0 <= tmp && tmp <= 7) + if (tmp <= 7) c->scache.sets = 64 << tmp; else return 0; tmp = (config2 >> 0) & 0x0f; - if (0 <= tmp && tmp <= 7) + if (tmp <= 7) c->scache.ways = tmp + 1; else return 0; -- 1.9.1