From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932745AbbIUNwq (ORCPT ); Mon, 21 Sep 2015 09:52:46 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:43643 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756883AbbIUNgQ (ORCPT ); Mon, 21 Sep 2015 09:36:16 -0400 X-AuditID: cbfec7f5-f794b6d000001495-2a-560007cdd7fa From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: [PATCH 07/38] usb: host: ehci-msm: fix handling platform_get_irq result Date: Mon, 21 Sep 2015 15:33:39 +0200 Message-id: <1442842450-29769-8-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprALMWRmVeSWpSXmKPExsVy+t/xq7pn2RnCDB728FvcWneO1WLjjPWs Fs2L17NZXN41h81i0bJWZou1R+6yW0z4fYHNgd1j/9w17B6z7/5g9OjbsorR4/MmuQCWKC6b lNSczLLUIn27BK6MQ8s3MxbcZq+48vopawPjOrYuRk4OCQETiedLL0HZYhIX7q0Hsrk4hASW MkocOf8NymlikmheupgZpIpNQFPi7+abYB0iAgoSm3ufsYIUMQu0MUmsb1rFDpIQFgiQ6H10 A8xmEVCV+D/jAQuIzSvgLDHv/GUmiHVyEiePTWYFsTkFXCQOHPwCViMEVHNgyRGmCYy8CxgZ VjGKppYmFxQnpeca6RUn5haX5qXrJefnbmKEhNPXHYxLj1kdYhTgYFTi4XUU+B8qxJpYVlyZ e4hRgoNZSYRXZxZQiDclsbIqtSg/vqg0J7X4EKM0B4uSOO/MXe9DhATSE0tSs1NTC1KLYLJM HJxSDYycXUt5d7Zl+XvP0DOsivnXtL1zcfhFM6vAMHuJNNGEXN07AVGe3AW7Siz+/EitW6TM 4s2Sbr/inqb06rX/Zrr+SLk9r7JX7j6TyMTSR5rrRW90Pdzz9uWTeYY3RIO2Xo/0DUyK/vby 2GWZ1N4DWT7vVrguUmVkzJN6b5u220p8s6B+VF2ahxJLcUaioRZzUXEiAKutHYYjAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative values. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/usb/host/ehci-msm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index 275c92e..c4f84c8 100644 --- a/drivers/usb/host/ehci-msm.c +++ b/drivers/usb/host/ehci-msm.c @@ -80,12 +80,12 @@ static int ehci_msm_probe(struct platform_device *pdev) return -ENOMEM; } - hcd->irq = platform_get_irq(pdev, 0); - if (hcd->irq < 0) { + ret = platform_get_irq(pdev, 0); + if (ret < 0) { dev_err(&pdev->dev, "Unable to get IRQ resource\n"); - ret = hcd->irq; goto put_hcd; } + hcd->irq = ret; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!res) { -- 1.9.1