From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934968AbbIVWwy (ORCPT ); Tue, 22 Sep 2015 18:52:54 -0400 Received: from mail-by2on0141.outbound.protection.outlook.com ([207.46.100.141]:35002 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758793AbbIVWwu (ORCPT ); Tue, 22 Sep 2015 18:52:50 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1442962353.19102.296.camel@freescale.com> Subject: Re: [PATCH v2 22/25] powerpc32: move xxxxx_dcache_range() functions inline From: Scott Wood To: Christophe Leroy CC: Joakim Tjernlund , "paulus@samba.org" , "mpe@ellerman.id.au" , "benh@kernel.crashing.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" Date: Tue, 22 Sep 2015 17:52:33 -0500 In-Reply-To: <5601DB07.3000205@c-s.fr> References: <1442945547.29498.50.camel@transmode.se> <1442948339.19102.270.camel@freescale.com> <1442950473.29498.54.camel@transmode.se> <1442950926.19102.280.camel@freescale.com> <1442951752.29498.58.camel@transmode.se> <1442952852.19102.281.camel@freescale.com> <1442953971.29498.76.camel@transmode.se> <1442954101.19102.286.camel@freescale.com> <1442954285.29498.79.camel@transmode.se> <5601C0CC.6090503@c-s.fr> <1442961271.19102.289.camel@freescale.com> <5601DB07.3000205@c-s.fr> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Originating-IP: [2601:448:8100:f9f:50e1:d489:16f6:5d07] X-ClientProxiedBy: BLUPR11CA0074.namprd11.prod.outlook.com (10.141.30.42) To CY1PR03MB1487.namprd03.prod.outlook.com (25.163.17.17) X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;2:Xry7VItMe0Vsxd/+3K+6MQ2+031LZwx4c9Iray8Kefws+7UeDPGoTNIyJyXA42kHCep+JPQzsY3Ap2zOunrbVWd7+C1oAGTDL8tgVBBtLfXN1emY/ARDFJypr7CizzZ+gYjKmQi7xQPFhOXSZG178QrJ4LHWrt2OV5DGHbDc7fU=;3:zbj75E91S4YI/y7t6f97KuXAXrJluA/ntramzhEOnB02dsKwyt9/9Q0opkvCSRUeyfpALP4YvGla8Q+nG8rqvssN4iA4B84H1q78F0dIGDc3nMZrfj8RQ7K1yBNeJ4ZkaBj2+2AwVYGQe/Awo4INAw==;25:LGzND78l38vmplvYYF9Km+vjk0Iu5ssNhA/C01dZofZ0IblpwCTjqYDKBzcXWXSmqECSDTn7pQlg/gqB1zBoriIiq20TWaE8rhfYUAIGGQNqRwY5DBzGgZvA7urDYKypwAkFfLjF5G6w4fHW1erxuvLzH+lteSQI84Dw0gDyRZ8C6qVY+kY9rgV8Gj4ZFjLr9ZddqZ7U70TE7LZmPEy8x+DMY8m7f903bDsT1y2npXK34sB8Wp+YHp82KW7v22Lu X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1487; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;20:BA//k0b+AhLxeqmkLj+8qHO2Nh6Cne+jj0AbsNWBQrkJvZUeuBCa9E18J2SMExCtfSqGN4wfvFF+V7H7DwudL/iN+dIYLOY5k9ZkER2uau5ZN4uUgEwacpT+GwJwTe26CZ2oWXVhzSdOpToKxNkdiU6XVBtPUjN2vCB6b7/dRIOq/JAC7uKP4H01MakUT/x9Chyn6qxBBNw4NTE2wdfz2EyjuvQKKEBGP18vNQkQUAAH3M1/J2mu/nAuWLaKjmEuhb3Gk3ZTjzKm+bWY99yTI89rKVtzTiJSs1Hl90GU80nl0FB41pn/dZSzEp35FM9evYtXPyHHMJ2/7V3qNeWnSFXhPTi3phxTlytwihrH+ommRcnH/405l5LbRjJody7pz/efDlJn44HYiIcYvqAClhXK4lNkhhTakJ7MUok8SCMN+oF+nrHXf81XycGf+ofozOLmY6iVMpbhjvqHBTjpTwdxEW8pBIQXpxAY1kdNDNol5x+m/1iPFuXkDGlvl2Lz;4:1T0qjVj0DFPxK75ptm0HFnlXoJtNITJ7IdxBAVUfCzQw26RDg8HxNA9XStEKuy7AqDoVVgip9UHHJztpBzWI26peW0vDc3x3tyhIqkThzR6RQFCywiI8/4g/b2bXUOpj/yEzz6MwX1H0jYHARbwYGI0w/xN5syPdHbdWmYdhwD71E+z5CyhIShFSMmKoPqgzxoPqX/1dWDEa+ESJGY3jF5CqMcPK2A5gWwxWgfH46HkMa55kNEtJ3TXT14q64PUwM4RFRSWqZ0DKl8m9OUYX2RS1cFZVj3Ce9D2MvDfQHBU8qYpoUqYXm6gK2bda0fwCOlkmaJpj98nnjRGeyVkGbJu1HpLpWoNeCpAEeiq4T+Y= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001);SRVR:CY1PR03MB1487;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1487; X-Forefront-PRVS: 0707248B64 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(377424004)(189002)(479174004)(199003)(24454002)(46102003)(101416001)(5004730100002)(68736005)(4001540100001)(64706001)(5007970100001)(47776003)(50986999)(87976001)(77096005)(97736004)(189998001)(36756003)(23676002)(5001860100001)(76176999)(110136002)(92566002)(62966003)(2950100001)(81156007)(106356001)(5001830100001)(5001960100002)(42186005)(40100003)(5820100001)(50466002)(86362001)(77156002)(50226001)(93886004)(103116003)(105586002)(122386002)(33646002)(99106002)(3826002)(5001840100002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR03MB1487;H:[IPv6:2601:448:8100:f9f:50e1:d489:16f6:5d07];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIxNDg3OzIzOlZKYXBNcTlqUml0UEJMRUtXQUxpd1podVVi?= =?utf-8?B?OTl1TUVTb1BqOVV6SnFFT2N0cCt1Nmx5N0lTbXdzeFBsMCtPQnhOZWlKUWQy?= =?utf-8?B?SHROZGRET1hxN25FNlJvQzBlc1lCb25idVAvWXFRb2RwT0N0TkU4bmc3ZEJE?= =?utf-8?B?alFGRmtLbmtReTZiL0ZqSXlHUU9RY0tWclF1WkJsUzZwQ0doaXRSVHRvMDU4?= =?utf-8?B?V0J1WnVzaTFzVElIUXVCN1lEQ3R2ZHc2eHhaNmxZZnczSnIwMlhEUmpSUjF5?= =?utf-8?B?d2srZlJFWGEzR3Fhckh3Qnpja3BXNDNzL2tuWStRdkhENlpqZ1BsN2thazFi?= =?utf-8?B?blVsbUxUaHdFNGI2NVp2aWZheEh3c0hUVTNPUkYwQmRmSG9pRGdSTlp0bGVv?= =?utf-8?B?Zm5ERmlXWlZyMHNXK2FoMGQvS0xUajNNaGZURC9uQkxZMytGNlpqVVVIcmNi?= =?utf-8?B?UHMyemFwNzR0amp6VVRHZFJ6NHd5WjQrckF0QllSRkJ4TE4vMFpJbTNkUTR5?= =?utf-8?B?NStURlArc3BHanZVUU83REZHQVlLUEx5c2NHeXlJSlpqR3V2QjV4dkFidjFv?= =?utf-8?B?VDJ3VW13S245MU5iK3BRRHBWZFBJRS9ZQ3NUQW9BUlJ4RDBNODZEVXQ2cktG?= =?utf-8?B?N25SN2xGL2NqYnNtUnp5UlJLdVJEMG81NUhMSEZndlpvbTFkUGc4SkNMbkxh?= =?utf-8?B?aDA2QlpuRDdBLzF5N2xWaUpqdGlvQklZc2drVWJ2NlNBUjZGcmtXWVZ5dktX?= =?utf-8?B?endncGdkeGlYMHZONERHNmxMREJlRUtndXpnL281Y3pneitXRkdBOEEwWTBZ?= =?utf-8?B?ZTZCTnBRbmlrQlVacmZPZWxEcE1UTzcvbm5TMmlOUWJ0VCtQWEpDTlhKUHdX?= =?utf-8?B?b05xU0EzUVVFSUZJMHlTNk5STThoaFR1ZnJycS9pQUZGVlNRWms5QSthc1FH?= =?utf-8?B?VzlmM2gvNnJjWDE2TVdKV3FuTERhZHJMWTZDNVF3Rit1VERtWUFuQ05XQzB6?= =?utf-8?B?eEcwSGY1NW1ObHhwb3hpcW5NcEd5ZXhTRjFDS2tFTUJYRVozTmVESlYzenF4?= =?utf-8?B?VE5OOWx3dnBzem9ERnprV1RueTNvbnZmSWc0QnVQVjlSL204QlIzOXlhaVk1?= =?utf-8?B?OUsvclR6WU53U0VmRlYvRjhJQkpRWHVrOHMydndUKzRrNERKNGpBVm9tY2JV?= =?utf-8?B?U2dlNGNaUEM3ckFERGF5LzF2cy9ZMFVubm5PRStZM0RDRmRBWmowM2Y1Zm80?= =?utf-8?B?S0JqQ0JVZko3amJkeW5iQnNjUk5Cc1dzazgvamhzcUJxTS9EZENqbnJEQXJ3?= =?utf-8?B?VDJSbmVMYmZYTEVzSDhacXJ0S3hjanNVZTYvNFFyVHF3bXl2cHVpWkpjeVhD?= =?utf-8?B?bVRwQ3pwWW9DQXdGbEVqaUcvR2tnYVdQV0VPQThJNG5SRysxdGN3cXIwTG03?= =?utf-8?B?R0ZHZlM4YU9Dd3Y4a2ozWS9xZ3BXRjN2MzhNOG4vOGI2U0ZUR3VVOUIvaW95?= =?utf-8?B?RkZZYVlrQjNPdjdWaGVsYUxsR2Q1bUpLRzlZR1czb0JvMVU5Wlk1OTZGQzZr?= =?utf-8?B?NlJZODI1N21kNTR2YW5vKzFWenBGY2NNQTJuMCtMcWd2emgvNWZNVm5DRjI0?= =?utf-8?B?ZkpUS0RuYTZFa0JQbFE4bmw3ZS9XQ3lER0d2bG5FbXlVSWFoazFVd1p3PT0=?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;5:wuR91WkA77PmuCP1VItdYMcrEKOrotQXl4ZNVRCz468OYy+Rbs8rlGF0qiRDv3IKPZzIOjespZAk+hSrPPpt2IPMSLk4bWkWqa61zKN5kshUrHRp0a8OYyt4KMrMwNb63ETN/OSv6yYzxne9QEBHiw==;24:evNVKZy2saXlbowaz8VE3sL4DuDo8CvMkhF5LO2S2+rGBYpLBFCZyugydLlyh2GXDlP/9nwLWvuWnrai9wy/fp55f64unMfeskgtcbU/DVs=;20:KmDheN/2xxhhrPAYckcScfjKqaRcJUOmOcAavjWBxKpoYPFB+LeekrZfP/E/2RYdYFGI2LdCws5eVr2MFb5Lqg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2015 22:52:40.7861 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1487 X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1422;2:x2pmmTtrRGHQOpC3lf7GqXnL57eoPl116piM3xuWwTMpf5xMAFtNOZQcPC5zasBfqDYoHXKwq5fj0PsPZ54afT452YJ0QI6pWW59/LvrurXS800QmhD/nTGDF5hA7LWy8P4MLDZzYVaozg5jyC3m1l00VivLdcoaiVWiqcf0Jrs=;23:6XevZeWVrB1CCtOaj/Dyi3CaNE9tfHwh1Tpn1B/9TuxqDLcrio5OZGqYq3WSTj6gBNliGAn51Rd+rDNFudZeP7l8FcjZ3EYESV7u/pl0JZeye9wDarpAIwEL4VOtpocfqpzCIfU/XCW45iV3jMZJWZsGP0sFk1BYUxVnhg18WEv4CIMm8ju8hmnsxmBtqAcq X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-09-23 at 00:49 +0200, Christophe Leroy wrote: > Le 23/09/2015 00:34, Scott Wood a écrit : > > On Tue, 2015-09-22 at 22:57 +0200, Christophe Leroy wrote: > > > > Here is what I get in asm. First one is with "if (i) mb();". We see > > > > gcc > > > > puts a beqlr. This is the form that is closest to what we had in the > > > > former misc_32.S > > > > Second one if with "mb()". Here we get a branch to sync for a useless > > > > sync > > I was more concerned with keeping the code simple than the asm output. > > > Right, but is that so complicated to say: if we did nothing in the loop, > no need to sync ? As I said, it doesn't matter very much. I wouldn't put it in personally, but it's not worth a long discussion. -Scott