From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751390AbbJBEut (ORCPT ); Fri, 2 Oct 2015 00:50:49 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:43163 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbbJBEur (ORCPT ); Fri, 2 Oct 2015 00:50:47 -0400 X-AuditID: cbfec7f5-f794b6d000001495-f8-560e0d223937 From: Andrzej Hajda To: Stephen Boyd Cc: Andrzej Hajda , linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz , Marek Szyprowski , Michael Turquette , linux-clk@vger.kernel.org Subject: [PATCH v2 14/38] clk: vt8500: fix sign of possible PLL values Date: Fri, 02 Oct 2015 06:49:53 +0200 Message-id: <1443761393-29366-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <20151001225628.GU19319@codeaurora.org> References: <20151001225628.GU19319@codeaurora.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjluLIzCtJLcpLzFFi42I5/e/4FV0lXr4wg2kNKha31p1jtdg4Yz2r xceee6wWl3fNYbNYe+Quu8XFU64WP850sziwe7y/0crucbmvl8mjb8sqRo/Pm+QCWKK4bFJS czLLUov07RK4Mva2HmApWMpfMWf/Q9YGxnM8XYycHBICJhJ3/zSwQ9hiEhfurWfrYuTiEBJY yigx4dBrKKeJSWLa9UksIFVsApoSfzffZAOxRQTUJb7vOAlWxCzwjVFizfO3zCAJYQE3iY0r GsEaWARUJZZdbgKzeQWcJVr3vmSGWCcncfLYZFYQmxPojBd7TzN2MXIAbTOWuH2mdAIj7wJG hlWMoqmlyQXFSem5RnrFibnFpXnpesn5uZsYIaH0dQfj0mNWhxgFOBiVeHg3nOUNE2JNLCuu zD3EKMHBrCTCa83OFybEm5JYWZValB9fVJqTWnyIUZqDRUmcd+au9yFCAumJJanZqakFqUUw WSYOTqkGxtq5d0Jcpjux6/6Re/B2Y9Dqt1bVxUweSmzmcTV+CfJPC/bZ9GwqP5HkwTffplbx 1RRRi5BbPutdN58+9+v/1XseLcfWftFhucQ4a8umgjP9E1fU56n3pl8u7f3qpiwYdnxT0mdX la/OrslTJXxblktsyntTtP+8xbT/r6SzD1z+yVU++x3TbCWW4oxEQy3mouJEACQBA3EhAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With unsigned values underflow in loops can occur resulting in theoretically infinite loops. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- Hi Stephen, This is modified version according to your request, ie only problematic variables have changed type. I still think that 1st version is better, but of course it is up to you. Regards Andrzej drivers/clk/clk-vt8500.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c index 37e9288..98c4492 100644 --- a/drivers/clk/clk-vt8500.c +++ b/drivers/clk/clk-vt8500.c @@ -384,7 +384,8 @@ static void vt8500_find_pll_bits(unsigned long rate, unsigned long parent_rate, static void wm8650_find_pll_bits(unsigned long rate, unsigned long parent_rate, u32 *multiplier, u32 *divisor1, u32 *divisor2) { - u32 mul, div1, div2; + u32 mul, div1; + int div2; u32 best_mul, best_div1, best_div2; unsigned long tclk, rate_err, best_err; @@ -452,7 +453,8 @@ static u32 wm8750_get_filter(u32 parent_rate, u32 divisor1) static void wm8750_find_pll_bits(unsigned long rate, unsigned long parent_rate, u32 *filter, u32 *multiplier, u32 *divisor1, u32 *divisor2) { - u32 mul, div1, div2; + u32 mul; + int div1, div2; u32 best_mul, best_div1, best_div2; unsigned long tclk, rate_err, best_err; @@ -496,7 +498,8 @@ static void wm8750_find_pll_bits(unsigned long rate, unsigned long parent_rate, static void wm8850_find_pll_bits(unsigned long rate, unsigned long parent_rate, u32 *multiplier, u32 *divisor1, u32 *divisor2) { - u32 mul, div1, div2; + u32 mul; + int div1, div2; u32 best_mul, best_div1, best_div2; unsigned long tclk, rate_err, best_err; -- 1.9.1