From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>,
Don Fry <pcnet32@frontier.com>, Oliver Neukum <oneukum@suse.com>
Cc: linux-net-drivers@solarflare.com,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
netdev@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-serial@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 11/15] sfc: don't call dma_supported
Date: Sat, 3 Oct 2015 17:19:35 +0200 [thread overview]
Message-ID: <1443885579-7094-12-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1443885579-7094-1-git-send-email-hch@lst.de>
dma_set_mask already checks for a supported DMA mask before updating it,
the call to dma_supported is redundant.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/net/ethernet/sfc/efx.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 974637d..4abe886 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -1247,11 +1247,9 @@ static int efx_init_io(struct efx_nic *efx)
* masks event though they reject 46 bit masks.
*/
while (dma_mask > 0x7fffffffUL) {
- if (dma_supported(&pci_dev->dev, dma_mask)) {
- rc = dma_set_mask_and_coherent(&pci_dev->dev, dma_mask);
- if (rc == 0)
- break;
- }
+ rc = dma_set_mask_and_coherent(&pci_dev->dev, dma_mask);
+ if (rc == 0)
+ break;
dma_mask >>= 1;
}
if (rc) {
--
1.9.1
next prev parent reply other threads:[~2015-10-03 15:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 15:19 remove dma_supported and pci_dma_supported as public APIs Christoph Hellwig
2015-10-03 15:19 ` [PATCH 01/15] pcnet32: use pci_set_dma_mask insted of pci_dma_supported Christoph Hellwig
2015-10-06 3:57 ` Don Fry
2015-10-03 15:19 ` [PATCH 02/15] tw68-core: " Christoph Hellwig
2015-10-03 15:19 ` [PATCH 03/15] saa7164: " Christoph Hellwig
2015-10-03 15:19 ` [PATCH 04/15] saa7134: " Christoph Hellwig
2015-10-03 15:19 ` [PATCH 05/15] cx88: " Christoph Hellwig
2015-10-03 16:58 ` Mauro Carvalho Chehab
2015-10-03 15:19 ` [PATCH 06/15] cx25821: " Christoph Hellwig
2015-10-03 15:19 ` [PATCH 07/15] cx23885: " Christoph Hellwig
2015-10-03 15:19 ` [PATCH 08/15] netup_unidvb: " Christoph Hellwig
2015-10-07 8:03 ` Abylay Ospan
2015-10-03 15:19 ` [PATCH 09/15] mpsc: use dma_set_mask insted of dma_supported Christoph Hellwig
2015-10-03 15:19 ` [PATCH 10/15] nouveau: don't call pci_dma_supported Christoph Hellwig
2015-10-03 15:19 ` Christoph Hellwig [this message]
2015-10-05 15:08 ` [PATCH 11/15] sfc: don't call dma_supported Bert Kenward
2015-10-03 15:19 ` [PATCH 12/15] kaweth: remove ifdefed out call to dma_supported Christoph Hellwig
2015-10-03 15:19 ` [PATCH 13/15] usbnet: " Christoph Hellwig
2015-10-03 15:19 ` [PATCH 14/15] pci: remove pci_dma_supported Christoph Hellwig
2015-10-03 15:19 ` [PATCH 15/15] dma: remove external references to dma_supported Christoph Hellwig
2015-10-04 9:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443885579-7094-12-git-send-email-hch@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pcnet32@frontier.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).