From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Christoph Hellwig <hch@infradead.org>,
Hannes Reinecke <hare@suse.de>,
"James E.J. Bottomley" <JBottomley@odin.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: [PATCH 0/2] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k
Date: Mon, 5 Oct 2015 11:26:38 +0200 [thread overview]
Message-ID: <1444037200-14684-1-git-send-email-linux@rasmusvillemoes.dk> (raw)
In-Reply-To: <20151004080217.GA22816@infradead.org>
This reduces the impact of choosing CONFIG_SCSI_CONSTANTS by about 8KB.
2dd951ecd511 ("scsi: Conditionally compile in constants.c") updated
the Kconfig help text from 12KB to 75KB. The 12K predated git so was
certainly outdated. But I'm not sure where the 75K comes from; using
size(1) on a defconfig (with/without this config option) vmlinux shows
a difference of about 47K, and 39K after these patches are applied. In
any case, I've left the Kconfig text alone, since I'm not sure I'm
counting the same way the 75K was computed (I'm fairly certain of the
8K delta, however).
Tested with a trivial module calling scsi_extd_sense_format with a few
random known codes and comparing the result to the expected value.
Rasmus Villemoes (2):
scsi: move Additional Sense Codes to separate file
scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k
drivers/scsi/constants.c | 860 ++-------------------------------------------
drivers/scsi/sense_codes.h | 835 +++++++++++++++++++++++++++++++++++++++++++
2 files changed, 857 insertions(+), 838 deletions(-)
create mode 100644 drivers/scsi/sense_codes.h
--
2.1.3
next prev parent reply other threads:[~2015-10-05 9:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 17:30 RFC: reduce CONFIG_SCSI_CONSTANTS impact by 4k Rasmus Villemoes
2015-10-03 17:14 ` Christoph Hellwig
2015-10-03 22:09 ` Rasmus Villemoes
2015-10-04 8:02 ` Christoph Hellwig
2015-10-05 9:26 ` Rasmus Villemoes [this message]
2015-10-05 9:26 ` [PATCH 1/2] scsi: move Additional Sense Codes to separate file Rasmus Villemoes
2015-10-05 14:05 ` Bart Van Assche
2015-10-06 15:27 ` Rasmus Villemoes
2015-10-17 22:12 ` Rasmus Villemoes
2015-10-05 9:26 ` [PATCH 2/2] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k Rasmus Villemoes
2015-10-05 14:11 ` Bart Van Assche
2015-10-06 15:31 ` Rasmus Villemoes
2015-10-06 1:32 ` RFC: reduce CONFIG_SCSI_CONSTANTS impact by 4k Julian Calaby
2015-10-06 15:39 ` Rasmus Villemoes
2015-10-06 23:01 ` Julian Calaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444037200-14684-1-git-send-email-linux@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=JBottomley@odin.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).