From: Yann Droneaud <ydroneaud@opteya.com>
To: Gabriel Laskar <gabriel@lse.epita.fr>,
Dave Chinner <dchinner@redhat.com>,
Ashish Sangwan <a.sangwan@samsung.com>,
Namjae Jeon <namjae.jeon@samsung.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2 3/3] falloc: expose ioctl numbers into uapi
Date: Tue, 06 Oct 2015 16:43:51 +0200 [thread overview]
Message-ID: <1444142631.3188.53.camel@opteya.com> (raw)
In-Reply-To: <1444141657-14898-4-git-send-email-gabriel@lse.epita.fr>
Hi,
Le mardi 06 octobre 2015 à 16:27 +0200, Gabriel Laskar a écrit :
> Signed-off-by: Gabriel Laskar <gabriel@lse.epita.fr>
> ---
>
> v2: missed the include of <linux/types.h>
>
> include/linux/falloc.h | 18 ------------------
> include/uapi/linux/falloc.h | 20 ++++++++++++++++++++
> 2 files changed, 20 insertions(+), 18 deletions(-)
>
> diff --git a/include/uapi/linux/falloc.h
> b/include/uapi/linux/falloc.h
> index 3e445a7..28abee4 100644
> --- a/include/uapi/linux/falloc.h
> +++ b/include/uapi/linux/falloc.h
> @@ -1,6 +1,8 @@
> #ifndef _UAPI_FALLOC_H_
> #define _UAPI_FALLOC_H_
>
> +#include <linux/types.h>
> +
You should also add #include <linux/ioctl.h> for _IOW() macro
> #define FALLOC_FL_KEEP_SIZE 0x01 /* default is extend size */
> #define FALLOC_FL_PUNCH_HOLE 0x02 /* de-allocates range */
> #define FALLOC_FL_NO_HIDE_STALE 0x04 /* reserved codepoint */
> @@ -58,4 +60,22 @@
> */
> #define FALLOC_FL_INSERT_RANGE 0x20
>
> +
> +/*
> + * Space reservation ioctls and argument structure
> + * are designed to be compatible with the legacy XFS ioctls.
> + */
> +struct space_resv {
> + __s16 l_type;
> + __s16 l_whence;
> + __s64 l_start;
> + __s64 l_len; /* len == 0 means
> until end of file */
> + __s32 l_sysid;
> + __u32 l_pid;
> + __s32 l_pad[4]; /* reserved area */
> +};
> +
> +#define FS_IOC_RESVSP _IOW('X', 40, struct
> space_resv)
> +#define FS_IOC_RESVSP64 _IOW('X', 42, struct
> space_resv)
> +
> #endif /* _UAPI_FALLOC_H_ */
Regards.
--
Yann Droneaud
OPTEYA
next prev parent reply other threads:[~2015-10-06 14:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1444141657-14898-1-git-send-email-gabriel@lse.epita.fr>
2015-10-06 14:27 ` [PATCH v2 1/3] mce: change asm/ioctls.h for linux/ioctl.h Gabriel Laskar
2015-10-12 14:30 ` [tip:ras/core] x86/mce: Include linux/ioctl.h in uapi mce header tip-bot for Gabriel Laskar
2015-10-06 14:27 ` [PATCH v2 2/3] msm: remove unused header Gabriel Laskar
2015-10-06 14:27 ` [PATCH v2 3/3] falloc: expose ioctl numbers into uapi Gabriel Laskar
2015-10-06 14:43 ` Yann Droneaud [this message]
2015-10-06 16:21 ` [PATCH v3] " Gabriel Laskar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444142631.3188.53.camel@opteya.com \
--to=ydroneaud@opteya.com \
--cc=a.sangwan@samsung.com \
--cc=dchinner@redhat.com \
--cc=gabriel@lse.epita.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).