From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753443AbbJFQsY (ORCPT ); Tue, 6 Oct 2015 12:48:24 -0400 Received: from mail-bn1on0118.outbound.protection.outlook.com ([157.56.110.118]:48715 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752701AbbJFQsV (ORCPT ); Tue, 6 Oct 2015 12:48:21 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1444150089.5336.283.camel@freescale.com> Subject: Re: [PATCH v2 13/25] powerpc/8xx: also use r3 in the ITLB miss in all situations From: Scott Wood To: Christophe Leroy CC: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , , Date: Tue, 6 Oct 2015 11:48:09 -0500 In-Reply-To: <5613D6C5.1030100@c-s.fr> References: <94728e239cad2224383db7ddc1c57df7d11561eb.1442939410.git.christophe.leroy@c-s.fr> <20150929000039.GG6161@home.buserror.net> <5613D6C5.1030100@c-s.fr> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Originating-IP: [50.157.106.250] X-ClientProxiedBy: BY2PR02CA0124.namprd02.prod.outlook.com (25.163.44.178) To CY1PR03MB1486.namprd03.prod.outlook.com (25.163.17.16) X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1486;2:3kt69S0+Larz/vt8zQqBCXL7cj9Fu/kD4McAKjpIP095R7BQTt/BeIcz81PQDzsNA6yvGEzz3tRW8LzVcwza5Rv+NfPAS74KReNyl34/9nOGcD/bp2nO2k0KjoIqkjMrFI30rmIwZz8f1T9ciMWzbIyREbbdT/vhwt0pvTk/nDw=;3:SF5YPL07JMgB/2YsgMdHqxS4fs+DTKxLUg4mR/enjU8mldsW77MmZ9BW9hQrOnkDH9cwK+I6hfuJj4MiWqeIS/0rmSBbRN7E1alhDI5T8cbyfoc5YUQYoBLXvVGmuWm/jJ9BOeUC2M/5HwkE9pmZkw==;25:KfdWw0a9rgO6vV+W5amvJDUDwyU9YjDrg6S8fZIJTXitpmJ1/XyhLmBTznkx+4rR53AfsXpxCKYSwbPqYX3OeWynCQC6+cqc4EAT+ZKUtswMjUlqdDTRYXqqdlIgpKenwj4f5WpW+DG61C9AtrDLFh1YrkBZAMRBCOMRg9RhsswWMEtGx2kyRVR3f5hFXwQ84eL0+Rw+CNpIEefmv/JCum868F7B9AAwkH0F5hp1U6iCmguR99wl7BkYyEC8DTElXeHYkhfnCdJdlXMOSYuyyw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1486; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1486;20:cR/eZpfhgXZ70akv08SfwPgvaP5OgDiAo1qlySEeanT74qvUHsqUQ/BRV9zSLHgp6/uLgVC9EBvKj6zTFYdc+2uztr5IqiLjzFrCR4VVhtqfFJDUakaYF0D+XRpwYoE1Qx3ePVuRu8qR7e/PjDai9Ipztseg596jHSHjc+FUi7ypSHjsYYDcSqXXgJu1T1Ta0wgHG3wWE2/xg3IeFN9tId9DBcx7fST5JkYrhB+msHo0DW5SdxzjGeux1S3wUbBtBOH7gjNGzcBeiHBFyw9uygXFBU5+sXS9yCp4WDmI8+cSmk6IYzFov0f0q9rQxA3CWiDCOmcchDSwkxRWPeFA66Z8q+WMJMNv8giFPdV+C5xD1Pn0cO/mXwg5wHNLGtjGdXUDZelXY9SogxJJ99gzJmnhutLE759Q2dbnNWJDfXWYlyob702WmQDah77cIfNu75sYiYyBa+KPur/Ie3kqyxNifrlXi4iZZuj7TddrRQS+pJVsz/A4KYaFA0SR+8WH;4:p7g2YTpSbt5WzKzlnFxpdkJB1qxOXVOaiQ3OJ36puVJScViT5rD67+q7dxuJlHi//OHGIuhh/lkVoewhfXhGLKmSyVFm9EhmeD4w/PgK3Rhs53CB2iEQ7aqURSkRi+lj4l3RPE5fc7JCFy79m0cm1jr56NqAa76KWMM1TT0V3B9vy35xbHo+wnFq614LY+Z1t4cD7StdP7D8eIc3T9ZObCx8GuknCLUaw7ilSG/KnVnBhf6dskH/ZUsIlKuec2wtHF4aws0EHeA3c6brSw0PU1j5PUF7+SlF5jzIjAfLRBCCuYMiO4EBGOOeS7a2cXbbYuOoHkcGuxxluirNWLCgZ+/o4fu6JoXfmFWrR5EsC6s= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001);SRVR:CY1PR03MB1486;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1486; X-Forefront-PRVS: 07215D0470 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(189002)(479174004)(377424004)(199003)(36756003)(87976001)(77096005)(47776003)(5008740100001)(110136002)(93886004)(33646002)(189998001)(97736004)(50986999)(50226001)(19580405001)(5007970100001)(103116003)(5001960100002)(76176999)(81156007)(50466002)(66066001)(86362001)(101416001)(5004730100002)(46102003)(122386002)(40100003)(5820100001)(2950100001)(64706001)(42186005)(23676002)(105586002)(92566002)(106356001)(99106002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR03MB1486;H:snotra.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIxNDg2OzIzOjFLVUNaaFlRSy9ManJGK284VC9TbUpoYklu?= =?utf-8?B?cUR4NXNEVUJMbEk1cFU1R3dEVVI3Z3ZxT3JRTTBobTRyRTNMQjNISkd2RlpZ?= =?utf-8?B?dk0rNlIxZXcvMDV6VHlWR3JVUmxJdW4xRWhSV0FXZ0ZJZHV4VEZWOUFZbk9G?= =?utf-8?B?YmxRUWd4bE5DSytLVE5lRUdjVUlEanlhaFhiL1lPSHc3OXpsdnVncW50L2l6?= =?utf-8?B?OHlCOWpFNllhK003YmRwWC9zU3hjdzVTcHhXd0xnZEpicHJNbzdyQkJWOFBh?= =?utf-8?B?OXFLNC9UQ0EvT1FlNElsN3BJcjlCT1dLeXcwV1JJWjFIYnRJTGpNRUZSQ2ZI?= =?utf-8?B?ZGt2Wmozd3lPKytERlh0NW14bFVGa1dSZmhUKzMwUHBiZ1BtU3BwRFNBWU9W?= =?utf-8?B?citsU1Vwak9pbEtvbEZaaGh3R2Z2YytJSUExWTBGbEx6SG1HRHlRRjA3dnhs?= =?utf-8?B?NVJIeHYyWFAxNDJtMVgrTVVDM0M1ZUI2WjZrTkFuVUNQTXJNaHNkSzI3cTRY?= =?utf-8?B?dVdnYzltTTY2Q0NLdE53bmpuN2lXUW9LMlMxbE5GbEpYdTU2L0d2WVd1aFBQ?= =?utf-8?B?dmVNbnJDZlgvZ3pJOVgycTVRS0NrS2xCeHo4Vko4ZzNtZUEyUTBKYmI0dDJ1?= =?utf-8?B?YkpSOE1NVERHV2gzMG1wQTlTSlhCRnZ6YWNyUG1pdTE1YUdVeGNSbEdyRThi?= =?utf-8?B?UGtKV1U2K3RCWjlJUjJIMERObVpoRXVmT25oOFkwaU93RGMvekFyM0ZpOTg2?= =?utf-8?B?dUdjOTRyMU5TWnhtQ21sdWhuNVJFZDdXS2d4MEJiVU4vaSs2TDdTUXI4TnBJ?= =?utf-8?B?UGUxYjhScldjY2dTengvVHBpOUZOMkVjRFZiWWdlSHZuWVlzNklUeTF5d3Jn?= =?utf-8?B?VlNFSTZlNnl6WWRUOFRPNGlJYVpVYXk5ZFNzdklGdXRvSWdIaDIyZWFESDJm?= =?utf-8?B?SEpzV2FYZHJHQ0JqSkhXYVRUZjBzZjMrT3RGS3lGWG5oVmU0YUN6dUdjMkVn?= =?utf-8?B?UjN3ZWN4SEhrcTc2R09hNkwxeGs2SXp5QlZRdFNxWjVwdU05RmhxNzQ5VXdN?= =?utf-8?B?Tm1iem1SK1pzcTRKQXRYV3R4VVN0QnFUSG40ZUIxbmNqdk5vdEo2YTJYNmdD?= =?utf-8?B?ZUY0dEFDcTd4ak1jYmRnRzVCK3REYVJaUGZrMHI0Q21FOVZGdFdkR3hkV0Yr?= =?utf-8?B?UUZzMk9oN0prTS83cmQwSEl3Q3JtVWNpdWJHNytLZjFCalFYcXdHWVBkRkl0?= =?utf-8?B?Uzc5d2hsdTNlaFltM083TVlOV0Vxb0dBSWtJRERnb0plSEI5eFBVYlZ6WW5D?= =?utf-8?B?aVU5VE83TjBIOHUvb0FwY0xQWGNBQ1hNcVlTZmJaUlp5NzFUcmp3NEJvRW52?= =?utf-8?B?UUU2Si93akNnZFdHT2t6OWRrQ2o1eFoxSElhOE83NThndlhMcjIvUlhOYzdU?= =?utf-8?B?N0swVDNwZFhONDFtRWV5ckpZZlVZdUIxcHYrSWczMXRyTXlndlFyM2RVUWF6?= =?utf-8?B?eWtmdz09?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1486;5:Se4t7U08z9SLazacG0NeT4mzWNVBoCPjjm4RUZ2yrNWBSEWYjTc8UELYI0z17OGrurfv1dc5JuKrMI3R6JEUdTjG8tcgb0cba2wwsCBbpWlSR0yKpaZsEnWeRHmrWcjOJ9WoMwnezpM1f4yWmL7EbQ==;24:Uv6B0pyb5nIBaAYt2Bc/idcfrWWHfadHVur0cV8pVr+ZgB6tMEARK8RHdPKAoK7SB44RAzkdsBjr8QsaMmCq5g9siu0+ZISpJRetNHc4AIk=;20:HMvFXtB8ddTETWI1qJnz2yVZjlyujpqZsi7ihfVkdew2b0jOgRDqZzFYfZl+xoNLGjKCsn6OUENlGkmxXmX2fg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2015 16:48:18.0364 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1486 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-10-06 at 16:12 +0200, Christophe Leroy wrote: > Le 29/09/2015 02:00, Scott Wood a écrit : > > On Tue, Sep 22, 2015 at 06:50:54PM +0200, Christophe Leroy wrote: > > > We are spending between 40 and 160 cycles with a mean of 65 cycles > > > in the TLB handling routines (measured with mftbl) so make it more > > > simple althought it adds one instruction > > > > > > Signed-off-by: Christophe Leroy > > > --- > > > No change in v2 > > > > > > arch/powerpc/kernel/head_8xx.S | 15 ++++----------- > > > 1 file changed, 4 insertions(+), 11 deletions(-) > > Why is this a separate patch from 1/25? > > > > Same comments as on that patch. > > > > > Just because here there is no real need behind the simplification of the > code, whereas the first one was a pre-requisite for the following patch. > Should I merge them together anyway ? If there's no real need, why do it? It's not really a major readability enhancement... -Scott