From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752658AbbJFQ4z (ORCPT ); Tue, 6 Oct 2015 12:56:55 -0400 Received: from mail-bl2on0116.outbound.protection.outlook.com ([65.55.169.116]:15487 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752559AbbJFQ4x (ORCPT ); Tue, 6 Oct 2015 12:56:53 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1444150599.5336.289.camel@freescale.com> Subject: Re: [PATCH v2 15/25] powerpc/8xx: move 8xx SPRN defines into reg_8xx.h and add some missing ones From: Scott Wood To: Christophe Leroy CC: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , , Date: Tue, 6 Oct 2015 11:56:39 -0500 In-Reply-To: <5613DC41.2000100@c-s.fr> References: <20150929000346.GH6161@home.buserror.net> <5613DC41.2000100@c-s.fr> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Originating-IP: [50.157.106.250] X-ClientProxiedBy: BY2PR02CA0126.namprd02.prod.outlook.com (25.163.44.180) To BLUPR03MB1476.namprd03.prod.outlook.com (25.163.81.18) X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1476;2:jO0qzZAeUu+tn0hW/9cEvw+yTGZ7bZF+vo7o1sKq6R5Rpi68JD7OJBeuqqsKJY093WVQ8yiK4Cb4EbCMPMMW+ET/TQQ069IhFmdzp167nfFT3+6lFGUBywijgm7qgbGPoO2tFZoFmW8wnqhS//7gEbFrnXh5sQI1jV+yAOMyVbo=;3:9ESmySluU6xRBgNBzpy9nuW/zAZN/ZtOQkq5Rflo1whRAXpnsjmDIWeD/ZX9xFMMvLyMwbBS4Xy4XqrGToO2H2OP5HWxSgdBJqCemQ/+/BuISyr1ADIAYC+a9XLjls6w7dArt1Cj+ZjnlBJ1zzAfxg==;25:BBOGzKIgNMPUZfmwuPdxSkQByqJME5/ZpUy2ebsErzb3QN1Mdi08wgck6d6DAh2GSIf/dzZO4Rl+Wbw8UecOQu7yr8L9+fnoPlTaLjubXc3LW5O0ffZP40DcvoGRfP88jBsNfOChcYWjcYn0Fd5tltQ1ulGPUCz3XpaasOeoB/PA5et1ZK2u8JzGfTSf0u7l1lPnEiSRkGIKIGTCbIztNyI0vQ03diXSRk1/gSiEin87TaiEkyPkMImFuYQulJd3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1476; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1476;20:3Ve1l/j4mpgX5SgS5GM594Tb42TIjTSHdE9NJTr4B3hVTE7N+bULmlOe2EOMSiIFoQOvdAHfnk+NIpv1meb2KlABgA6VdAiuXCwQGfFW6twt7q9t0VpNtR4whGRdlQkDkqML65kC0uzjQg/MnvjAdahOHHenmtRrVdiE5pS9ZSIxhDoDkSEhyEpdqPeX18cR7Tki1nbPwHTaSDCKC4ife24qhnuRiqEfak7NxERJ4DXjF5vwyUQOaCJvcLkhbi5l7tUAruLpiuYPGD0+MrvIAWGTGB+oNiIDOq5N1knUIui5Yeje9jeluuOyYGrDKKUzoNDL8Fl/rH2JrSk6tzEowkUbnhEKEkoFvPhgtOmKRAPzicgJjNM9WG328Y/2gLDZjTtIeJm+PfuxY17JnjRAkCctwxoeyHXKTEHxZ6waD2A+Nt1MXlGjObPOa6j4/KbpHujwBfdzmQlHx8uo9tiWjdwZuBMM8ssJfHwuUwy9wvdq34FH4vrhUGmBxXPfZMqn;4:0Gczfgy1JKp1B1jDABBM76x53QF3CCNHRgTUiicCAHDT6RCnmDcn94WV81J66AebJ8fAebU0nIND73p3cNsfixHLTiJBjwedQUCB0p9wml6pt/vhkz90iskUlNG+bzxSX6qp92rm6OK4qVEoTzhMesTWyBz357+vz/5RT5W6jRFiHULYMAVuOl0N80sL7I3KuoCb14WqKftkcHSbQTf4tLvFFsQSloGNyjH9y2xhFb2q40syae2OjfvuhANqd4ns/yXuJsjpRdRl1c3Dm0V2hVhMUSdiO/kOuAW6AL27IiASt5TE+3Tkp/2rn0qSwCAiwYY+v+laUwpVKj01eHkRhesp6GKjBX/bNFEsSIn8fb4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001);SRVR:BLUPR03MB1476;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1476; X-Forefront-PRVS: 07215D0470 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(199003)(189002)(479174004)(377424004)(23676002)(93886004)(92566002)(5001920100001)(47776003)(122386002)(42186005)(5004730100002)(106356001)(105586002)(40100003)(46102003)(36756003)(86362001)(2950100001)(5820100001)(76176999)(81156007)(5001960100002)(50466002)(77096005)(101416001)(19580405001)(66066001)(97736004)(103116003)(50986999)(87976001)(50226001)(33646002)(64706001)(189998001)(5008740100001)(110136002)(5007970100001)(99106002);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR03MB1476;H:snotra.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjAzTUIxNDc2OzIzOm1iUjc3K3hLRmVzbTQzRTJkUEtESXU2cWVW?= =?utf-8?B?bWc5RzRsTDA2Rms0VW5xMUI5dlB1MFhLcU9tTnVXOGxuQ0dJUzR5VHdVUGVR?= =?utf-8?B?NVRLZ2VCZkNrYXc2U1pRT2RsdFZQbWF2dy82WDdpQVU5OVlmS1Z3RCtEb3lP?= =?utf-8?B?RHJqc3FrZEsvWTd0Vmg2NWw4OUtBVC9uSlRMR2kwZ1NKR01sNHdYMG5mYXVL?= =?utf-8?B?VHBmRmNvMzljWEdtakxVTjJNRGdCeUp6MTJQd1NKVU54ZWVBb3YxenM4bnRV?= =?utf-8?B?VzFkenpNOXplQzB2bXMyNSt2YXY4VEY1eTFXSFIwMlkzcWlpN1RYM295bTJ2?= =?utf-8?B?ZWx3cldDME5vSktqYlRGTTVncXkxOURyV093THpVeTFobHEvdU5hVTNSMGFI?= =?utf-8?B?OEU4eXpsRmRBTnpxQUZRaSs1UStGSlppRmZWWDlVb2U0N3FoQmlqb1k3OStq?= =?utf-8?B?S0REek1FMkQ2dHBtK1pGUWpRY1AxTDFUZlRyaWI4OVp2bkZyOURpbXcrQmN2?= =?utf-8?B?RXZUMStHVnBFNzdJeU52TkdxTjVBbTA1aGtnQjVITVlaSnppZ2lsbDRDNkVB?= =?utf-8?B?R0pvdy9wWjVMTzdTZ0hpbTNBNkl3ZGtyVGdqZEQ5Yi9jb2JvNmlyTGpnM0cx?= =?utf-8?B?LytlTWRqZkZnRVIyVUp5dUtnNkhTejFlT1A4TUR2cG56cEwvQ1NIditZNjdj?= =?utf-8?B?UTEvY1ZnSkVUVXR5Y0RoVmJnWmlhWjQ3SHJzWU8zQVVNQWdhL1RmTTZJaGVh?= =?utf-8?B?Z1lDVHFxWUxGemxsSlQzNUNiZG1uMzU4L25XRGRZM0ZHOFV5aEx4UkxEcUY4?= =?utf-8?B?dkxRTW1uUUN0OUlFMVdNNGJseGVsYkdCbUp0UStNRDNVckZnT1lSaXk3WFcr?= =?utf-8?B?UzRkMkNCU0VydWl1S3pvdDltK2VFQStFSE5DZXFpYnFzdndCbUJpVWxsdFA4?= =?utf-8?B?bTErVXo3ZU9zU3dqYVZuajV6Vys1MjZObVJPVjlKVElXbW1EQitzSnhhNU1p?= =?utf-8?B?OVNyUER2MlppMWxKbG51a3FmaFZYSUIwYk1Oa1BSRm1ZNXpacC8zQWdSb0Vw?= =?utf-8?B?MjR4WW1tdVdQSzRrMWFkRmcxU2NVWWN2VFY3enFpVWJaeURPbXlQN25KYWNL?= =?utf-8?B?SENSMVlOeUtRb0xEeE9NMi9xblZUOFdpaWROOWJUS3hpSW9xTW5jUnRkZ0Qw?= =?utf-8?B?K1RMbDYzNDJsL293TTh6S2J2T1dURTJLMFVrZmlPUktjQ2VJeksxaVB0UlBw?= =?utf-8?B?eVduQU04eG1aQzh1SlJCQy9TMmozSWl5U2w2Q3ZQaUk0MnROemt2SENISnJy?= =?utf-8?B?TWRjaEtrUERlZGM2NDN0dkZQR1gzU0NLdVRYeEVEWmN3YkNsTXdHTkpHc0ht?= =?utf-8?B?UERGSUtCR0p3V2F5WWtWb0M0YjNOMVRTem1TRmhmWWZzRVQwZlMyZk9XMGpt?= =?utf-8?B?VS9OUUdkNkpDWmJUbmtQS1lEeHZ5SDRzQW45M3JkeHUwNkhpSVh6dHNuWHds?= =?utf-8?Q?Uwb3t6YYUU/TgffrY2XQFbTDqQJxberzXwrQ0fN8t3hjJi?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1476;5:VY2Z82r1H1eUdHIypHYYSS3EJeTYm7e6mTfnK6TkgBol+n8h+K+2+6Ld7liEAE+LuioS/kaMsWxVT5QI0k2lWqFkGgCtUwsnxt4JBDW7SrHrrx88mF9LDIXt7voFnjwguxGwqu5InmlgJKg1lkYyEA==;24:4COnR8SwL/kNfIvHCku9KmMuwSBIoE2b2UxJ76UFPcEp1MqDOkdAHB8PCRAfo6VRbcC9pKCwh1XqpxkEJSgsyVPMQXSkU5Z4/Yx/mhnIs+c=;20:h/DsE4rYjSwqCDIYob9dBIX78SbLGt3TNoHLNF+lMzxqGx0hrU8I+e18Ez+6PkNXhvwB/Q6SVGoW/IIU/+oUFg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2015 16:56:49.9618 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1476 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-10-06 at 16:35 +0200, Christophe Leroy wrote: > Le 29/09/2015 02:03, Scott Wood a écrit : > > On Tue, Sep 22, 2015 at 06:50:58PM +0200, Christophe Leroy wrote: > > > Move 8xx SPRN defines into reg_8xx.h and add some missing ones > > > > > > Signed-off-by: Christophe Leroy > > > --- > > > No change in v2 > > Why are they being moved? Why are they being separated from the bit > > definitions? > > > > > It was to keep asm/reg_8xx.h self sufficient for the following patch. Again, it would have been nice if this were in the commit message. > Also because including asm/mmu-8xx.h creates circular inclusion issue > (mmu-8xx.h needs page.h which includes page-32.h, page-32.h includes > cache.h, cache.h include reg.h which includes reg_8xx). The circle > starts with an inclusion of asm/cache.h by linux/cache.h, himself > included by linux/printk.h, and I end up with 'implicit declaration' issues. > > How can I fix that ? mmu-8xx.h should have been including page.h instead of assuming the caller h as done so... but another option is to do what mmu-book3e.h does, and use the kconfig symbols instead of PAGE_SHIFT. -Scott