From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756362AbbJHTNj (ORCPT ); Thu, 8 Oct 2015 15:13:39 -0400 Received: from mail-by2on0127.outbound.protection.outlook.com ([207.46.100.127]:28576 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755720AbbJHTNh (ORCPT ); Thu, 8 Oct 2015 15:13:37 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1444331608.5336.329.camel@freescale.com> Subject: Re: [PATCH v2 05/25] powerpc/8xx: Fix vaddr for IMMR early remap From: Scott Wood To: Christophe Leroy CC: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , , Date: Thu, 8 Oct 2015 14:13:28 -0500 In-Reply-To: <561662ED.1040103@c-s.fr> References: <83ffd345e7a3fe00443e32b6caf900e7618453d6.1442939410.git.christophe.leroy@c-s.fr> <20150928233900.GB6161@home.buserror.net> <561662ED.1040103@c-s.fr> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Originating-IP: [50.157.106.250] X-ClientProxiedBy: CY1PR12CA0031.namprd12.prod.outlook.com (25.160.137.41) To BY1PR03MB1482.namprd03.prod.outlook.com (25.162.210.140) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;2:prqKTCEWJAipJPI8RAWShkvMiEWoHKYbOEuslpTZwjDe85eIZMrSzcekpcf/ux69BLez4DObl83pnQM2/VW9yWthZ/xxAxQGp8HlfvN9oIzVE7eaS9N1fnLmmMsf+UHCwV4ueoWLEHUjl07MQcSNqpDv5veRSjUtsaCPYHOKVb4=;3:f8VedHLSxWucTJrM6CkV4xHUirulCdH8hGUv38gAzM/xr73hqlaQ2BlaHeWO0KwPXiAGREQjrdfL3ZIUsQ7RXVTQeaK23YuDT6tbIZbJDSU/H0jYb7ObHAWHxV7r/7gGeFtUXqIxD5qDYDzPdRZD9A==;25:TCGlMt83DI81bIlTZiINfSbkmB2s2ZkXlGte7LwoGxB9yCBX36sjKxWz/HKmtr22LWK1j+qi2N8Fuc1RbVi8kVUW7rxyTvUJMCGnuiVV38a2HpYC1eECzlmCd5xI8bc8SqT3m2/Q95dxLMaN0SJZlcyKr+Fb+Q8KTSS8bMRx+LP6oksmCOlI+O1+Wsq4ETZt6t7XQnFOLq0b8cBjdHb9yosrP4fLQUYfoaPr7wVTwNK/68V6Cg5zNclCV9+s0ypCLVOibn8H3elcaDJ5xmKm+Q== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;20:enPixNOg0LtVZ6CwWFEa4ZL3O+c72Yjic03ZOI+i1IAQ/e6zhrFqjpjtrrBudg6scUsqUtRwlshBTARDPXp51xZzA1d/VAYNk7OHmSVPRc7jTeMRpTBN4+nivilpMdCy//DkzHG6cet7bfNYd0KauZk5YibwFxavbDr/gO486QslU63Mz+Dl0iQsr6OMFl0J5GTZ5rMhII734Ecu48dtBnSLl/fjRyYGq6fyrDuFJ1ZAp8W1LtzDu74sSSiNh7GPSMJY/MtTw0ybRSjAVva0XR84Y7rZcRJLu1HnHMTZjc6ccYMNljppNHHdimJPxuRHMcQgDOom+TbDLaO3HJ1L3WbTtWrlGJ8qj3fS1I4/ycWWaw88+cHuGjbiuDBJSvyysJv7aJW2oVBfD1VEru9YzX+AUkqENotNOj9oE3wQOJPNL1348HOiRtMivESazHUIVCG7ziu/ORL7vYLkvtxT0Lk5zkXMtqjvw80jETpUY/CY5xLOZKwBUdQimV+PSyIV;4:b+M8eW1VBldABa0HQ6X9+m386+lJcCwbR6Kwk/2mBICAiTQNnGD1k6M+vwMgn8HI1QWeeqfRv3+wAaUtuZ6ts7FI6fJkUur6TBEXTB8Wb36R0qrDSvT/UFJwU0N5ovHyU1eUyLY8WGhjz1P3R9IvuhomiZ+Q8XPe3BNhp8vjZZfg7XGy6dkb947tPDyIjEuxz5ZuADwPiZfjLMwXAuxGC2Oq8x2fNIw8fI8S8Dho+lRWybAUXBdFYyTnWC6mT2GV8F2udaQMDlYgNRDkkIIE31yip8jzrJ7UDAiZAGcHzwmV12+cYsiqkXnhM0G+462UpJugGPUyy6iNchde3B8sn7utO7Pc9wiWoa57yBNRuMA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001);SRVR:BY1PR03MB1482;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; X-Forefront-PRVS: 0723A02764 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(479174004)(377424004)(189002)(199003)(50466002)(42186005)(23676002)(2950100001)(92566002)(40100003)(97736004)(87976001)(19580405001)(81156007)(50986999)(122386002)(33646002)(36756003)(5820100001)(189998001)(5001960100002)(110136002)(47776003)(64706001)(66066001)(77096005)(76176999)(103116003)(86362001)(5008740100001)(105586002)(93886004)(106356001)(50226001)(5004730100002)(101416001)(46102003)(5007970100001)(99106002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1482;H:snotra.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjAzTUIxNDgyOzIzOm9JOWFua1NIcU1YOUF4RTZWSERzNXZJSUwy?= =?utf-8?B?SDNRdzAzSHNtYWM0cEpoQXplSVNEak9USG1sVm1aS0NYTStaV3BmNCtJem9t?= =?utf-8?B?WkxBaVQ2ZnNjOFZyUTlWZ1RCY0xKbG1laXQxVk5MNFVSMzEzcWtYR0U1L1Ev?= =?utf-8?B?UUJRZG1CSkg0cTNNVkZPUWlWWHJHcm8yd3ZmaTRjeStEck5nSk1LMnIrZ2Ft?= =?utf-8?B?WUw3OEtIb2pQUk9qREdsaXFkY21aMzBNU05iS2w5czdNd0xhTWxnSTBSMXN5?= =?utf-8?B?eHZ1Zmp1cWNPcDE1TmYrUzVmYTJzSTZ2N2xKTG5MWFk1TUhSUVo5ZVZ4cWd0?= =?utf-8?B?SmxyeHVTd0FNMlJIZDM4czFEc2JiWlNXVEtNcnkwcGZiRlVWWkFVWnJVOHdB?= =?utf-8?B?bnpRTGhwcldHRmVZbWUxYmhrZkxkeklvaThydWhDYXJ4cHMwVng0WTRSdHor?= =?utf-8?B?d1FKRlovbmVpajJxam5uWldqRmh0WW5uVUx3aHZnWGhoVE50L0tlZG5raTdv?= =?utf-8?B?aVZlMnF4b0o4WEZ4VGNmOWZ0S21aQjVzYmJ3SzVUMnJZVkx0V0tHY0xYODdj?= =?utf-8?B?SGQ0S1paSjRzNlRpemNaeXRYeHlwOHF6SUxCT2NoMmRwcHkrZllSNmU0VTM0?= =?utf-8?B?OTRFQWk3RnlpaHdMRU1LNTdFUGF6THRjbXljVEVwdU9ma3EzUnRVSUlkaDF5?= =?utf-8?B?cjFUTkFtNVdVU1NRNDdrS1VMNHJxemgzTmRqRWVVNnU0VVIzbWxaOE5OUjQx?= =?utf-8?B?Vnd4VGFkUHBOVmFGODhBNlVLTzFhVk9rQzg4Wlc5STFKZE1Nb2ZTS3FuaDRp?= =?utf-8?B?dzB0SENxMkl1cEw3MTc5d2hmM3N1K3FVbmtqeExucGVycnVyOEgyV25SWVl5?= =?utf-8?B?S01VTks1NEFOQzlaa3hwWm9aMmM3YkhUYUtHck16VTY2dFZQNjl0SWl3bVgz?= =?utf-8?B?QThTV2ptMFl6TnBEQlJXVTBnbzk5OGVJc0tVWEo3OHR5RUd4cUs2cmtueFpi?= =?utf-8?B?SHJ1dDlJeXJXYVdhQ0YyRG9rVnRzc2prUy9JK29CWTgvLzdzeWlwOTR3a0Rx?= =?utf-8?B?RHRpeWMvR2gyaHNSTG1YMXhiS3hGYm1qMGlydnc0aGZqcElXelhHZzBWc3Js?= =?utf-8?B?Z0hLSmNkRVk5VXlleVJ1U2FYT1Rmd2Q5Q2xTa0FwVFZMbjVKTXF5VTFKcWJ5?= =?utf-8?B?U1ZJWGplYXNXVW0wZVY3NTN6b1pvQXdod3RjT3BzRUozSVIyZEN5MWw0dlZB?= =?utf-8?B?L05zcWoyU3h3MkJiTVBwWmUrSmJvcmxrZkxDdzZFdkQxOFlZYzg0TU43Wm5F?= =?utf-8?B?VkE4T05WZzh5NHRRYnQ0RFA1aUJHY1M1NktodVdrNFd3WkdPVkQ2N0crQUxN?= =?utf-8?B?UVlPQWgxMmhKMzNna016T3pPZkNQRElrWllOQkZlMENPRzV1enFkdnJTdmUw?= =?utf-8?B?cGtZc2Z4dmVUWXkvQmd5ZDkyMUZTUElUUmpSc21INElWRDUxMDZRd0RKUHBH?= =?utf-8?B?Q0pQdz09?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;5:JVK9nbvNlEiGQ1JTMH3IG5DTj5f0USlUA6hy0oHqz6oeZ0L+86Lz375YZNSNfNKZ/+HWlUEtO0+a2qhHkrmW6vd1dqs1BvvgIvhCbe/2t72pzYLo93YV2AIUAyQ4duHp+N81U0PHzoRK+dHbhfUKkw==;24:RUombqdFoHnGFhW5M4J+sgDQ2Qo2/d4Uuz2mEJ97gAn1S1CrFcWKFK8w2KVY3Gf3cNd0lpegBEQqvrjgIxd5c9cctH1cCYv0c1FoJ1ZNjq8=;20:HsHqQUg3EFb+IP1pYs7wnY//HBYVuhewIhdmNeKhBGBkyzEAWSeveG3XkEJpEA9DbYP9ZsQvvJbw7Zq/vNmABg== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Oct 2015 19:13:35.1885 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1482 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-10-08 at 14:34 +0200, Christophe Leroy wrote: > Le 29/09/2015 01:39, Scott Wood a écrit : > > On Tue, Sep 22, 2015 at 06:50:38PM +0200, Christophe Leroy wrote: > > > Memory: 124428K/131072K available (3748K kernel code, 188K rwdata, > > > 648K rodata, 508K init, 290K bss, 6644K reserved) > > > Kernel virtual memory layout: > > > * 0xfffdf000..0xfffff000 : fixmap > > > * 0xfde00000..0xfe000000 : consistent mem > > > * 0xfddf6000..0xfde00000 : early ioremap > > > * 0xc9000000..0xfddf6000 : vmalloc & ioremap > > > SLUB: HWalign=16, Order=0-3, MinObjects=0, CPUs=1, Nodes=1 > > > > > > Mapping IMMR 1:1 is just wrong because it may overlap with another > > > area. On most mpc8xx boards it is OK because IMMR is set to > > > 0xff000000 but for instance on EP88xC board, IMMR is at 0xfa200000 > > > which overlaps with VM ioremap area > > > > > > This patch fixes the virtual address for remapping IMMR to 0xff000000, > > > regardless of the value of IMMR. > > > > > > The size of IMMR area is 256kbytes (CPM at offset 0, security engine > > > at offset 128) so 512kbytes is enough and allows to handle the EP88xC > > > case (which is not 8Mbytes but only 2Mbytes aligned) the same way. > > > > > > Signed-off-by: Christophe Leroy > > Instead of hardcoding 0xff000000, can you use asm/fixmap.h to allocate a > > virtual address at compile time? > > > > > Yes good idea, but in asm/fixmap.h FIX_XXXX constants are defined as enums. > Is there a way to use them in head_8xx.S ? asm-offsets -Scott