From: Oleksij Rempel <linux@rempel-privat.de>
To: linux-kernel@vger.kernel.org, marc.zyngier@arm.com,
jason@lakedaemon.net, tglx@linutronix.de
Cc: Oleksij Rempel <linux@rempel-privat.de>
Subject: [PATCH v7 1/3] ARM: irqchip: mxs: do panic if icoll_base == NULL
Date: Mon, 12 Oct 2015 21:15:30 +0200 [thread overview]
Message-ID: <1444677334-12242-2-git-send-email-linux@rempel-privat.de> (raw)
In-Reply-To: <1444677334-12242-1-git-send-email-linux@rempel-privat.de>
Current code will only WARN_ON() and dereference the NULL pointer.
In this case it is better to panic and stop execution.
Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
---
drivers/irqchip/irq-mxs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c
index 604df63..ce69860 100644
--- a/drivers/irqchip/irq-mxs.c
+++ b/drivers/irqchip/irq-mxs.c
@@ -97,7 +97,8 @@ static int __init icoll_of_init(struct device_node *np,
struct device_node *interrupt_parent)
{
icoll_base = of_iomap(np, 0);
- WARN_ON(!icoll_base);
+ if (!icoll_base)
+ panic("%s: unable to map resource", np->full_name);
/*
* Interrupt Collector reset, which initializes the priority
--
2.1.4
next prev parent reply other threads:[~2015-10-12 19:17 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 9:18 [PATCH v2 0/2] changelog Oleksij Rempel
2015-09-18 9:18 ` [PATCH v2 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel
2015-09-18 10:21 ` Thomas Gleixner
2015-09-18 9:18 ` [PATCH v2 2/2] ARM: irqchip: mxs: add Alpascale ASM9260 support Oleksij Rempel
2015-09-18 10:42 ` Possible Spam " Marc Zyngier
2015-09-19 5:53 ` Oleksij Rempel
2015-09-20 11:28 ` Marc Zyngier
2015-09-20 13:47 ` Oleksij Rempel
2015-09-21 9:06 ` Thomas Gleixner
2015-09-21 11:53 ` [PATCH v3 0/2] Add support for ASM9260 interrupt controller Oleksij Rempel
2015-09-21 11:53 ` [PATCH v3 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel
2015-09-21 11:53 ` [PATCH v3 2/2] ARM: irqchip: mxs: add Alphascale ASM9260 support Oleksij Rempel
2015-09-22 10:34 ` Thomas Gleixner
2015-09-23 16:20 ` [PATCH v4 0/2] Add support for ASM9260 interrupt controller Oleksij Rempel
2015-09-23 16:20 ` [PATCH v4 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel
2015-09-29 16:06 ` Thomas Gleixner
2015-10-05 19:00 ` [PATCH v5 0/2] Add support for ASM9260 interrupt controller Oleksij Rempel
2015-10-05 19:00 ` [PATCH v5 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel
2015-10-05 19:00 ` [PATCH v5 2/2] ARM: irqchip: mxs: add Alphascale ASM9260 support Oleksij Rempel
2015-10-09 14:11 ` Thomas Gleixner
2015-10-10 13:08 ` [PATCH v6 0/2] Add support for ASM9260 interrupt controller Oleksij Rempel
2015-10-10 13:08 ` [PATCH v6 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel
2015-10-11 17:58 ` Thomas Gleixner
2015-10-12 9:29 ` Oleksij Rempel
2015-10-12 9:32 ` Thomas Gleixner
2015-10-12 19:15 ` [PATCH v7 0/3] Add support for ASM9260 interrupt controller Oleksij Rempel
2015-10-12 19:15 ` Oleksij Rempel [this message]
2015-10-14 7:42 ` [tip:irq/core] irqchip/mxs: Panic if ioremap or domain creation fails tip-bot for Oleksij Rempel
2015-10-12 19:15 ` [PATCH v6 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel
2015-10-12 19:15 ` [PATCH v6 2/2] ARM: irqchip: mxs: add Alphascale ASM9260 support Oleksij Rempel
2015-10-12 19:15 ` [PATCH v7 2/3] ARM: irqchip: mxs: prepare driver for HW with different offsets Oleksij Rempel
2015-10-14 7:42 ` [tip:irq/core] irqchip/mxs: Prepare driver for hardware " tip-bot for Oleksij Rempel
2015-10-12 19:15 ` [PATCH v7 3/3] ARM: irqchip: mxs: add Alphascale ASM9260 support Oleksij Rempel
2015-10-14 7:43 ` [tip:irq/core] irqchip/mxs: Add " tip-bot for Oleksij Rempel
2015-10-10 13:08 ` [PATCH v6 2/2] ARM: irqchip: mxs: add " Oleksij Rempel
2015-09-23 16:20 ` [PATCH v4 " Oleksij Rempel
2015-09-18 9:48 ` [PATCH v2 2/2] ARM: irqchip: mxs: add Alpascale " Oleksij Rempel
2015-09-18 10:16 ` [PATCH v2 0/2] changelog Marc Zyngier
2015-09-18 10:19 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444677334-12242-2-git-send-email-linux@rempel-privat.de \
--to=linux@rempel-privat.de \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).