From: Sudeep Dutt <sudeep.dutt@intel.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Sudeep Dutt <sudeep.dutt@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: mic: fix memory leak
Date: Tue, 13 Oct 2015 10:25:20 -0700 [thread overview]
Message-ID: <1444757120.93285.268.camel@localhost> (raw)
In-Reply-To: <20151013171559.GA6720@sudip-pc>
On Tue, 2015-10-13 at 22:46 +0530, Sudip Mukherjee wrote:
> On Tue, Oct 13, 2015 at 09:34:21AM -0700, Sudeep Dutt wrote:
> > On Tue, 2015-10-13 at 14:38 +0530, Sudip Mukherjee wrote:
> <snip>
> > > + struct scif_hw_dev *sdev = scifdev->sdev;
> > > +
> > > + dma_unmap_sg(&sdev->dev, p2p->ppi_sg[SCIF_PPI_MMIO],
> > > + p2p->sg_nentries[SCIF_PPI_MMIO], DMA_BIDIRECTIONAL);
> >
> > Hi Sudip,
> >
> > You missed unmapping the aperture here:
> >
> > dma_unmap_sg(&sdev->dev, p2p->ppi_sg[SCIF_PPI_APER],
> > p2p->sg_nentries[SCIF_PPI_APER], DMA_BIDIRECTIONAL);
> >
> > Can you please resubmit this patch with the change above?
>
> Hi Sudeep,
> v3 sent for your review.
> >
> > Also you should mention [PATCH char-misc-next] in the next revision.
>
> Ohhh... yes, I keep forgetting that Fengguang will need this tag for
> his build bot.
>
> But I have one more doubt. If scif_nodeqp_send() fails then shouldn't we
> remove these two nodes of the p2p connection from the lists and release
> the resources?
The resources will get cleaned up via scif_destroy_p2p(..) once they are
added to the lists.
Sudeep Dutt
prev parent reply other threads:[~2015-10-13 17:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 9:08 [PATCH] misc: mic: fix memory leak Sudip Mukherjee
2015-10-13 9:50 ` kbuild test robot
2015-10-13 10:23 ` Sudip Mukherjee
2015-10-13 9:50 ` [RFC PATCH] misc: mic: scif_deinit_p2p_info() can be static kbuild test robot
2015-10-13 16:34 ` [PATCH] misc: mic: fix memory leak Sudeep Dutt
2015-10-13 17:16 ` Sudip Mukherjee
2015-10-13 17:25 ` Sudeep Dutt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444757120.93285.268.camel@localhost \
--to=sudeep.dutt@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).