From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752776AbbJNJFL (ORCPT ); Wed, 14 Oct 2015 05:05:11 -0400 Received: from lists.s-osg.org ([54.187.51.154]:52657 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751853AbbJNJFF (ORCPT ); Wed, 14 Oct 2015 05:05:05 -0400 From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Fengguang Wu , Luis de Bethencourt , Javier Martinez Canillas , Michael Ellerman , Jeremy Kerr , Brian Norris , linux-mtd@lists.infradead.org, David Woodhouse , Neelesh Gupta , Cyril Bur Subject: [PATCH] mtd: Make MTD_BCM47XXSFLASH to depend on MIPS Date: Wed, 14 Oct 2015 11:04:54 +0200 Message-Id: <1444813494-14985-1-git-send-email-javier@osg.samsung.com> X-Mailer: git-send-email 2.4.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The bcm47xxsflash driver uses the KSEG0ADDR() function to map an address to a certain kernel segment. But that is only defined if the MIPS config symbol is enabled. The driver does not have an explicit dependency on it and relies on a transitive dependency relation: MTD_BCM47XXSFLASH -> BCMA_SFLASH -> BCMA_DRIVER_MIPS -> BCMA && MIPS But BCMA_SFLASH and BCMA_DRIVER_MIPS have only runtime and not buildtime dependency with MIPS so can be changed to be built test using the config COMPILE_TEST symbol. But that would make MTD_BCM47XXSFLASH be built with MIPS not enabled and cause the following build error: drivers/mtd/devices//bcm47xxsflash.c: In function 'bcm47xxsflash_read': drivers/mtd/devices//bcm47xxsflash.c:112:2: error: implicit declaration of function 'KSEG0ADDR' [-Werror=implicit-function-declaration] memcpy_fromio(buf, (void __iomem *)KSEG0ADDR(b47s->window + from), ^ Make MTD_BCM47XXSFLASH depend on MIPS since has a buildtime dependency. Reported-by: Fengguang Wu Signed-off-by: Javier Martinez Canillas --- drivers/mtd/devices/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig index f73c41697a00..f5eab3c19356 100644 --- a/drivers/mtd/devices/Kconfig +++ b/drivers/mtd/devices/Kconfig @@ -114,7 +114,7 @@ config MTD_SST25L config MTD_BCM47XXSFLASH tristate "R/O support for serial flash on BCMA bus" - depends on BCMA_SFLASH + depends on BCMA_SFLASH && MIPS help BCMA bus can have various flash memories attached, they are registered by bcma as platform devices. This enables driver for -- 2.4.3