From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752211AbbJWDLe (ORCPT ); Thu, 22 Oct 2015 23:11:34 -0400 Received: from mail-bl2on0139.outbound.protection.outlook.com ([65.55.169.139]:28928 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751635AbbJWDLc (ORCPT ); Thu, 22 Oct 2015 23:11:32 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1445569881.701.143.camel@freescale.com> Subject: Re: [PATCH v12 5/6] QE: use subsys_initcall to init qe From: Scott Wood To: Zhao Qiang CC: , , , , , , Date: Thu, 22 Oct 2015 22:11:21 -0500 In-Reply-To: <1444806968-4627-5-git-send-email-qiang.zhao@freescale.com> References: <1444806968-4627-1-git-send-email-qiang.zhao@freescale.com> <1444806968-4627-5-git-send-email-qiang.zhao@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [50.157.106.250] X-ClientProxiedBy: CY1PR0801CA0023.namprd08.prod.outlook.com (25.163.136.161) To BN3PR03MB1479.namprd03.prod.outlook.com (25.163.35.142) X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1479;2:ikjG2JrfyYba6kqbXOdfB6kvXkk1ujzVosTEhHQofwn2GBcOOJpNz9U21x2vXqXkJfrN7TBLnu/5Y7v6Kn0Mo9WruZriVITtKb27f6OpVVMoq+s7N6bE2gKpWF0hCluZ55jkRfJgv+KfmCBy9nO1dOJ+lnMoC6v1hG6X4FU6EzU=;3:LGQ+/vSQttm+bgNbKRovdcCR3pFQONey3kvg1R5aJUoaF/wdqbGNqjN6Wvt7b9BZ68+ehQN19X+82xbgVJya2ERJhCcTccry+FHR78hR+NdSo6A3n60YV526pmYONG6ra5mWXNSwF9d8BxD4CjVjZw==;25:34ldGKWsPjgSIy1hlGVRT2NXvu1nOmliFD0crKwGuUP0nTsKubw4riXnr6/4wyydBH09iGM6/XuQbcFm0kCDUvp2ybbm252MAfbctxdCu/uVlrRigYL9MK1t0Nd3d4esCzYrmio9jb/jbJuTBpP2EZTV0fpUWr2sQfspqwVEreoruRA8tXuymZB7Pts2GkKKeJfKRAYXFgDaUl0BsW4vI0Jm32zAoDq4Z1sK6McT1Fg6AfQZ/tOKYs4/FhENELyy1kAnb1I2MYo9yjfNd6rxHQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1479; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1479;20:DWw89ZzQQpYB+lasmhpfV+7Y6uS95Vfy9BUIpMzCRHlD0UI9JiyR5jjenggNlNHePxBy8l6S5TPj4qC9QZcsj1NCRqt350fEbFSh4Fyq6tX1AWqCOyT6J1NNr8dG2QDtvnopOgGlmzeJ7caRQuUNBGJMP0xJDlzZSmhIIANInJQn69i3zqZkfRNd9Ou50dZrWj7lwPj474MmEVfrT37QCm6HoE0Wo92j2h9os7hjieuaDMKufCn+yCkNw9WfxHMEBMl43y+NRFveM4GVrtEihVd9ku/9qzZd4VXKbIZKWVyR82glW54ctQIFj7v3g/mLT/TRVzaEBy+0hN/6dUZDc2WUwQEa2DJbHB4VRGT+FJCp6GebayN4PtMno/h6BybhNvxKIACOCFEUXwKWO932RLP4MGyro20tyQq2HJFjfaz0aA2cbC1yol1GCe5q769EQbMhBR4t/MuLp+ylqeK/8OEAFDzC3Ekc2xbd34KhO0eEYQhrCqDeylmUxtEvLFaU;4:f/eLdzQ0jYt8HlE1XODLFo8jQFeI3QkrGeN38nOq8k09yMao+A7mi7WKTd2VSE304M5rLAmUMQFmg4Db5Sw4tHfA/CWGFqQJdkppFQcIiEmV1T9pmU9l6HaKp4OeAvs0wjAnhueeBOfff5opA6/0x1/0Ok6exQgoKRIAXNmRkvwpdh/VYG64BdAzLACprvNGvYSMoqiDX1BrAno5aigPng+20vztEBcKTNqzsAcAcM2lry4IlK5s6eq3PBCy1KTa010pVfzG+TS43oFqOp7DYrmQifn7uVtF2FJy/u8Bv4E5JV1hJkTQIHbmtI70EFdeAGG+tJxJKmi1QrjIxogqceYi8AAXbQLqIL5MM4V/xMBW8mv+SE4KcQR61ixI6NIP X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001)(102215026);SRVR:BN3PR03MB1479;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1479; X-Forefront-PRVS: 0738AF4208 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(199003)(377424004)(24454002)(189002)(4001450100002)(86362001)(5001960100002)(106356001)(110136002)(189998001)(105586002)(92566002)(36756003)(77096005)(122386002)(5820100001)(40100003)(2950100001)(5007970100001)(66066001)(47776003)(5001920100001)(81156007)(101416001)(97736004)(87976001)(5004730100002)(4001150100001)(33646002)(5008740100001)(76176999)(50226001)(50466002)(103116003)(42186005)(23676002)(50986999)(99106002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR03MB1479;H:snotra.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjAzTUIxNDc5OzIzOit0eXpvYnlpVU5BcU1HUDlSZjZISG4zUEQy?= =?utf-8?B?YlFhbkNOVlR4bGxjQTJETHB2ditwQzVNYm8wVHFZaEFyS09PVUpQakN3c2FD?= =?utf-8?B?RzBnUE1yZnV5ZTJhMnhHa2JVazhZS1EzQ1NZdlI3VTEreDMvQWxVWFJsejla?= =?utf-8?B?NEpoeThiN0FRTHNoczFvaXA5VFJUclhMTmJZbVkzT1pLcWZyd0pTQ0ZHSEli?= =?utf-8?B?TG1ONktlRGhLQ0RlVVVkUTRTZklrWjBrVmJWNW9KNS9ZUVZoT0ZjNm9NTXFJ?= =?utf-8?B?cGZUbTN6aHVoSkw3UEtPSXZrL240ZjF3dUFRZjNRTHVKZWRRMU1PZGVZbmQx?= =?utf-8?B?aTRhaEFrcHFvODY0NTZNYTB5a3V0UmlTcURadnluQlYybFg3bkt6NzZCbW5Y?= =?utf-8?B?VUhMQ3FpSUNoOVB3TU41bFZLM2pKeE1zem0rMy80dTFlR1NaYU5OVlRRaW43?= =?utf-8?B?b0dlWERubTF1NE9IYncwai9saXl3cU95NzVWQXBHaWdhbWN0ZXo1b2p1bVQz?= =?utf-8?B?YW1yRmszOGgvZ283WkR4WkF0dlRNY2VXTXd3RHBHbUZ2WW5QcFhuNlJ6N0hI?= =?utf-8?B?bXdpZG95dFVTV09EUkZ3anJ0QU5leWtzR2ZHMGQwWUI0Zk5Tb2pzYlU2UC8y?= =?utf-8?B?N200d0VOWkRUbEFoN1Y5MnFpVlp2UTI4VTJVTzNUT3NqZ1RBNHhUYm1KbFVQ?= =?utf-8?B?NVpISDRBSXBoYUg5b0laZEdQUCtQaDJiTEFDQ1MvM1Z5R1lHcld4YlBwZ29F?= =?utf-8?B?UHpBWkYxZHkvTW16SU9WbVR4a2tsNDkrZzFSSGlRY3ltazBYNUcvUFpRT1RH?= =?utf-8?B?M3luNVE5M0JPM0x1UHUxZVR5R3Q0Ti9WN2VWSWtUY2p2Ykp2VFZneHdSVjI3?= =?utf-8?B?WGphR2lpdnZMbjFCTXFaVS9ZS3poYldLWUtEU0hRM3BzeFQzNHNnN00xeExI?= =?utf-8?B?bHlOdVBTWFZjUWRjdUZWbjNoMktyemVaZ2R3c25lYTVDVk9QU0d3ay9OdkJu?= =?utf-8?B?bHRKZ3J1czBKOHlQT29oNldLb1Y2YU9CRXJCdmN1UWN1Q0RFNFZvS3pzYzB6?= =?utf-8?B?Q1J4WVVzcXNWempmY3pQSXBDaXNWYll3QTc3SCsvQlNxTEhBQ1RTVk10NDVC?= =?utf-8?B?dDNxVk5iN05pd3JkMHBndFpOREMrQ3MrZ3A2d1dLNENiOURwTXBSMUoyUDF2?= =?utf-8?B?eTV0YWFnby81N3UzcVpHN2lBQzhCNkI1SmpaUkxYdDhIRksyaHFGSS9lUmpP?= =?utf-8?B?ejlBWnRnekRtUk9uRjlRa1o4WTNwb0dna1drdS96ckNyaGVNRFZMRC9Zb0U2?= =?utf-8?B?TFpOS0c1MGZHb1Y1NnNyYWtSYTV4NmgwcVRocjl0eVdWUit0TjltMytkZmhU?= =?utf-8?B?RjR1WlR6ZzZNeGhna1R6UmlwM2I1VDcvQjdPUWtFTW1NdHZ0K1VuZVduNUdP?= =?utf-8?Q?QygUlK0Nnix4Zbm4gyX90YbuLJJ?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1479;5:WxdGaZGFTKrVAJXIgNYyIH1u31r4PzKCrsj+X17ckGnk/1v/8iVQ0HI7QQIV7ellccYeCdDGjtDi+TyWs8Qb76//HPDJmMYF0p62ZHQuWTi0aGQbauiabA3WL8zBXiq5pjpRe3WWjrPd4ZOAV3b40Q==;24:agFp2e686XWlZOnJ6oVeN64adAEaaQXiy8nC0sN15OEpkZ7wjGaFdgx8YSOxK+J0WQ40oHn7qSN9EOe/WDrqsXhtqgSlTnveVG/7Gnzx7Po=;20:15afEu/BdT3ZLqxAEXcooPo5rU7jeTvWWWqsPjMkmaXmukORmBaxUjn7aJ33vv/cOY8o+hGNHN8kVES3R4K12w== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2015 03:11:29.8111 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1479 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-10-14 at 15:16 +0800, Zhao Qiang wrote: > diff --git a/arch/powerpc/sysdev/qe_lib/qe.c > b/arch/powerpc/sysdev/qe_lib/qe.c > index c2518cd..3f9f596 100644 > --- a/arch/powerpc/sysdev/qe_lib/qe.c > +++ b/arch/powerpc/sysdev/qe_lib/qe.c > @@ -671,6 +671,21 @@ unsigned int qe_get_num_of_snums(void) > } > EXPORT_SYMBOL(qe_get_num_of_snums); > > +static int __init qe_init(void) > +{ > + struct device_node *np; > + > + np = of_find_compatible_node(NULL, NULL, "fsl,qe"); > + if (!np) { > + pr_err("%s: Could not find Quicc Engine node\n", __func__); > + return -ENODEV; > + } > + qe_reset(); > + of_node_put(np); > + return 0; > +} > +subsys_initcall(qe_init); Do not print an error, just because QE is not present. -Scott