From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752753AbbJWU4I (ORCPT ); Fri, 23 Oct 2015 16:56:08 -0400 Received: from mail-bn1bon0112.outbound.protection.outlook.com ([157.56.111.112]:51968 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752633AbbJWU4B (ORCPT ); Fri, 23 Oct 2015 16:56:01 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1445633739.701.227.camel@freescale.com> Subject: Re: [PATCH v12 6/6] QE: Move QE from arch/powerpc to drivers/soc From: Scott Wood To: Zhao Qiang-B45475 CC: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "lauraa@codeaurora.org" , Xie Xiaobo-R63061 , "benh@kernel.crashing.org" , Li Yang-Leo-R58472 , "paulus@samba.org" Date: Fri, 23 Oct 2015 15:55:39 -0500 In-Reply-To: References: <1444806968-4627-1-git-send-email-qiang.zhao@freescale.com> <1444806968-4627-6-git-send-email-qiang.zhao@freescale.com> <20151023031952.GA31843@home.buserror.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [192.88.168.50] X-ClientProxiedBy: BLUPR0401CA0028.namprd04.prod.outlook.com (25.162.114.166) To BLUPR03MB1474.namprd03.prod.outlook.com (25.163.81.16) X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1474;2:NRt+WnD+b9xEJSKDINZoGDuS9d4jFwtFgJsMOxXq02s99a4VWxN8SXZoqMUJh4WDvUmpVQWfxtcXRiu4IzodM+AV2tTJc3EvSH6SA71ZY7m246OFcQPQuc0JG2TpgG4CStsuf1Jsz/9J6odKe9rbVkooBqUJj3IHjrMHphKjalg=;3:7FNm08t9ntsWFndrY2k2rnDVxLe7C91AGQnoBi35w4oqMVLhRP6COO0Fy7yfc0PYmCoCx6LgzngKCfB+vYbv/gjJvl0ioS6Dng/GwZ0y5isdgj883mLKS8EfonG74ywCBS3i/JmdnhQFgWqp4Om3wg==;25:Prjvbm7xbw7zgouuSQcqpYcQqDOgdi5URhxyMSs9zCpsSkNm0QdSG7XCJHMu+lSFYFvt3PVXRIj69USdIbafDPzQhRmfF9ls0xGc0ju1KbU8Yc+HWqdJ7OmJKqiI9k4L4T3xMr9eraFTW2487ryRqSBJu6Tx06ggNi0W92J6co3lz6iHMXlNtTZ3D+N1QrqIB6Vex6MU2hibwi+Dfpqzy16gIfEhm9ApxErzMvN0lIbEFabD7kYciqONmU3rVGOkkC3yhU/wr7xLLz2rVMHyJg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1474; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1474;20:BPqjqJxIRQXzKPR74ZKGruGBCQTU+PNqvdd7gMD1Ugl+ED2cNLFekQwwduVtAc5OXL71Ycgu0OSCYZvjs8uhpxLF++Yy9YicKJ8jfa7VpK8AxY6NxCaKdISyFQRBnM3LOQxHdBHqMFjJB2SAinRwA+E3IKREh7t1M6V3sLZWQpvmf8suuM+RHaLKDbk6eqvvWzx+L7fvvtmrIm5IhnCtCMX8fZWAAVssF/iLUUjTbXKpPlf5pPn30xtF46ejhGfVvuUXY5yz+Xv/2K0HdLv4fAqLq3NI7oOn9ZNp9xUMSBqK0MUo95E2e4vUHvqFJWKqpDKvWrhZIH1Cm1tyGIbWEfLBj26/B8qM/tCoOV0wKXuo7RK9BLMwBTyFbBajE0dnodIi2A8jOTSesy21obJ4kkcULtvj2mp9s/Ze3kTljd93uvcziUI79sGGg2e+qbjaihEqdefHEwlYO6Jy5XEbtipPZKidGFuqdxkBzQuGlulYmvVBtw47o28By/HXEV91yEaEhZ6JnSrmDZ4jt2Idh7jUNLepeC4txIdttPBag6VIHtCgReG3cc0lmvFBdjUbADi4smc6VekyJynLWKXcLh7cBZ6jQsKN57/H0zrGGeI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(3002001)(102215026);SRVR:BLUPR03MB1474;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1474; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1474;4:hWYlsQvAlEQrz7bpxt9m9oFSBmg/Y9TJNWuPuFubXdftRmK8iaBJC/6d/EsDrOTFZ7iZJxUJ5lmxkC9R8wM/7uiYVMeI/Rpgql9Zj+I8qFeWNoUEy7DpGbhrA8O6+DZbKDYUln9iMHLXSVkPT/ttykItjA0HtFmayb+Nn4xNwyFVQ/oL0xAXMJRbZBPwzSw1ix/50YEegk5+h+TDc+W5oNaM3uwYVxykWTBoKYa9neHGPPpfpO7404eYKNjelNCoZj0yYp07HOGRxbyG/kixzYN9cTifSI8kmyrTO4TmGIqXZVv93QtyixYXE7AZPa7NHLGyve2et7z2IS81bTDYlZMC4098WPtS36VCtYoiMsKGQsYG+dopWslPjJAzVCY0 X-Forefront-PRVS: 0738AF4208 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(6049001)(24454002)(377454003)(377424004)(199003)(13464003)(189002)(122386002)(92566002)(4001450100002)(93886004)(40100003)(50226001)(5820100001)(5004730100002)(5007970100001)(5008740100001)(106356001)(47776003)(66066001)(36756003)(4001150100001)(50466002)(2950100001)(33646002)(81156007)(19580405001)(19580395003)(77096005)(42186005)(101416001)(97736004)(23676002)(105586002)(87976001)(110136002)(86362001)(76176999)(189998001)(5001960100002)(575784001)(103116003)(50986999)(99106002);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR03MB1474;H:[10.214.82.141];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjAzTUIxNDc0OzIzOldWVkNoY1Rjbk1UdHJRVDk3ZWJCM0gyYkI3?= =?utf-8?B?UVpyMTVybkFmOWY2WjdsWmVySVJJU2ZCMXUyT3JNV2F5ZkMxbWNXb2xiVmxZ?= =?utf-8?B?b2k5MW9WbXRseTgxZWF2VHhiWU5rNFAwbXpRQUYrS2x0b3JuVHNRK3g3N0dl?= =?utf-8?B?VmdxcnRUbk42bEpxMjNSem1vS0Q3Nm9CNTJncTJpVFREbVlIMXFrcSsyVW9n?= =?utf-8?B?UEVxUVB6N2xubjErVHBiMnVVZWZ1RnBmZTV0b1FKWnd0eFpLZnRlNCtjSysy?= =?utf-8?B?R3FQcExqM09hbnU3KzhDakdtOEJwWjNWWVlzaTdHNnVsNXJBRnlYU2laUXpR?= =?utf-8?B?RWxQMEZHeEs5MHpFemxacDh2bTZKS2lqbzJ4SVdndVp5MEF3T1F4QVhNL2ox?= =?utf-8?B?eERnTkZPTU91YXFFMU5adms3NGZTVmVZZk1zOHVZQXY3WXpnUTdvSDZvbWY3?= =?utf-8?B?RWNJd1JQd25xV2I0czhScmc2QmNzQTNJdU5DVUsxeWVrRHROQXFxN1JHOTZK?= =?utf-8?B?YUxGWkJoamJwMWppRXVzTEsra0Jwamt2cGM0NXdkRVE2bVBQQmZSQ3VFd0Fl?= =?utf-8?B?aGNJd1NPancrQ3REYVhMaitFcEJVVmprSUw5NHA2MGpYb3FEZm93aGFVempX?= =?utf-8?B?d3V0Z2dWbVhOLytWQ1VmWnpjTHB5bnBBNnNZRG0xYzdUK3J5NFowNWpyeWFH?= =?utf-8?B?UUQ2NUlSeUhEd1cxVS9RQ1NpSS9HcW4rQW50VXpQR3FlVGNQNVIvamZCZXZB?= =?utf-8?B?eExiZThwNWxDRWh0KzloY2tBekgyeTFFSysvdEtPSFBDd3hVYU9PYzZlUHFI?= =?utf-8?B?cmhYMWxZbUx2MFBwWXNYVmkzNU8zMnRGOGNVdkhSYUhxWDQrYkxpM1pYRlc0?= =?utf-8?B?Y2VneGRGVEVWZHpZQW5oeU05V1Nkd2dtTGl2aVl6Z2lHR1BwNzA3UVRPWGRL?= =?utf-8?B?SXk2U05LQ0ZMYjc2dXpIT2VOa0RJNnZqdkRtRzU2UitwaWkzMVVJQkV3bCtL?= =?utf-8?B?RHdOQStwVldVZlJuUEcwZDgweFk5ajMvYkxpTDNGRk9QVjRTbUVYdWgrTVRD?= =?utf-8?B?RDFDVHcwY1BwK2kxTEN5dTlMV2R5TW5nc2QrTG8xWVBHWlZ5dCtFeDY3Qy8z?= =?utf-8?B?clpWYVI1bUlxS2p0Nkgzck54bFFkbjBYQlRpNitCTlQvK0FmbWprekZROENP?= =?utf-8?B?TXM0RGt3WEF6dVNwVTFiSVl4TFNxZGZUenp2Sm83YWVLQXUrdW5NVG5FRDd2?= =?utf-8?B?WFVWWlEyV1VmUUtrOHJOZGR5RHpYSEU3OVVQc216dGw4ZzViQTJaL1RDTzNh?= =?utf-8?B?bk9SKzNpUkVmbDlKNFk0UndxblpWektCc0dtcjZUZWNjL1h3TFJXR0pIQkZI?= =?utf-8?B?TklxWS9RMFpTdnJmaERtSEtjODJ6YjFGWm55ZGxUUE1udlFxeVJzaFdyVHRE?= =?utf-8?B?MHVRcFJBcERUVjBBUjI4OTJIbHp4YmhjSDBDbWxQbGdFOVZLTFNYYXpjZEw4?= =?utf-8?B?MzgxL0NsWWhLZ0FrNCtlMDY1Y0VrekxIYVlaaHhKVFh5cnpDUVpCMUtscm1y?= =?utf-8?B?bTRYMjJSZHdCVkZzS2d3dVpLbFd1SXNmeXJxUHc1a0tSODlPMkRFekJSZVo3?= =?utf-8?Q?c8qp/NlZtOcl8ggM5Mgc?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB1474;5:txCvECDVa/obyD92W5SNgXFQ5d9N2UvokJ8EiXeHGBso9bE91v6LREucYBCxRcDWIr50kARawrtoXDssgfsfCnYUqFUM9PBohbOltxoE/b0qPYLXE0keO43idsTj9s4/80YWttBq7p7f/hhJEQ3vbQ==;24:+bElY0ItIeRJz9/mDGbMFrk+1JvgFY22hDe304Oe5n1NiyWoitigN4h8ayPCzdeU0kw37yFZG0ZlNb1YWNGvCzvCJmrLW1+UPrMhz7aHl+0=;20:XXo97fwe3PtPF3liNFwDyVZ3B1i19ovMZGNDXpfsm4jn5QYsXAxYh7vz4Ce2nzJMDPto7TzOarMTih3tt5PLPQ== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2015 20:55:58.1026 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1474 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-10-23 at 02:49 -0500, Zhao Qiang-B45475 wrote: > On Fri, Oct 23, 2015 at 11:20 AM, Wood Scott-B07421 > wrote: > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Friday, October 23, 2015 11:20 AM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > benh@kernel.crashing.org; Li Yang-Leo-R58472 ; > > paulus@samba.org > > Subject: Re: [PATCH v12 6/6] QE: Move QE from arch/powerpc to drivers/soc > > > > On Wed, Oct 14, 2015 at 03:16:08PM +0800, Zhao Qiang wrote: > > > > > > > diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig > > > b/drivers/soc/fsl/qe/Kconfig similarity index 50% copy from > > > arch/powerpc/sysdev/qe_lib/Kconfig > > > copy to drivers/soc/fsl/qe/Kconfig > > > index 3c25199..283fe0d 100644 > > > --- a/arch/powerpc/sysdev/qe_lib/Kconfig > > > +++ b/drivers/soc/fsl/qe/Kconfig > > > @@ -2,6 +2,17 @@ > > > # QE Communication options > > > # > > > > > > +config QUICC_ENGINE > > > + bool "Freescale QUICC Engine (QE) Support" > > > + depends on FSL_SOC && PPC32 > > > + select GENERIC_ALLOCATOR > > > + select CRC32 > > > + help > > > + The QUICC Engine (QE) is a new generation of communications > > > + coprocessors on Freescale embedded CPUs (akin to CPM in older > > chips). > > > + Selecting this option means that you wish to build a kernel > > > + for a machine with a QE coprocessor. > > > + > > > config UCC_SLOW > > > bool > > > default y if SERIAL_QE > > > @@ -19,9 +30,3 @@ config UCC_FAST > > > config UCC > > > bool > > > default y if UCC_FAST || UCC_SLOW > > > - > > > -config QE_USB > > > - bool > > > - default y if USB_FSL_QE > > > - help > > > - QE USB Controller support > > > > Why did some config symbols get moved and others not? > > Because QE_USB should be putted under drivers/usb, > It is independent of this patchset. If it's independent of this patchset then don't put it in this patchset. Move all the QE stuff to drivers/soc and then later if something belongs somewhere else, have a separate patch move it there. -Scott