From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752115AbbJ0EsY (ORCPT ); Tue, 27 Oct 2015 00:48:24 -0400 Received: from mail-bl2on0114.outbound.protection.outlook.com ([65.55.169.114]:51605 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750891AbbJ0EsW (ORCPT ); Tue, 27 Oct 2015 00:48:22 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1445921289.701.301.camel@freescale.com> Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to qe_common From: Scott Wood To: Zhao Qiang-B45475 CC: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "lauraa@codeaurora.org" , Xie Xiaobo-R63061 , "benh@kernel.crashing.org" , Li Yang-Leo-R58472 , "paulus@samba.org" Date: Mon, 26 Oct 2015 23:48:09 -0500 In-Reply-To: References: <1444806968-4627-1-git-send-email-qiang.zhao@freescale.com> <1444806968-4627-4-git-send-email-qiang.zhao@freescale.com> <1445569799.701.142.camel@freescale.com> <1445633780.701.228.camel@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [50.157.106.250] X-ClientProxiedBy: DM2PR0801CA0018.namprd08.prod.outlook.com (25.162.18.28) To BY1PR03MB1482.namprd03.prod.outlook.com (25.162.210.140) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;2:OYT4xw3WHN86GddIGYghnFNMg0O/ykqfFZkRH29hSuKNtA5oyBu8cCQ5y+3tEa0aH7Grw52PifTAuiL1x4XBznJl3g9ZDTeJMdm6GjQh2KE+NogCW8IJDfx1LE8OoR4RQYJidzhdmtHb54xbwK3/txACaw6D4yQftQjEMMuweEY=;3:5l2jfDC2h2Th7oX32elz/rFUH4jcAvQ6uyl/h+3eJKvXuvoyDF6M4QSy7lcdoUgFx6Osbx9c+thnywY+A0rIQ84annqR5pOO1JsdzAP4cs2fcDdYFCekPRCzrhrJE5jrJwcozpTCNvTBaBdeYF7xmA==;25:1eN+HDuVQBR0D58eQ/7DRm7imbjbUlGdMZ+h8+N+qykv9X1BFdDlOdf0OFBUwE/xsMi4LXHirrAI2CkR74i0oTTaRZOS6bbMJicw+Nq4QroHpzjwtDAtLJ1tcEr/6nD6Jvjz+9AXyPnL9pwpjEQu5OGerun1eJfIWh4qokb9HqkrCO6K7RxuyIoXtXDsdqdeL/34JFI7AthHkawysZdMLu8q6AA2pS6oOpMxldHv9Zt9JZ8wd/DkiryyBEl/fI60tTukR25vI9GxpABFFsfs1g== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;20:WVqyFSdKtqh9+/IbP504TParU4Ng6WDhyYbpJkuTXOA7oRHscIulxX4KbH/AlMacqOl+wUrZOSMlnWflxEBLlgqQbEbjUV7x60437e1qrmUrQzKNl3UUyb9GNMPAsyxGnw2cmgi98WscTIgI2CBb6m5GKSwQ0HoYAGje37xOZPloRIPPdRLGm17iYep69/KQIIxnxS8wrKKawyLEU1AU9NThbk6jQi/OcRReg/6qDAKWwOI8LI2vGlryfc/e/GtM04+kZNaDk3dCeZm3eBRVW4yIsguQtESG1muTS9qE4r5PvW5UyzVqeO9yPSwJvsXMBhQHShE942NVWtTjxK4M2Oc2ihBsJAi9ld5OEkgArghPPJqVt5WbKCZwTRjYGn1aRrhHs6DvLdLHz0oSZTLWd7478zYWeGz5Y1RDNbRHqHW4XOt2ulCFWHgaaqm+t2BkkDrvyqNEZ7xrU5P/qr2G2sRzn0emWwHxjX3NEBLk+UhPOPmI8v4XZI2XvfV6Ctg2;4:zTOTELVGn/3af5WRIPQtfWr0KQOvn3NkIUKHxFhYJy0WttYMfhbBhwS8D0oJmFRq8z6gc7AyLgfPf/p13Qi2L2wq3x4OtI/jhKlW5exi4QM/E8PZnTOMe2wQ3LLs9UdFNm8YvYrbjkY6OxdqG1ioKE3laqju+dj6nN6SXYuZfFHhqSBkJ7jOn2mvNN6G8c28tB9ANy13kjGpY6C8JjvwVz0Epzee9mI2l6UXQPb0byFRSrYnMgn7PM9u+AV78hnatbO8uhl3xjLWVchtFw3r1T4q32Z7+MAKcNHCLnBnfRCGVhgNBCkJSZAKhuGpGKVBHbyx0OyKYAA3PInu+XiDBsrBwXTpcxrGReFl0jtgyCJqBB4mOuPe1UVsJ58IehIh X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001)(102215026);SRVR:BY1PR03MB1482;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; X-Forefront-PRVS: 0742443479 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(54534003)(13464003)(199003)(377424004)(189002)(24454002)(377454003)(4001150100001)(81156007)(77096005)(5007970100001)(110136002)(42186005)(5008740100001)(40100003)(97736004)(2950100001)(189998001)(86362001)(87976001)(101416001)(5001960100002)(122386002)(76176999)(4001450100002)(50986999)(50466002)(47776003)(105586002)(19580405001)(93886004)(66066001)(5004730100002)(19580395003)(36756003)(103116003)(33646002)(23676002)(50226001)(106356001)(92566002)(5820100001)(99106002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1482;H:snotra.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjAzTUIxNDgyOzIzOm5WOWw4VlpMSlFudENjOVdCc1BURGNYYTJ2?= =?utf-8?B?WDdEZDlyL2Z3UnB5MEFJSnp3Zm1MK2ZFblMyTFRKU080di9oUHhZV2xBcUhT?= =?utf-8?B?V2s5NjcrcnNYQ2lnSHZsakpyU2cwTTZ0NDgyOVMwSDNWR2dsNS9jTmJzL1VB?= =?utf-8?B?WTF3VlFNRlJpTE5zeFhCTFR3SHR4bUkzSjkwTXEzWVdUd0h6bWk5UFFTR2g1?= =?utf-8?B?b2FEUlBMRjg5MFRhWEtTc3VmR0lrOUo3SStiWmIvY1R5clU1TTIzNEpzTkVQ?= =?utf-8?B?ODBBS3lMMDNQaXQzK2FPTWJQb0t6bzM4N21BV3NXbCtseVVwNFk1RU9sOUNZ?= =?utf-8?B?ak13Z2YxdklUbURnc1dtYW1sc3kxb3gwWVQzSmpOVi9KWmhIblhKOXltb3h0?= =?utf-8?B?K0tlT0xtWjcyTWtSaTVXb0dHd1pMMSsreFRtcm9ybVE2UHNheUhQUEgzUVNk?= =?utf-8?B?T3ZNa2NVYXBOejI2R2ptV2VsTDB2WmlrdTFrTHdCbkNqb3RWWmhKUmc5UDFy?= =?utf-8?B?UTRCMDA1R1hvSis1WkRPSEFWR3Frd2VZMUs4aG9yeDN4byt4UXRyYjRGSkRo?= =?utf-8?B?NkFXNWM3RVgwa0R3K0tWNXg2QUhVZnhYQUpTOWFDRmdzeWRadVk3Q1BLb0FP?= =?utf-8?B?RjZGR0tabVNWZm5aRFd6M3FOKzJ1eFhDSTArblpWZm1tc252WHZrYjVmdThK?= =?utf-8?B?RGxaczBYWk1tWXZrdmxrYkZPL0JFRDhveE1RRFBUNk5ySEVEVS9odnNOalpQ?= =?utf-8?B?akowSGRySEhISm8rMVhzeWliL3dkbGZhQ1FRcGZvMi8yQ25sRlZWV1lhRFY1?= =?utf-8?B?Y284c3dXZWZJcnRrY0w0ZFNvY3lYOVUzemxPTm0wWWpnaW1vQTlSUWQ1UjJx?= =?utf-8?B?VUNMZDdqWmdGTEZDN2wzdExYTmxIdkdoODdHNVdvNDVidUpHQlFXNW8rR3R5?= =?utf-8?B?YnliRnozRjl3QUVCQjgxc0dKTGh4WmlkaDhpQkFSRHM3OXhBcndObUlIa3ly?= =?utf-8?B?WUNJYWErWmUvQ3ZlY0V1OG9jdGFRcFpDOEhHQ0ZPbTIvZ201bWZxRFNxdGw5?= =?utf-8?B?dnNidHlBcVRodFlPM0FIcnRzalRBUWFMai9OdUNETVo3VnFBMUxYTi9xZ3NG?= =?utf-8?B?Mkl1SHRzSFphdFFvT2cwamh3RnllYmZYejR4STdjWXdHV2RYQTZnWU5nMDZl?= =?utf-8?B?SnByRUxoemVJWVJZYVh2bGMrOEpLQ3dadjBLWHlKdjI2ZXNiWGp3dmpPQmwx?= =?utf-8?B?MXp1dkIyMmdrRktrOHpHZWpKT0pLaitwUE5mMkdzU25BeTZUWHN1TUtOamdh?= =?utf-8?B?dlZJcXJYdGR4d1Y0ZzQ5WDBBNSsxK1Vhd0xlM3FVVUorenE4TVhyVTNXN1Ft?= =?utf-8?B?TmUrZkdWd1R2S215YmxkU2MrUXIzOHljVVUwWG54QlYwQ2kyU1ZoblNJYVpW?= =?utf-8?B?UWx6b1J4NFk5bng5dUJQWjF6dG5XTVkwT05UcEJBaHIrY0FYUmFMcVJHY0JK?= =?utf-8?B?K3paUWJCZ2FWT3hzUk8rek43Z1dqVTUyTHlNZE9Pc3dJRlVKZXdubjJXYjVn?= =?utf-8?Q?xsjoPioob+VZWhHNlo4Pi2Wz0r57Tcj0RBaO4KV9Pmpo=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;5:+rDbMC4SPpFQuZFg4lUpiQL3eUyMLJ9Qc+PGBXcwTzV+p/UbqEn3iJb3lCGAI9bOlkuQWDGJy7qF9Y1A0Hij5iFUYwzFemW/B+7zK6D/QtpipJFlD+lrWSsArxi5fucfhxo50tqlxaMdHosobC/vMQ==;24:PXsmYwkZG14afFq9mkmd8qs+K7nca72xMmCKLFkXHNF9ZkQp2Vh9rD89QUOUJIdPwqPnxFVvyL34wVJc9OfdKA/NgPzU9FJFUfJ/4sy9BQk=;20:HaetU7/R7qaPV0rAtgprIf2f0vshrFBu5CKC6oBv4BMIMRKWsQ5Z1/GYKAMpfUH0ohAARWNkELhkXASTfAMHsw== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2015 04:48:18.5891 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1482 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-10-25 at 21:42 -0500, Zhao Qiang-B45475 wrote: > On Sat, Oct 24, 2015 at 04:56 AM, Wood Scott-B07421 wrote: > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Saturday, October 24, 2015 4:56 AM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > benh@kernel.crashing.org; Li Yang-Leo-R58472 ; > > paulus@samba.org > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to > > qe_common > > > > On Fri, 2015-10-23 at 02:45 -0500, Zhao Qiang-B45475 wrote: > > > On Fri, 2015-10-23 at 11:10 AM, Wood Scott-B07421 > > > > > > wrote: > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Friday, October 23, 2015 11:10 AM > > > > To: Zhao Qiang-B45475 > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > > > benh@kernel.crashing.org; Li Yang-Leo-R58472 ; > > > > paulus@samba.org > > > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management > > functions > > > > to qe_common > > > > > > > > On Wed, 2015-10-14 at 15:16 +0800, Zhao Qiang wrote: > > > > > QE and CPM have the same muram, they use the same management > > > > > functions. Now QE support both ARM and PowerPC, it is necessary to > > > > > move QE to "driver/soc", so move the muram management functions > > > > > from cpm_common to qe_common for preparing to move QE code to > > "driver/soc" > > > > > > > > > > Signed-off-by: Zhao Qiang > > > > > --- > > > > > Changes for v2: > > > > > - no changes > > > > > Changes for v3: > > > > > - no changes > > > > > Changes for v4: > > > > > - no changes > > > > > Changes for v5: > > > > > - no changes > > > > > Changes for v6: > > > > > - using genalloc instead rheap to manage QE MURAM > > > > > - remove qe_reset from platform file, using > > > > > - subsys_initcall to call qe_init function. > > > > > Changes for v7: > > > > > - move this patch from 3/3 to 2/3 > > > > > - convert cpm with genalloc > > > > > - check for gen_pool allocation failure Changes for v8: > > > > > - rebase > > > > > - move BD_SC_* macro instead of copy Changes for v9: > > > > > - doesn't modify CPM, add a new patch to modify. > > > > > - rebase > > > > > Changes for v10: > > > > > - rebase > > > > > Changes for v11: > > > > > - remove renaming > > > > > - delete removing qe_reset and delete adding qe_init. > > > > > Changes for v12: > > > > > - SPI_FSL_CPM depends on QE-MURAM, select QUICC_ENGINE for it. > > > > > > > > Why is the SPI change part of this patch? Why is it even part of > > > > this patchset, rather than an independent patch sent to the SPI list > > > > and maintainer? If it's tied to other changes you're making, > > > > explain that. As is, there is zero mention of the SPI change in the > > > > part of the e-mail that will become the git changelog. > > > > > > > This SPI_FSL_CPM is cpm-spi, it is part of CPM. > > > > So then why are you selecting QUICC_ENGINE? And again, what does it have > > to do with this patch? > > Cpm-spi is dependent on qe_muram, if not select it, Cpm-spi will failed to > build. Why QUICC_ENGINE and not CPM? -Scott