linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chaotian Jing <chaotian.jing@mediatek.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: <linux-mediatek@lists.infradead.org>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Seungwon Jeon <tgih.jun@samsung.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Kukjin Kim <kgene@kernel.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Barry Song <baohua@kernel.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Chaotian Jing <chaotian.jing@mediatek.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Howard Chen <ibanezchen@gmail.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Kristina Martsenko <kristina.martsenko@gmail.com>,
	Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Minda Chen <Minda.Chen@csr.com>,
	Dong Aisheng <b29396@freescale.com>,
	Johan Derycke <johan.derycke@barco.com>,
	Haibo Chen <haibo.chen@freescale.com>,
	Fabio Estevam <fabio.estevam@freescale.com>,
	Georgi Djakov <georgi.djakov@linaro.org>,
	<ivan.ivanov@linaro.org>, Weijun Yang <Weijun.Yang@csr.com>,
	Kevin Hao <haokexin@gmail.com>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mmc@vger.kernel.org>, <linux-samsung-soc@vger.kernel.org>,
	<srv_heupstream@mediatek.com>
Subject: [PATCH v3 05/10] mmc: mediatek: fix got GPD checksum error interrupt when data transfer
Date: Tue, 27 Oct 2015 14:24:25 +0800	[thread overview]
Message-ID: <1445927070-5102-6-git-send-email-chaotian.jing@mediatek.com> (raw)
In-Reply-To: <1445927070-5102-1-git-send-email-chaotian.jing@mediatek.com>

Even if we only use one gpd, we need alloc 2 gpd and make
the gpd->next pointer to the second gpd, or may get gpd checksum
error, this was checked by hardware

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
 drivers/mmc/host/mtk-sd.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index c877ded..3858163 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -1145,11 +1145,14 @@ static void msdc_init_gpd_bd(struct msdc_host *host, struct msdc_dma *dma)
 	struct mt_bdma_desc *bd = dma->bd;
 	int i;
 
-	memset(gpd, 0, sizeof(struct mt_gpdma_desc));
+	memset(gpd, 0, sizeof(struct mt_gpdma_desc) * 2);
 
 	gpd->gpd_info = GPDMA_DESC_BDP; /* hwo, cs, bd pointer */
 	gpd->ptr = (u32)dma->bd_addr; /* physical address */
-
+	/* gpd->next is must set for desc DMA
+	 * That's why must alloc 2 gpd structure.
+	 */
+	gpd->next = (u32)dma->gpd_addr + sizeof(struct mt_gpdma_desc);
 	memset(bd, 0, sizeof(struct mt_bdma_desc) * MAX_BD_NUM);
 	for (i = 0; i < (MAX_BD_NUM - 1); i++)
 		bd[i].next = (u32)dma->bd_addr + sizeof(*bd) * (i + 1);
@@ -1306,7 +1309,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
 
 	host->timeout_clks = 3 * 1048576;
 	host->dma.gpd = dma_alloc_coherent(&pdev->dev,
-				sizeof(struct mt_gpdma_desc),
+				2 * sizeof(struct mt_gpdma_desc),
 				&host->dma.gpd_addr, GFP_KERNEL);
 	host->dma.bd = dma_alloc_coherent(&pdev->dev,
 				MAX_BD_NUM * sizeof(struct mt_bdma_desc),
@@ -1347,7 +1350,7 @@ release:
 release_mem:
 	if (host->dma.gpd)
 		dma_free_coherent(&pdev->dev,
-			sizeof(struct mt_gpdma_desc),
+			2 * sizeof(struct mt_gpdma_desc),
 			host->dma.gpd, host->dma.gpd_addr);
 	if (host->dma.bd)
 		dma_free_coherent(&pdev->dev,
-- 
1.8.1.1.dirty


  parent reply	other threads:[~2015-10-27  6:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27  6:24 [PATCH v3 00/10] Add tune support of Mediatek MMC driver Chaotian Jing
2015-10-27  6:24 ` [PATCH v3 01/10] mmc: core: Add DT bindings for eMMC hardware reset support Chaotian Jing
2015-10-27  6:24 ` [PATCH v3 02/10] mmc: dt-bindings: update Mediatek MMC bindings Chaotian Jing
2015-10-27  6:24 ` [PATCH v3 03/10] mmc: mediatek: make cmd_ints_mask to const Chaotian Jing
2015-10-27  6:24 ` [PATCH v3 04/10] mmc: mediatek: change the argument "ddr" to "timing" Chaotian Jing
2015-10-27  6:24 ` Chaotian Jing [this message]
2015-10-27  6:24 ` [PATCH v3 06/10] mmc: mediatek: add implement of ops->hw_reset() Chaotian Jing
2015-10-27  6:24 ` [PATCH v3 07/10] arm64: dts: mediatek: add eMMC hw reset support Chaotian Jing
2015-10-27  6:24 ` [PATCH v3 08/10] mmc: mmc: extend the mmc_send_tuning() Chaotian Jing
2015-10-27  6:24 ` [PATCH v3 09/10] mmc: mediatek: add HS400 support Chaotian Jing
2015-10-27  6:24 ` [PATCH v3 10/10] arm64: dts: mediatek: add HS200/HS400/SDR50/SDR104 support Chaotian Jing
2015-10-27  9:54 ` [PATCH v3 00/10] Add tune support of Mediatek MMC driver Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445927070-5102-6-git-send-email-chaotian.jing@mediatek.com \
    --to=chaotian.jing@mediatek.com \
    --cc=Minda.Chen@csr.com \
    --cc=Weijun.Yang@csr.com \
    --cc=adrian.hunter@intel.com \
    --cc=b29396@freescale.com \
    --cc=baohua@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@freescale.com \
    --cc=galak@codeaurora.org \
    --cc=georgi.djakov@linaro.org \
    --cc=haibo.chen@freescale.com \
    --cc=haokexin@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=ibanezchen@gmail.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=ivan.ivanov@linaro.org \
    --cc=javier.martinez@collabora.co.uk \
    --cc=jh80.chung@samsung.com \
    --cc=johan.derycke@barco.com \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=kristina.martsenko@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@codeaurora.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=tgih.jun@samsung.com \
    --cc=ulf.hansson@linaro.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).