From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932122AbbJ0Gum (ORCPT ); Tue, 27 Oct 2015 02:50:42 -0400 Received: from mail-by2on0131.outbound.protection.outlook.com ([207.46.100.131]:47392 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932068AbbJ0Gul (ORCPT ); Tue, 27 Oct 2015 02:50:41 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1445928629.701.323.camel@freescale.com> Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to qe_common From: Scott Wood To: Zhao Qiang-B45475 CC: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "lauraa@codeaurora.org" , Xie Xiaobo-R63061 , "benh@kernel.crashing.org" , Li Yang-Leo-R58472 , "paulus@samba.org" Date: Tue, 27 Oct 2015 01:50:29 -0500 In-Reply-To: References: <1444806968-4627-1-git-send-email-qiang.zhao@freescale.com> <1444806968-4627-4-git-send-email-qiang.zhao@freescale.com> <1445569799.701.142.camel@freescale.com> <1445633780.701.228.camel@freescale.com> <1445921289.701.301.camel@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [50.157.106.250] X-ClientProxiedBy: DM2PR0801CA0006.namprd08.prod.outlook.com (25.162.18.16) To CY1PR03MB1487.namprd03.prod.outlook.com (25.163.17.17) X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;2:l02XmaJPhPl1J61nSh0o3TD9Cmzl3VWDv4nWEzBgvhW9I77HY13Dz7AXpX+LweSznb2ayfhO7H+gN1egFRp4xoO0sCX5Bq8qWilWVhsAle8ogIQj/QszfL2on2zaxpCYCjCALjYdUv3qqaJe4CTBUbtA2f6J895aCn0iTXQanbs=;3:iOvkvl9jnOBPeZ2z982CpSXqjrxBL3X3nqH8kg9RxSs231tejVeFUrpP48HT4cb5+hUZ9z2bVYpfI+Vp4vKA/Dt03yA8ZwVBo2fihuaAzAW1N9Tk/vGsPmAiujHnW7QtPf7/sG3IaBEKdVju5HQwHQ==;25:7z47U3Ekpgiv3881mDzjYR7P4sL4AGXF+eELSaDcQbYI+KHaZglGR9hLSCxjixYZOUb1XF00lU3jwIlqqkIJewy4m5igMmzb+MiyLlS3YN8lGSy1u0zFktCnuu7nuskZTaA+N0SnXVeYmcZWxsFzkw4+Fpu7lHcEIWxWxs7Jlkssz6KqDxyZr8dbv2+yXWxQAvEWV27AW+PMhPmIU8K/ScQCs8PrM4HR515MgRXXDuawxuhtI733eklNu1YJtDYCWaEjhAbWWIWbLHEB8+1J7w== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1487; X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;20:kUmyjPLA0LC8GE23KRkBxxaLZFCMkPohV3NAEHu3W34O/nAApaCVq0/Tc5rqFz2dXMyHt9NNp8cMRX/6lOE3VMEZ7NoLqphttKBhe8xNmOYGdKT3W0q+cYKx/iBh7zb+bjrzUe4B87O9KldgKW/6+oeVEMoOz04u6GPxavf/UAreJE11AS1Sx8g04p2fWIRJyVihJsRVUdvYmtgXYC+Tc8ROzJrf/35bjhj8EzClF/s+ZQYcwv0s+Chwz9tXYqHxjlVv6NsnYmYT/Yn+vXU3NMToIdAKDgd8oiiTDLex/Ty+M4CAnygIKUSj8aWgnWZVSce3kIeVgcsu/7mLGX/MXW5IlzSBg67aatm8m32/bSb+uwRNqvWfMj5sPEquibpbqWHclu6k6aaB/PP8DSv78wFdxo4QHyvANOiWO90EctHHSaBjSA+sjhIlB38etSf1my5O/sU4Qa8oB4waKpOAu5E6cUClXNn+dBGKxMqwvVdAZ/shPjWaPGkJoSwkzmJf;4:0ieyTbww2UpMtUyLVkkQULfWxehUQJQzXRslJG06ZDp9sliMtZsBWVecEqQ655aD0t+wCcAOyMSDeiUuMMtc+lacA60vXujZWYbZaVL483BiywMb8xjG/k1xMUaKkkKuNUaBaeIWO70efTLvq5PEZS5lC50QJtSKxQaj0cf2i1zAWCdrONbEuADf9iLXTsTqfV85j71L+6csreqJkiMGr2otGS11wGMFGSyjQvASQ/CpwM9/KmPtwVoSYOjb+Yh2QQbxOjlnv510xsjgLTvru9VbQXKqOfzBpCUIENHjRjRZb7JWpVVzzNml9k5DgjQe7fnHYtgKmGx0YY0VT4I5Yhe57j/1AXKUTV52yo3BSweXUjilFAQSrS1fXLB+yXQB X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(102215026);SRVR:CY1PR03MB1487;BCL:0;PCL:0;RULEID:;SRVR:CY1PR03MB1487; X-Forefront-PRVS: 0742443479 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(54534003)(13464003)(189002)(199003)(377424004)(377454003)(5007970100001)(33646002)(105586002)(101416001)(5004730100002)(93886004)(5001920100001)(81156007)(66066001)(5001960100002)(76176999)(86362001)(77096005)(97736004)(47776003)(36756003)(189998001)(110136002)(106356001)(4001150100001)(23676002)(42186005)(92566002)(50466002)(5008740100001)(103116003)(19580405001)(87976001)(19580395003)(4001450100002)(5820100001)(50986999)(2950100001)(40100003)(122386002)(50226001)(99106002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR03MB1487;H:snotra.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIxNDg3OzIzOnZaVFQyd00wRWpXTTQ3YUR4N0g0UW4vcEJk?= =?utf-8?B?LzM2NG1qRzBjRE85dDNlOUI3Mkh5aVBxckxhY2lnT0hHVEt6bldJNENwUFNN?= =?utf-8?B?bmkvM2t5RU1lVXVpbW5XRlh3YS9MZkxrZjRMQnY4OTVWc2YvSHZKVXlZUmFC?= =?utf-8?B?M0U0ZTBTRVJQME9BOTBmaGQ1bDA5WUttN2hQclFtYXpGTWVZUG1oQmlNOFVk?= =?utf-8?B?R2RuQnAwcVJqTTZBcjc2aWJVNHk4ZGNFMUg4bjR2NElYNDhCY1g2TXpBZEsr?= =?utf-8?B?RWc0VTM4eGFtZnlpeEx4ZjY3aWhhVUVTMVVjRzNiczBRcHgvemVFVFY2bUJa?= =?utf-8?B?TVAyN2xSUDdGdWFOa1E5OGVFQ2h6Y25HMWVpRkVvMngvTW1QdDVSQ3BQSVNr?= =?utf-8?B?UnBaV0wwazJPVk4yL0FmbzhFODRNVXU3QU5WS3g0dWFhWEFzaHF5WDFYTHNh?= =?utf-8?B?Qk5kSUQ4ZUVLdFNZemVHb3Rnb0VJN1pPV2pHNzluRXlkczB6NkxkNkh2ckhl?= =?utf-8?B?L3E0bytibzNvS3h4Y2ZqZENMU0pqaGN3MXJnMHI4b1lXN2VGMVcrWGoyOVRp?= =?utf-8?B?UDEzYWFQT3JlOGxMMFFkbEJqenB3cmpVOUt6MGxwN0tMMFRmMHhFeHEzYVBR?= =?utf-8?B?K3AwaUtlMUVSdC9zdXkrZnNOcVUyZXdRQVFtdnpQcUpxVXdoSFo5eGlFcHIr?= =?utf-8?B?TWtId2g5ZDZXVUcxOEs5RUdoUEdENHVDY2V5cmxXdnR6Z2VMSXZrWmlNZ1Zs?= =?utf-8?B?RE5ZUm5MaHJtNjFaV3lXRjVMTU9zb0NDQkZPTGtzZHJBSWpxajB3RWU2dEdP?= =?utf-8?B?VnlZQTI1T1poakl5Y1pSd3ZERzBhREt3d05GWlVnTXduRURYejNDdUx4N05l?= =?utf-8?B?dnpncXVjM3Q0UlFHY2Z0MWNYVHZqVEhrYkxjR1VLOGYwVVE5RDBQb0doZjla?= =?utf-8?B?TFZhM1JUakVkUC9uSU5uZzhmaHlLeDlWaWVxTHNsREYwTDdCYXVPejRvRUI3?= =?utf-8?B?dlgvYWJRNllBOVNNTkVvZFlVQXV3Rk0zdi9xS1BuSTJhZjJSOC9vUnRoZC9F?= =?utf-8?B?VkM0cUJJUXVvbUpVbEVLWXlwNTFkejRNaC9NcDJ0WUVhNnVFaTE2NStzWk50?= =?utf-8?B?RXRWbXF1MVEvSnZMd0k4V0RuRkUwRjd5QkNuaWFnQzFHekdDaFlUbjVaQytq?= =?utf-8?B?cVBETEJaY0NVL2VvaVM2ZWk0TTJqcGtRMjRmbG5ZdnRUR0VvMzBZZ2krdlVv?= =?utf-8?B?ckFkOEVXLzdhdHhsNnZReE5lcUdqRno3a0kzOXptSVlhRnM4b0trL1h3NEtF?= =?utf-8?B?NC93UVpKRmtHM2pzK1F0VHpPTEpDaU5Ldm03aTBYMnNaZ2JtckRnQ1FmZk5a?= =?utf-8?B?OW05c09lNlFzSHpTdEp4TkFHQmozWXk2Y1ZpZ09ubnZqaVpUSjYrczdmd05y?= =?utf-8?B?VTF6Mnk0SHJaZ3F2NW43ZXV2alpmSUhGdTJhbzhIVU9nZ25XWHFiak53TFJM?= =?utf-8?B?UFRkbnlHanMrK1R6Zk56a0RCVG5ub1R5ZWlnMEk5NzhPaWhoMGgxcVVKWXRa?= =?utf-8?B?d243cERIS1JUSUNXT2lsaDJiMjZIbmczOXJ1MUdqdDA0VDlCWWZoOUR3Q0RK?= =?utf-8?B?MzRCa0dycVVEOThpRTNHR011RzNPQmVjQitHc2Vwb1o1Z2UzcE1nakxBPT0=?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR03MB1487;5:IXJmgCaCjtufl9xUJ48658+rrMCpv8WhkpQ1xwlEh0f4otMqRoEzqkw2JvXon9GBFU/D9CeqRuij9Vmbht2IwMupkVQHzmMUKKl3rLSc/oiDBA9z9bxeoQSxDcdjlLmrixBJ3bvB1hyOhpUbsKXzlg==;24:8iBlDtfeNzCOSm+mi5ne8BG5x4IhOFzNpuIT/yhARZYu603kH6jvmoZjR/xmviKeE7Hkrzv6gAswuAdu5KZExqQumSUnbH4I4TL13J4RbPg=;20:mHKjJB3UXaEyWYP6LBgRXxM4rfNhim41rg8I4GV183mFFpn1D9iBjvdU0wZzqNs+771/jPPa4J5eR3O0yNIMug== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2015 06:50:38.8760 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB1487 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-10-27 at 01:24 -0500, Zhao Qiang-B45475 wrote: > On Tue, Oct 27, 2015 at 12:48 PM, Wood Scott-B07421 wrote: > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Tuesday, October 27, 2015 12:48 PM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > benh@kernel.crashing.org; Li Yang-Leo-R58472 ; > > paulus@samba.org > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to > > qe_common > > > > On Sun, 2015-10-25 at 21:42 -0500, Zhao Qiang-B45475 wrote: > > > On Sat, Oct 24, 2015 at 04:56 AM, Wood Scott-B07421 wrote: > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Saturday, October 24, 2015 4:56 AM > > > > To: Zhao Qiang-B45475 > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > > > benh@kernel.crashing.org; Li Yang-Leo-R58472 ; > > > > paulus@samba.org > > > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management > > functions > > > > to qe_common > > > > > > > > On Fri, 2015-10-23 at 02:45 -0500, Zhao Qiang-B45475 wrote: > > > > > On Fri, 2015-10-23 at 11:10 AM, Wood Scott-B07421 > > > > > > > > > > wrote: > > > > > > -----Original Message----- > > > > > > From: Wood Scott-B07421 > > > > > > Sent: Friday, October 23, 2015 11:10 AM > > > > > > To: Zhao Qiang-B45475 > > > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > > > > > benh@kernel.crashing.org; Li Yang-Leo-R58472 > > > > > > ; paulus@samba.org > > > > > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management > > > > functions > > > > > > to qe_common > > > > > > > > > > > > On Wed, 2015-10-14 at 15:16 +0800, Zhao Qiang wrote: > > > > > > > QE and CPM have the same muram, they use the same management > > > > > > > functions. Now QE support both ARM and PowerPC, it is > > > > > > > necessary to move QE to "driver/soc", so move the muram > > > > > > > management functions from cpm_common to qe_common for > > > > > > > preparing to move QE code to > > > > "driver/soc" > > > > > > > > > > > > > > Signed-off-by: Zhao Qiang > > > > > > > --- > > > > > > > Changes for v2: > > > > > > > - no changes > > > > > > > Changes for v3: > > > > > > > - no changes > > > > > > > Changes for v4: > > > > > > > - no changes > > > > > > > Changes for v5: > > > > > > > - no changes > > > > > > > Changes for v6: > > > > > > > - using genalloc instead rheap to manage QE MURAM > > > > > > > - remove qe_reset from platform file, using > > > > > > > - subsys_initcall to call qe_init function. > > > > > > > Changes for v7: > > > > > > > - move this patch from 3/3 to 2/3 > > > > > > > - convert cpm with genalloc > > > > > > > - check for gen_pool allocation failure Changes for v8: > > > > > > > - rebase > > > > > > > - move BD_SC_* macro instead of copy Changes for v9: > > > > > > > - doesn't modify CPM, add a new patch to modify. > > > > > > > - rebase > > > > > > > Changes for v10: > > > > > > > - rebase > > > > > > > Changes for v11: > > > > > > > - remove renaming > > > > > > > - delete removing qe_reset and delete adding qe_init. > > > > > > > Changes for v12: > > > > > > > - SPI_FSL_CPM depends on QE-MURAM, select QUICC_ENGINE for > > it. > > > > > > > > > > > > Why is the SPI change part of this patch? Why is it even part > > > > > > of this patchset, rather than an independent patch sent to the > > > > > > SPI list and maintainer? If it's tied to other changes you're > > > > > > making, explain that. As is, there is zero mention of the SPI > > > > > > change in the part of the e-mail that will become the git > > > > > > changelog. > > > > > > > > > > > This SPI_FSL_CPM is cpm-spi, it is part of CPM. > > > > > > > > So then why are you selecting QUICC_ENGINE? And again, what does it > > > > have to do with this patch? > > > > > > Cpm-spi is dependent on qe_muram, if not select it, Cpm-spi will > > > failed to build. > > > > Why QUICC_ENGINE and not CPM? > > QE and CPM use the same muram, and it has been moved to qe_muram from > cpm_muram. Fix the makefiles so that the muram code continues to be built for both QUICC_ENGINE and CPM. It's not acceptable to have to bring in the entire QE code just for the muram. -Scott