From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752841AbbJ0HgZ (ORCPT ); Tue, 27 Oct 2015 03:36:25 -0400 Received: from mail-by2on0101.outbound.protection.outlook.com ([207.46.100.101]:25529 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752193AbbJ0HgX (ORCPT ); Tue, 27 Oct 2015 03:36:23 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1445931372.701.327.camel@freescale.com> Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to qe_common From: Scott Wood To: Zhao Qiang-B45475 CC: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "lauraa@codeaurora.org" , Xie Xiaobo-R63061 , "benh@kernel.crashing.org" , Li Yang-Leo-R58472 , "paulus@samba.org" Date: Tue, 27 Oct 2015 02:36:12 -0500 In-Reply-To: References: <1444806968-4627-1-git-send-email-qiang.zhao@freescale.com> <1444806968-4627-4-git-send-email-qiang.zhao@freescale.com> <1445569799.701.142.camel@freescale.com> <1445633780.701.228.camel@freescale.com> <1445921289.701.301.camel@freescale.com> <1445928629.701.323.camel@freescale.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [50.157.106.250] X-ClientProxiedBy: DM2PR0801CA0038.namprd08.prod.outlook.com (25.162.18.48) To BY1PR03MB1482.namprd03.prod.outlook.com (25.162.210.140) X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;2:Ja2uLPDtcMg6ZomQwQnQ0zozgPO30Bvo5u60TtGS9TaLZTJibtCQ9P8eL3b72vCDRcBxuGfqopfDwXdpDoU2YoadILgutWcZLP3tgSGTuQpJOepXnhT9lI4uJY861Zy4YGJtD7xMUMqPJIoivLxf13wiG5eCtyQBzC2wqRpMnHA=;3:kkkgGDotkeYuE3/vLqyAeqwDstrdWSalpCkocGIOMzoQfggKSQ2ZRIVFFibELBPDyoUhnxC6ez5yzlQEMk7QSZRST70O7C7Uo33MioUu6xW1lrFEJgVXvItjIx4Ow0ku/Q+OanseYM42my6C/LB+Bg==;25:EnLJo2oScmgEyCnNatqDXADndYTM8LEeu3sQZnyoCLfiR4avJH1Y9UfMpQDT7qFPICARdTdDzpTADDaTyWyyvg2yxwG1BpI5qKGlwcadqwm9TWCNxPd6cPDA6tpHMBROXysacg/v8YA0BhbYZI/a/mZryXotu34U83fdWYqQrYSuFvrkApErVAOLkluFRLgPg/Uv4en7ZLDSl28zYJ1E1xyjqyinzU5MFl9kwlXFMBRjJohlLwZB1uuW+hB/iRyN6mSZeVSLudNFBOIl3KLuLg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;20:i5rlbhXB6fS+lxc8EyP2Rygg5cca4uW3rQgiNDv/1di+9f3rF/9Nr3ySpTIjtGwov30VSWwSKArvVatiGmTKXfjxkkAzVj5TcRn5nDIIr17e1CpMxitJZJKqymRKF6I9K0x0HHVwxJ58b84lNkAkTEWeNRR8On9qPTcc5qj3AUc/jeDfzvxS+Yup/c9B6vqqgx45pWU/oGELITwXK5VbrqJJ+k9x3/EpTL6d5e6jqzoB5TO+R9RNOnSkaw5etfAXYIS2id2+lvG17pV1Tpu0JhcyEuUl6BHsmzPql9cpQQZ64TOwK0TUfyw0qKdz75XwzCsocZT6d+fWnJNcuztcgLmpXD09bYigz0/EGB57dByjuYirYW3+w0wV06fthvJDg2/r7dP0aZoc9onWOlpqnZtOaMe4Uo6Ki4nJCy3HGKDe65PIZugys3RMm5pu2YZwSkAZLZUrcDQazy6uAKiNqvnV5Fk1xkmlsj4qduGWei78I259Z7V4Go324GTYkGbc;4:pvBnsNz/bDrFgaCSvksUTPwZ+dwQ7fWgZLcCso0R9XgLP84G9yb7m7pz5DyajHHudBAYCaG5E6gbxI1di0T68+cOkGuqGjRAWGqWW5t+8dBqTHzuSWeX2YRhTrbqXEwfeDDke6yv2YbWD5Twp9TiDES7O5Viaa5AF9yT3HUuAxOPzsCpqMXpozVFJd2J0VOsgq+Erk4uGKyMgZg2o6Dj3Ku8LO6V9mEsT+FbYX5nQUULNYh0TFiYpZ8b8NxRF4k+BtATwXuxJWlTYC1QCiAzB0yQJpGLQo3GXU03o06MfV/bwwNsoOGGMRhFyRap1UlmVxNxHzSESVo8ZExVK8RvfEz+CxdPXJ2vI7EGoEdxczxQgyBJFZ4y0Bj1tGoX224w X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001)(102215026);SRVR:BY1PR03MB1482;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1482; X-Forefront-PRVS: 0742443479 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(377454003)(13464003)(199003)(189002)(377424004)(5004730100002)(66066001)(19580395003)(47776003)(50466002)(19580405001)(93886004)(105586002)(92566002)(106356001)(5820100001)(33646002)(36756003)(103116003)(50226001)(23676002)(5008740100001)(42186005)(4001150100001)(110136002)(5007970100001)(77096005)(81156007)(87976001)(86362001)(76176999)(4001450100002)(122386002)(50986999)(5001960100002)(101416001)(40100003)(97736004)(189998001)(2950100001)(99106002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR03MB1482;H:snotra.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjAzTUIxNDgyOzIzOkJnWW1ZZHVuMVh2WWxJOHBCRU9SbGlNM3hN?= =?utf-8?B?RWo3bU5sYi9TK3NjY3FuVWtCTGpweGp5ODJFdG5jZUR3RC9zMVAra3lEbkdW?= =?utf-8?B?RmhERW90ZE9FWW1YdmxNQWYwRDJFUDlFMXZHaUhwWEcrdlJRQ0dYWlgvSERP?= =?utf-8?B?S2FOTjJXd2tQZnBiZkQrQkV1MlU1dXJLWUhGdXVhV3czckJxRXlSV085VDdI?= =?utf-8?B?K1lHNjl5cDB3S3VOQkoyN1YrSXlmVzdLckdhYUtCTGc4ZlVUUDl2S0VRSHNt?= =?utf-8?B?MTZ6eVl6dHJ3MVh2VjJTNFlPMW5PaWtRSDBwcVB2R214d3UraTBocHp2bUJu?= =?utf-8?B?RTFhSTcrb3A0Q3BGOE5xbzcyT3JFdXp4dlZPaVNaNnNJd1hQZCtjL0pkb0Iy?= =?utf-8?B?UngyNTYxc1diYys4Y0NzbUpZZXcwdzd1QkJ5ZGt4MkNIQStEd0pjcGorTGZM?= =?utf-8?B?WkdiaVpING5xZk9oUFJKem1iU3duRDBDRWxjemxZazZwNS9PL3VEcUdrSHk1?= =?utf-8?B?TXRkaWN0N1BubWdNK1lJWDVPelRMWnhocjNQcEViWjBkNWtVN3FZNDFvR0RZ?= =?utf-8?B?K3djMTFKK2V0SE81aE9ZeFp0aEpDR2V0MitpcVMrSVJ0U1BhUG5HN3A1Nitk?= =?utf-8?B?SHFQOUxBcFJsYk15ZElOSTErcHlIZFB3OFJWb1QrZTU0LzN1TXE3T3RYVCt4?= =?utf-8?B?Q283R05TU2VkeDA1ZEE3UUdnN2thK08xeWR4U1hxKzhRNG1kdktkZnVEQlJa?= =?utf-8?B?TXB4TFNjUjBBMnNKSjRJUzkycG9rdzBvT2JNR2x0U0NEUk4xSGVvNU1lUkNF?= =?utf-8?B?bDFZTGhVdnZtVVlYM3FPVGtBOHJodjFEbE1UZmNPcUIvSjliUG9ERTQ3WVpO?= =?utf-8?B?QzBPVmRTMTFTRCtCUU9FSkpLYTlFWHM0QlZJbkxkNDRpd2xLS2xCYWJYa1pj?= =?utf-8?B?UXl3V3JPMnAycndOWUYzeW43UWdmUXI2OEdPN0Nib0pvNXRHd2ZwVFFxREhI?= =?utf-8?B?djZla29YeDdTeEF2UXZFbnorOUVDekhTaU1tdUhjSmJ3RmhIZ3d2aGhqWlpR?= =?utf-8?B?OGhiQlRBS2ZYWVVteFd5bkFJaXpiY1VFT2p2OVNnb3hFM2VhNkhqYTBleFda?= =?utf-8?B?OSs1MExTeUp1TUpSSmVQcm1MUU5qNjg3TWwrSEtjQnpjd2s0SDB4cjNaNDJM?= =?utf-8?B?NmZ4ZktFTzJYRkRZRnJsRUpDOW5ES3dOb3A0OVVXWEI0Qk9OZUh5M05IbWVC?= =?utf-8?B?M3REVFpPb3YzdGNJRmREY05jMlVMbjRocWZoMitPU2Z6bFQ3VXpBTWVqbHh1?= =?utf-8?B?dlEyQzdaRTc3R1ZETnJRZUNlVHVvS1c3MFJBdUh5S2FjWndDYytobndjSGtO?= =?utf-8?B?aUFjQXVLdmdzc3dOUktKYk5SYmxKNHg1N3VrbXk2UkFiMlZWTjYzWjA2STEv?= =?utf-8?B?ZjMrWTBxRHk5R3A0RjRBWi81azVsU1dCaWZzV2hpeG82K3VKdFpYd3R4Nzc0?= =?utf-8?B?V1QycVFZMHlrNjQ4dWovM3RseEZGd1lnTTdRSk9acnFGTkdvZ1hyR05Qang2?= =?utf-8?B?dlVmNUtpVjZzN2FDVkRQM1JpY0drVGc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1482;5:8T1qtXAW2Q/bO1BR+bAWqlQF8XIfGarPdb6nlfdcm2yUeD+VY75PDybTgJ6jcjNiabO3uHuhBbZFhbE6jzeUZutakmkvU882dnOYs0opWqWnahfXI6RX/rGVPR/G0VpcPw9k+5VUnOM3e7Uus/qxsA==;24:Sn9DOojSC/AjHrmSUkRx6Dnmnf8tVyxW/AMJyKEaEnsooOkJwrOrkN9IQqXnFYb+svLlMDgvD59m1lj3mxpuhBYu2loCCDOHLz89EAmAKXs=;20:v30DdrtHDA6OBxSZ52z22YMjgCRdNYU7PRRsMdJLb3dpeFmITrSOO58UVLSbchMTm+iX59BJ8Ex3XNxu43DP4A== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2015 07:36:20.5815 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1482 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-10-27 at 02:34 -0500, Zhao Qiang-B45475 wrote: > On Tue, Oct 27, 2015 at 2:50 PM, Wood Scott-B07421 wrote: > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Tuesday, October 27, 2015 2:50 PM > > To: Zhao Qiang-B45475 > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > benh@kernel.crashing.org; Li Yang-Leo-R58472 ; > > paulus@samba.org > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management functions to > > qe_common > > > > On Tue, 2015-10-27 at 01:24 -0500, Zhao Qiang-B45475 wrote: > > > On Tue, Oct 27, 2015 at 12:48 PM, Wood Scott-B07421 wrote: > > > > -----Original Message----- > > > > From: Wood Scott-B07421 > > > > Sent: Tuesday, October 27, 2015 12:48 PM > > > > To: Zhao Qiang-B45475 > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > > > benh@kernel.crashing.org; Li Yang-Leo-R58472 ; > > > > paulus@samba.org > > > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management > > functions > > > > to qe_common > > > > > > > > On Sun, 2015-10-25 at 21:42 -0500, Zhao Qiang-B45475 wrote: > > > > > On Sat, Oct 24, 2015 at 04:56 AM, Wood Scott-B07421 wrote: > > > > > > -----Original Message----- > > > > > > From: Wood Scott-B07421 > > > > > > Sent: Saturday, October 24, 2015 4:56 AM > > > > > > To: Zhao Qiang-B45475 > > > > > > Cc: linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; > > > > > > lauraa@codeaurora.org; Xie Xiaobo-R63061 ; > > > > > > benh@kernel.crashing.org; Li Yang-Leo-R58472 > > > > > > ; paulus@samba.org > > > > > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management > > > > functions > > > > > > to qe_common > > > > > > > > > > > > On Fri, 2015-10-23 at 02:45 -0500, Zhao Qiang-B45475 wrote: > > > > > > > On Fri, 2015-10-23 at 11:10 AM, Wood Scott-B07421 > > > > > > > > > > > > > > wrote: > > > > > > > > -----Original Message----- > > > > > > > > From: Wood Scott-B07421 > > > > > > > > Sent: Friday, October 23, 2015 11:10 AM > > > > > > > > To: Zhao Qiang-B45475 > > > > > > > > Cc: linux-kernel@vger.kernel.org; > > > > > > > > linuxppc-dev@lists.ozlabs.org; lauraa@codeaurora.org; Xie > > > > > > > > Xiaobo-R63061 ; > > > > > > > > benh@kernel.crashing.org; Li Yang-Leo-R58472 > > > > > > > > ; paulus@samba.org > > > > > > > > Subject: Re: [PATCH v12 4/6] QE/CPM: move muram management > > > > > > functions > > > > > > > > to qe_common > > > > > > > > > > > > > > So then why are you selecting QUICC_ENGINE? And again, what > > > > > > does it have to do with this patch? > > > > > > > > > > Cpm-spi is dependent on qe_muram, if not select it, Cpm-spi will > > > > > failed to build. > > > > > > > > Why QUICC_ENGINE and not CPM? > > > > > > QE and CPM use the same muram, and it has been moved to qe_muram > > from > > > cpm_muram. > > > > Fix the makefiles so that the muram code continues to be built for both > > QUICC_ENGINE and CPM. It's not acceptable to have to bring in the entire > > QE > > code just for the muram. > > > How about to define and CONFIG_QE_MURAM in Kconfig for muram? That's fine. -Scott