From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753188AbbJ0HmB (ORCPT ); Tue, 27 Oct 2015 03:42:01 -0400 Received: from mail-by2on0148.outbound.protection.outlook.com ([207.46.100.148]:34572 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751824AbbJ0Hl7 (ORCPT ); Tue, 27 Oct 2015 03:41:59 -0400 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=freescale.com; From: Peter Chen To: CC: , , Peter Chen , Subject: [PATCH 1/2] dynamic_debug: fix boot parameters parse Date: Tue, 27 Oct 2015 15:40:25 +0800 Message-ID: <1445931626-11158-1-git-send-email-peter.chen@freescale.com> X-Mailer: git-send-email 1.9.1 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD034;1:WBLvoA3s3Yo/40xc9JpBMH3+nN4exDL3L8yuFgQOMp1O7KN7/BtYGgcWDjb6p7JK5J4ClilaAwa13KF1paCOf/oi/wnLil3t/yR6SP1VkVdjso1sHVRdceB8thG2m/s4oO1xchZ+UTxBAl8JEueau6G5kzftYNyVQdhRah++R73/SwVd3c9mNakNSgAl/fiLjKvA8L93qlHDPdTXb9uTwFagPT/Ofkj3aEhcO7r1NwqMD/q34L/icuoENyR2ACuD7Wb1seNZcffD2uwN7ToOgt61Cmzbgb3vbhuuRkKYg8B1Wno8VfxLRpUNnTwRjxzn33D4U3eR1Lo+2/2qsnriK5N0tbt+bG6jfLBOt4GAIGDILygC9NaSLfknD6fTA4M0AGZOkxleYBRCMFg4f5fMzQ== X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(110136002)(6806005)(92566002)(50466002)(11100500001)(50226001)(77096005)(48376002)(47776003)(2351001)(104016004)(229853001)(5007970100001)(5008740100001)(5003940100001)(189998001)(5001960100002)(87936001)(81156007)(69596002)(5001920100001)(86362001)(50986999)(105606002)(106466001)(33646002)(19580405001)(36756003)(97736004)(85426001)(19580395003);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0301MB0860;H:az84smr01.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB0860;2:UqJcwyeZiFO3rjrzgbv17cbxrJQZZ+j96e3Ib3frlIA+X5yD6F5Mfb2UBI9fZ4IgZXs5cVRuYjrSqDP1IEs+FLZI2s/bh6mWPM2GSZ1DbC1EK53tYbBWPesyzydmvOwDaPDM46835uK1yVf7QtmkfA5zdOSb6aLqfsePg/+FNYI=;3:ysYD6A1HL+GRvC2EMUe0q/66mzqL49iXWMAXZM99mCFibPrUeDfsykXCxeI6voAR7s53vlsHkHIrpE+xJ2ghl0mmWF8EmzPQYBZeho48mfOgL8wP07VYxCJ8nKDjZHqT+jH23IPzCXDOg/ANFzULlrRIZTK5tV3NrshifwNjOAWBoU0dVo+mtI+FRXhZiF1hSlZ4sD4/vqSFLccNT6phDCDaMQgfPFEWJeYdzKQEM0s=;25:uPyxtFvS6tcPmH0MoVobyAiOGK04aATFl6oTywc5WCNcwMd6gC7jSuWr+rzxhDWF+aSghNvTfss++TQaGywCo7xhMOJ3waZqYsAzpMdYLCrgr5XfKL0M26clPV0vLt3BqPOf0dZNnHprnlRKfk6bM11qf95U4WGnXbxgK3fwesgbKKsmLkZBWaxoFGySJs/0DgZcys6+zeyKkWs4n+A7g5+0xq0konZsBKWvSmpB9fwW2XbOZR/dj9aMJ3ubmXf4/RsVnMbEqtRsjMPD2suwrg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB0860; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB0860;20:BqYUTQI9CmFa/sLnjAxzvgd8zf8q4Nsbnf8sG331aYm7a20Pwidb5I7NjPw2N7ZCL+qVbhtF6ni/GHXX78I74Kl1PaxYndV+MwVDmGUSzEv8KUmfE6FFws+wklavZvNx0iTnaPYfDu19dwefa7HVkfGWe/25H8X81GUV0F3Dtu/uMr7+8qzHzFQnxJLVPpiX2wseZUPphTQ2LhjNGrObWXhySLIScrC0aK3dNUBXy2tnfTyVtLjWtpzZa2ajRdqvVNZTlqXnTavnkTKXJFK4V8Y4hJdMgVwjIMHLQbcsq+RH7Ocfr/nlgusZnHuTPW0DjmgdmuHPTVLol0zud0gGR8Bp5s2xHfUN62a5XMZPyFg=;4:k9TYp/6cQcBJCmiCLNvrX0gNdI48TA+zkeExq6UkTLmaYk4iI8wntFv0Hk3wy7DzJzALFpeCikW84fkUdnlz2WveDurAUMviU6imQa2XUCIH+J80VuZ8HdIfSz8oroYGPdbMa3xxtoSx97FH1SW1OxjHKX/C+FLY15CH0NeONmMFsfx00VDrsV/Hwy8ry7c8KG9Cck49zj8n5Ptjmlsj+d6aCOoHP2qDVsucPV8cFc2xNkeV+lJ2jtPQaHvxQMEYtnvr7kvy1TLxhPJrvHZOndZHzZveGikOJws+P3oE3Xv7MBGjBXjGsqnnFzfBeJCEvYY0D0V+oSsU9MvbmwvWCJKP831LJ1Qz8opD6+oIoseIKtim6Lp9C7MBFoQC5JSy X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(102215026);SRVR:CY1PR0301MB0860;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB0860; X-Forefront-PRVS: 0742443479 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR0301MB0860;23:zZAAP72lfjZ0YCxFvZobi7ybGatox1rZSkNbzg2?= =?us-ascii?Q?ETxsFJxIEWGlHRUPJX52BHsfqs52IpbpEnbJu8TrQOWBI63swDl/cTveBojU?= =?us-ascii?Q?Rk1oMhCfhNAFx6Y0R40333sYZpJD6tq3kcNRLi7geIkmRcfOyU++1cFCeq9s?= =?us-ascii?Q?AZkHpqx5JWyMe8N+ROe+ctJ5ta0UC24BIR98iZvGC0Gb1eIjPSmKg+GFgcx5?= =?us-ascii?Q?6n5KBxzx84YqY6OF26Feui7pbRfhidab6f09v7WEk6UG5B0+JoVZouOzgK93?= =?us-ascii?Q?gfnZ0CBRo6WqckjANLUHdou26cGCodUkiMNDH4eeRqUsTrSx/ziSpAl+IoKk?= =?us-ascii?Q?Uy9ReL8AAWfkDp38JOrOVxhNX13FkVoLWkOq7fVFJr7/sD6RxHaSAPmQRbnH?= =?us-ascii?Q?WhoeGpxx21gpgU/6P1IOJSW4nfH5jY8Eo7FXLXnGwqua3erdvSJijX9vALZO?= =?us-ascii?Q?uCianxQ3WGxqqPLi3fJMhIzLr58WXIAWY/IYdRPLYZP5E3qOqcYn0DUCNnaQ?= =?us-ascii?Q?ddJwjKobaosp7/yw1zbCnfBza0uEiyvDUMiQIFT91EHwpwV9gcuEOqDpZLou?= =?us-ascii?Q?dEj6ORSO8WcHO/klvpPSu8kXjhnkO5agfoKyxBvErbaGsc72uWC0+nyoeika?= =?us-ascii?Q?yQNNE4MGnIbxBL//6bai9jVTJx+Z3ZPpjblF7aj1YoTHdkuhEv9CB1WMVEX4?= =?us-ascii?Q?3MV/wC9IBKRmwXl5Dydqly/GoOqPw54HuiPY9GrgkoOPfxSlW8T0qNQXXkuo?= =?us-ascii?Q?NKdemXGXFxJ7vXwwAiDCgR/ctX6C51yCUo0HGrwTh413rTL0mYmjGktS0NTv?= =?us-ascii?Q?e7ziLrbEtyzcVO2txY5lLvj1UO7sWfXGZHTdsFfkEh6EmudedOuJr3RpnUz1?= =?us-ascii?Q?MB3iuEJekCtDPL044Oz0LdbaeFq3CO6c01BIBEjigZH5GGc+m6lM01e//6Kh?= =?us-ascii?Q?46lHS+IgKHozrITi38KWwbzjSq1rcGXta5pekehfA5boPJ8nhaL2kH43WEBI?= =?us-ascii?Q?CZWzlS41S5JUscLNenb0eQcqF4Duw9DCbJEgJqPPvzAJIqw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB0860;5:qFm/6OUimzdOu+p4hfoOMUzsI6eOEZfoCwE0JfLgGf9HRg2pvAXzGPS0MkcdZhdl/Gq6lxx/CZW4E6FUwf/gtPVZ42YL7a8gynk8HQsav47Mj39SuwtQq5ogrpdXXIw7Uwe92pNvfl0xShMiz6XMow==;24:xzArEm1t+vR6K1++gUn3JOfXkdguvN4wsJphQ5qbTb4vtl9aCQ7o8BH08W+8wqi3/0aG0kM5h0wG3QlLTkxLx1fbsiC7zqxhiTRHji6MADA=;20:gkWrz0da7kxhUyjkclJj9fLDmtgIN1ydp6GbZqx9S48VZduaPKoxxYKFLFzor32W4O5EIBkaklVcVv9vm8b1Dg== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2015 07:41:56.1056 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2];Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0860 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The parse_args will delete space between boot parameters, so if we add dyndbg="file drivers/usb/* +p" at bootargs, the parse_args will split it as three parameters, and only "file" is for dyndbg, then below error will occur at ddebug, it causes all non-module ddebug fail during the boot process. =============================================================== dynamic_debug:ddebug_parse_flags: bad flag-op f, at start of file dynamic_debug:ddebug_exec_query: flags parse failed =============================================================== As a solution, we can use comma to split parameters for ddebug booting parameter, and replace comma with space at code, in that case, the ddebug core can handle it with the same way we do it for /sys. Signed-off-by: Peter Chen Cc: --- lib/dynamic_debug.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index e491e02..da4883b 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -880,6 +880,8 @@ static int ddebug_dyndbg_param_cb(char *param, char *val, if (strcmp(param, "dyndbg")) return on_err; /* determined by caller */ + /* relace comma with space */ + strreplace(val, ',', ' '); ddebug_exec_queries((val ? val : "+p"), modname); return 0; /* query failure shouldnt stop module load */ -- 1.9.1