From: Weidong Wang <wangweidong1@huawei.com>
To: <kashyap.desai@avagotech.com>, <sumit.saxena@avagotech.com>,
<uday.lingala@avagotech.com>, <JBottomley@odin.com>
Cc: <megaraidlinux.pdl@avagotech.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <wangweidong1@huawei.com>
Subject: [PATCH 2/3] megaraid_sas: Convert printk to printk_<level>
Date: Tue, 27 Oct 2015 16:26:14 +0800 [thread overview]
Message-ID: <1445934375-17784-3-git-send-email-wangweidong1@huawei.com> (raw)
In-Reply-To: <1445934375-17784-1-git-send-email-wangweidong1@huawei.com>
Reduce object size a little by using pr_<level>
calls instead of printk(KERN_<LEVEL>.
Signed-off-by: Weidong Wang <wangweidong1@huawei.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index ed9846d..2287aa1 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -5889,7 +5889,7 @@ static int megasas_mgmt_fasync(int fd, struct file *filep, int mode)
return 0;
}
- printk(KERN_DEBUG "megasas: fasync_helper failed [%d]\n", rc);
+ pr_debug("megasas: fasync_helper failed [%d]\n", rc);
return rc;
}
@@ -6233,7 +6233,7 @@ static int megasas_mgmt_ioctl_aen(struct file *file, unsigned long arg)
u32 wait_time = MEGASAS_RESET_WAIT_TIME;
if (file->private_data != file) {
- printk(KERN_DEBUG "megasas: fasync_helper was not "
+ pr_debug("megasas: fasync_helper was not "
"called first\n");
return -EINVAL;
}
@@ -6355,7 +6355,7 @@ static int megasas_mgmt_compat_ioctl_fw(struct file *file, unsigned long arg)
if (copy_in_user(&cioc->frame.hdr.cmd_status,
&ioc->frame.hdr.cmd_status, sizeof(u8))) {
- printk(KERN_DEBUG "megasas: error copy_in_user cmd_status\n");
+ pr_debug("megasas: error copy_in_user cmd_status\n");
return -EFAULT;
}
return error;
@@ -6455,7 +6455,7 @@ megasas_sysfs_set_dbg_lvl(struct device_driver *dd, const char *buf, size_t coun
int retval = count;
if (sscanf(buf, "%u", &megasas_dbg_lvl) < 1) {
- printk(KERN_ERR "megasas: could not set dbg_lvl\n");
+ pr_err("megasas: could not set dbg_lvl\n");
retval = -EINVAL;
}
return retval;
@@ -6480,7 +6480,7 @@ megasas_aen_polling(struct work_struct *work)
int error;
if (!instance) {
- printk(KERN_ERR "invalid instance!\n");
+ pr_err("invalid instance!\n");
kfree(ev);
return;
}
@@ -6740,7 +6740,7 @@ static int __init megasas_init(void)
rval = register_chrdev(0, "megaraid_sas_ioctl", &megasas_mgmt_fops);
if (rval < 0) {
- printk(KERN_DEBUG "megasas: failed to open device node\n");
+ pr_debug("megasas: failed to open device node\n");
return rval;
}
@@ -6752,7 +6752,7 @@ static int __init megasas_init(void)
rval = pci_register_driver(&megasas_pci_driver);
if (rval) {
- printk(KERN_DEBUG "megasas: PCI hotplug registration failed \n");
+ pr_debug("megasas: PCI hotplug registration failed \n");
goto err_pcidrv;
}
--
1.9.0
next prev parent reply other threads:[~2015-10-27 8:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 8:26 [PATCH 0/3] megaraid_sas: copule of fixes Weidong Wang
2015-10-27 8:26 ` [PATCH 1/3] megaraid_sas: Convert dev_printk to dev_<level> Weidong Wang
2015-10-27 10:25 ` Johannes Thumshirn
2015-10-27 10:33 ` Kashyap Desai
2015-10-28 2:31 ` Weidong Wang
2015-10-27 19:35 ` Joe Perches
2015-10-28 1:59 ` Weidong Wang
2015-10-27 8:26 ` Weidong Wang [this message]
2015-10-27 10:25 ` [PATCH 2/3] megaraid_sas: Convert printk to printk_<level> Johannes Thumshirn
2015-10-27 19:32 ` Joe Perches
2015-10-27 8:26 ` [PATCH 3/3] megaraid_sas: return -ENOMEM when create DMA pool for cmd frames failed Weidong Wang
2015-10-27 10:17 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445934375-17784-3-git-send-email-wangweidong1@huawei.com \
--to=wangweidong1@huawei.com \
--cc=JBottomley@odin.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux.pdl@avagotech.com \
--cc=sumit.saxena@avagotech.com \
--cc=uday.lingala@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).