From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c <linux-i2c@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v2 9/9] eeprom: at24: readability tweaks
Date: Tue, 27 Oct 2015 12:43:53 +0100 [thread overview]
Message-ID: <1445946233-6071-10-git-send-email-bgolaszewski@baylibre.com> (raw)
In-Reply-To: <1445946233-6071-1-git-send-email-bgolaszewski@baylibre.com>
Move the macro definitions above the struct definitions and add some
tabs for better readability.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/misc/eeprom/at24.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 65f1479..d624311 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -52,6 +52,14 @@
* which won't work on pure SMBus systems.
*/
+#define AT24_SIZE_BYTELEN 5
+#define AT24_SIZE_FLAGS 8
+
+#define AT24_BITMASK(x) (BIT(x) - 1)
+
+#define AT24CS_SERIAL_SIZE 16
+#define AT24CS_SERIAL_ADDR(addr) (addr + 0x08)
+
struct at24_data {
struct at24_platform_data chip;
struct memory_accessor macc;
@@ -98,14 +106,6 @@ static unsigned write_timeout = 25;
module_param(write_timeout, uint, 0);
MODULE_PARM_DESC(write_timeout, "Time (in ms) to try writes (default 25)");
-#define AT24_SIZE_BYTELEN 5
-#define AT24_SIZE_FLAGS 8
-
-#define AT24_BITMASK(x) (BIT(x) - 1)
-
-#define AT24CS_SERIAL_SIZE 16
-#define AT24CS_SERIAL_ADDR(addr) (addr + 0x08)
-
/* create non-zero magic value for given eeprom parameters */
#define AT24_DEVICE_MAGIC(_len, _flags) \
((1 << AT24_SIZE_FLAGS | (_flags)) \
--
2.1.4
prev parent reply other threads:[~2015-10-27 11:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 11:43 [PATCH v2 0/9] eeprom: at24: at24cs series serial number read Bartosz Golaszewski
2015-10-27 11:43 ` [PATCH v2 1/9] eeprom: at24: platform_data: use BIT() macro Bartosz Golaszewski
2015-10-27 11:43 ` [PATCH v2 2/9] eeprom: at24: new flag in platform_data Bartosz Golaszewski
2015-10-27 11:43 ` [PATCH v2 3/9] eeprom: at24: tie up an additional address for at24cs series Bartosz Golaszewski
2015-10-27 11:43 ` [PATCH v2 4/9] eeprom: at24: support reading of the serial number Bartosz Golaszewski
2015-10-27 11:43 ` [PATCH v2 5/9] eeprom: at24: export the serial number through sysfs Bartosz Golaszewski
2015-10-27 11:43 ` [PATCH v2 6/9] eeprom: at24: improve the device_id table readability Bartosz Golaszewski
2015-10-27 11:43 ` [PATCH v2 7/9] eeprom: at24: add the at24cs series to the list of supported devices Bartosz Golaszewski
2015-10-27 11:43 ` [PATCH v2 8/9] eeprom: at24: remove a reduntant if Bartosz Golaszewski
2015-10-27 11:43 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445946233-6071-10-git-send-email-bgolaszewski@baylibre.com \
--to=bgolaszewski@baylibre.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).