From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965298AbbJ0TSc (ORCPT ); Tue, 27 Oct 2015 15:18:32 -0400 Received: from smtprelay0145.hostedemail.com ([216.40.44.145]:53924 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S964927AbbJ0TSa (ORCPT ); Tue, 27 Oct 2015 15:18:30 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3867:3870:3872:3874:4321:5007:6261:10004:10400:10848:11026:11232:11473:11658:11914:12043:12438:12517:12519:12740:13019:13069:13095:13255:13311:13357:21080:21212,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: soap09_49eb94b8a1719 X-Filterd-Recvd-Size: 1958 Message-ID: <1445973507.2757.40.camel@perches.com> Subject: Re: [PATCH 2/3] iio: light: lm3533-als: Print error message on invalid resistance From: Joe Perches To: Bjorn Andersson Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Johan Hovold , Peter Meerwald , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Tue, 27 Oct 2015 12:18:27 -0700 In-Reply-To: <1445796586-28683-2-git-send-email-bjorn.andersson@sonymobile.com> References: <1445796586-28683-1-git-send-email-bjorn.andersson@sonymobile.com> <1445796586-28683-2-git-send-email-bjorn.andersson@sonymobile.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-10-25 at 11:09 -0700, Bjorn Andersson wrote: > Print an error message to indicate that invalid configuration data was > provided in the platform_data, rather than just aborting initialization. Perhaps it'd be nicer to show the 3 values. > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c [] > @@ -743,8 +743,10 @@ static int lm3533_als_set_resistor(struct lm3533_als *als, u8 val) > { > int ret; > > - if (val < LM3533_ALS_RESISTOR_MIN || val > LM3533_ALS_RESISTOR_MAX) > + if (val < LM3533_ALS_RESISTOR_MIN || val > LM3533_ALS_RESISTOR_MAX) { > + dev_err(&als->pdev->dev, "invalid resistor value\n"); > return -EINVAL; > + }; > > ret = lm3533_write(als->lm3533, LM3533_REG_ALS_RESISTOR_SELECT, val); > if (ret) {