From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755850AbbJ1SxN (ORCPT ); Wed, 28 Oct 2015 14:53:13 -0400 Received: from smtprelay0191.hostedemail.com ([216.40.44.191]:55939 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752375AbbJ1SxK (ORCPT ); Wed, 28 Oct 2015 14:53:10 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:2899:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6119:6261:10004:10400:10848:11026:11232:11473:11658:11914:12043:12438:12517:12519:12740:13069:13095:13255:13311:13357:13972:21080:21212:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: tramp70_385f544f12739 X-Filterd-Recvd-Size: 2721 Message-ID: <1446058386.2757.145.camel@perches.com> Subject: Re: [PATCH 2/3] iio: light: lm3533-als: Print error message on invalid resistance From: Joe Perches To: Bjorn Andersson Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Johan Hovold , Peter Meerwald , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Date: Wed, 28 Oct 2015 11:53:06 -0700 In-Reply-To: <20151028183750.GB24668@usrtlx11787.corpusers.net> References: <1445796586-28683-1-git-send-email-bjorn.andersson@sonymobile.com> <1445796586-28683-2-git-send-email-bjorn.andersson@sonymobile.com> <1445973507.2757.40.camel@perches.com> <20151028183750.GB24668@usrtlx11787.corpusers.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-10-28 at 11:37 -0700, Bjorn Andersson wrote: > On Tue 27 Oct 12:18 PDT 2015, Joe Perches wrote: > > On Sun, 2015-10-25 at 11:09 -0700, Bjorn Andersson wrote: > > > Print an error message to indicate that invalid configuration data was > > > provided in the platform_data, rather than just aborting initialization. > > Perhaps it'd be nicer to show the 3 values. > I do agree that it would be helpful to hint the developer about the > expected range. The problem I see here though is that, in the case of > devicetree we've now moved from resistance to a register value. [] > So would you be okay with not improving the message? Or would you like > me to just move it into the code in patch 1 - and leave the > platform_data case as it was (with a silent failure)? [] > > > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c > > [] > > > @@ -743,8 +743,10 @@ static int lm3533_als_set_resistor(struct lm3533_als *als, u8 val) > > > { > > > int ret; > > > > > > - if (val < LM3533_ALS_RESISTOR_MIN || val > LM3533_ALS_RESISTOR_MAX) > > > + if (val < LM3533_ALS_RESISTOR_MIN || val > LM3533_ALS_RESISTOR_MAX) { > > > + dev_err(&als->pdev->dev, "invalid resistor value\n"); > > > return -EINVAL; > > > + }; > > > What I suggested was just a trivial proposal. Whatever you do is fine with me.