From: James Simmons <jsimmons@infradead.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
lustre-devel@lists.lustre.org,
James Simmons <jsimmons@infradead.org>
Subject: [PATCH v2 4/7] staging: lustre: use proper comment blocks for libcfs_hash.h
Date: Mon, 2 Nov 2015 12:22:10 -0500 [thread overview]
Message-ID: <1446484933-23571-5-git-send-email-jsimmons@infradead.org> (raw)
In-Reply-To: <1446484933-23571-1-git-send-email-jsimmons@infradead.org>
The script checkpatch.pl reported problems with the style of
the comment blocks. This patch resolves those problems.
Signed-off-by: James Simmons <jsimmons@infradead.org>
---
.../lustre/include/linux/libcfs/libcfs_hash.h | 21 +++++++++++++------
1 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_hash.h b/drivers/staging/lustre/include/linux/libcfs/libcfs_hash.h
index 2e0c892..87dee16 100644
--- a/drivers/staging/lustre/include/linux/libcfs/libcfs_hash.h
+++ b/drivers/staging/lustre/include/linux/libcfs/libcfs_hash.h
@@ -61,8 +61,10 @@
/** disable debug */
#define CFS_HASH_DEBUG_NONE 0
-/** record hash depth and output to console when it's too deep,
- * computing overhead is low but consume more memory */
+/*
+ * record hash depth and output to console when it's too deep,
+ * computing overhead is low but consume more memory
+ */
#define CFS_HASH_DEBUG_1 1
/** expensive, check key validation */
#define CFS_HASH_DEBUG_2 2
@@ -158,7 +160,8 @@ enum cfs_hash_tag {
*/
CFS_HASH_NBLK_CHANGE = 1 << 13,
/** NB, we typed hs_flags as __u16, please change it
- * if you need to extend >=16 flags */
+ * if you need to extend >=16 flags
+ */
};
/** most used attributes */
@@ -205,8 +208,10 @@ enum cfs_hash_tag {
*/
struct cfs_hash {
- /** serialize with rehash, or serialize all operations if
- * the hash-table has CFS_HASH_NO_BKTLOCK */
+ /*
+ * serialize with rehash, or serialize all operations if
+ * the hash-table has CFS_HASH_NO_BKTLOCK
+ */
union cfs_hash_lock hs_lock;
/** hash operations */
struct cfs_hash_ops *hs_ops;
@@ -373,9 +378,11 @@ cfs_hash_with_add_tail(struct cfs_hash *hs)
static inline int
cfs_hash_with_no_itemref(struct cfs_hash *hs)
{
- /* hash-table doesn't keep refcount on item,
+ /*
+ * hash-table doesn't keep refcount on item,
* item can't be removed from hash unless it's
- * ZERO refcount */
+ * ZERO refcount.
+ */
return (hs->hs_flags & CFS_HASH_NO_ITEMREF) != 0;
}
--
1.7.1
next prev parent reply other threads:[~2015-11-02 17:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 17:22 [PATCH v2 0/7] staging: lustre: second series for libcfs hash code cleanup James Simmons
2015-11-02 17:22 ` [PATCH v2 1/7] staging: lustre: remove white space in libcfs_hash.h James Simmons
2015-11-04 3:46 ` Greg Kroah-Hartman
2015-11-04 11:41 ` Sudip Mukherjee
2015-11-04 15:07 ` [lustre-devel] " Simmons, James A.
2015-11-04 17:20 ` Greg Kroah-Hartman
2015-11-04 15:05 ` Simmons, James A.
2015-11-02 17:22 ` [PATCH v2 2/7] staging: lustre: remove obsolete comment " James Simmons
2015-11-02 17:22 ` [PATCH v2 3/7] staging: lustre: move linux hash.h header to start of libcfs_hash.h James Simmons
2015-11-02 17:22 ` James Simmons [this message]
2015-11-02 17:22 ` [PATCH v2 5/7] staging: lustre: handle NULL comparisons correctly for libcfs_hash.h James Simmons
2015-11-02 17:22 ` [PATCH v2 6/7] staging: lustre: remove white space in hash.c James Simmons
2015-11-02 17:22 ` [PATCH v2 7/7] staging: lustre: place linux header first " James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446484933-23571-5-git-send-email-jsimmons@infradead.org \
--to=jsimmons@infradead.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).