From: ville.syrjala@linux.intel.com
To: Len Brown <len.brown@intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: [PATCH] intel_idle: Don't use on Lenovo Ideapad S10-3t
Date: Mon, 2 Nov 2015 23:22:40 +0200 [thread overview]
Message-ID: <1446499360-31984-1-git-send-email-ville.syrjala@linux.intel.com> (raw)
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Lenovo Ideapad S10-3t hangs coming out of S3 with intel_idle.
The two workaround that seem to help are "intel_idle.max_cstate=0"
or "nohz=off highres=off".
At a first glance quirk_tigerpoint_bm_sts() seemed promising, but
even when moved to early_resume it didn't do anything.
I have no idea what's wrong here, so let's just disable intel_idle
for these machines using a DMI match.
Cc: Len Brown <len.brown@intel.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
If anyone has any better ideas, I can try out some patches.
drivers/idle/intel_idle.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index cd4510a..c4a6888 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -61,6 +61,7 @@
#include <linux/notifier.h>
#include <linux/cpu.h>
#include <linux/module.h>
+#include <linux/dmi.h>
#include <asm/cpu_device_id.h>
#include <asm/mwait.h>
#include <asm/msr.h>
@@ -925,6 +926,25 @@ static const struct x86_cpu_id intel_idle_ids[] __initconst = {
};
MODULE_DEVICE_TABLE(x86cpu, intel_idle_ids);
+static int intel_idle_disable_callback(const struct dmi_system_id *id)
+{
+ pr_debug(PREFIX "problematic system (%s), disabling\n", id->ident);
+ return 1;
+}
+
+static const struct dmi_system_id intel_idle_disable_dmi[] = {
+ {
+ /* Lenovo Ideapad S10-3t, hangs coming out of S3 */
+ .callback = intel_idle_disable_callback,
+ .ident = "Lenovo Ideapad S10-3t",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Ideapad S10-3t"),
+ },
+ },
+ {}
+};
+
/*
* intel_idle_probe()
*/
@@ -957,6 +977,9 @@ static int __init intel_idle_probe(void)
!mwait_substates)
return -ENODEV;
+ if (dmi_check_system(intel_idle_disable_dmi))
+ return -ENODEV;
+
pr_debug(PREFIX "MWAIT substates: 0x%x\n", mwait_substates);
icpu = (const struct idle_cpu *)id->driver_data;
--
2.4.10
next reply other threads:[~2015-11-02 21:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 21:22 ville.syrjala [this message]
2015-11-03 3:04 ` [PATCH] intel_idle: Don't use on Lenovo Ideapad S10-3t Brown, Len
2015-11-04 16:21 ` Ville Syrjälä
2015-11-08 19:20 ` Henrique de Moraes Holschuh
2015-11-09 10:28 ` Ville Syrjälä
2016-10-27 18:10 ` ville.syrjala
2016-10-27 22:22 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446499360-31984-1-git-send-email-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).