From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965702AbbKDQH5 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Nov 2015 11:07:57 -0500
Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:24052 "EHLO
	mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965550AbbKDQH4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Nov 2015 11:07:56 -0500
X-IronPort-AV: E=Sophos;i="5.20,243,1444719600"; 
   d="scan'208";a="79470545"
Subject: Re: [PATCH] bnxt_en: add VXLAN dependency
From: Michael Chan <mchan@broadcom.com>
To: Arnd Bergmann <arnd@arndb.de>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <davem@davemloft.net>,
        Eddie Wai <eddie.wai@broadcom.com>,
        Jeffrey Huang <huangjw@broadcom.com>,
        "Prashant Sreedharan" <prashant@broadcom.com>
In-Reply-To: <10667823.xAtO4QOJMM@wuerfel>
References: <10667823.xAtO4QOJMM@wuerfel>
Content-Type: text/plain; charset="cp1252"
Date: Wed, 4 Nov 2015 08:07:53 -0800
Message-ID: <1446653274.3700.5.camel@LTIRV-MCHAN1.corp.ad.broadcom.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2015-11-04 at 16:00 +0100, Arnd Bergmann wrote: 
> VXLAN may be a loadable module, and this driver cannot be built-in
> in that case, or we get a link error:
> 
> drivers/built-in.o: In function `__bnxt_open_nic':
> drivers/net/ethernet/broadcom/bnxt/bnxt.c:4581: undefined reference to `vxlan_get_rx_port'
> 
> This adds a Kconfig dependency that ensures that either VXLAN is
> disabled (which the driver handles correctly), or we depend on
> VXLAN itself and disallow built-in compilation when VXLAN is
> a module.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks.
Acked-by: Michael Chan <mchan@broadcom.com>

> Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
> 
> diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
> index 67a7d520d9f5..8550df189ceb 100644
> --- a/drivers/net/ethernet/broadcom/Kconfig
> +++ b/drivers/net/ethernet/broadcom/Kconfig
> @@ -173,6 +173,7 @@ config SYSTEMPORT
>  config BNXT
>  	tristate "Broadcom NetXtreme-C/E support"
>  	depends on PCI
> +	depends on VXLAN || VXLAN=n
>  	select FW_LOADER
>  	select LIBCRC32C
>  	---help---
>