From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752368AbbKJKPP (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 Nov 2015 05:15:15 -0500
Received: from mailout4.w1.samsung.com ([210.118.77.14]:56217 "EHLO
	mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752226AbbKJKPI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 Nov 2015 05:15:08 -0500
X-AuditID: cbfec7f5-f794b6d000001495-0d-5641c3a8c5b8
Message-id: <1447150502.2216.15.camel@samsung.com>
Subject: Re: [PATCH v4 03/11] lsm: add file opener's cred to a setprocattr
 arguments
From: Lukasz Pawelczyk <l.pawelczyk@samsung.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: "David S. Miller" <davem@davemloft.net>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@kernel.org>, Calvin Owens <calvinowens@fb.com>,
        Casey Schaufler <casey@schaufler-ca.com>,
        David Howells <dhowells@redhat.com>,
        Eric Dumazet <edumazet@google.com>, Eric Paris <eparis@parisplace.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        James Morris <james.l.morris@oracle.com>, Jann Horn <jann@thejh.net>,
        Jiri Slaby <jslaby@suse.com>, Joe Perches <joe@perches.com>,
        John Johansen <john.johansen@canonical.com>,
        Jonathan Corbet <corbet@lwn.net>, Kees Cook <keescook@chromium.org>,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
        NeilBrown <neilb@suse.de>, Paul Moore <paul@paul-moore.com>,
        Serge Hallyn <serge.hallyn@canonical.com>,
        Stephen Smalley <sds@tycho.nsa.gov>, Tejun Heo <tj@kernel.org>,
        Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
        containers@lists.linuxfoundation.org, linux-doc@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov,
        Lukasz Pawelczyk <havner@gmail.com>
Date: Tue, 10 Nov 2015 11:15:02 +0100
In-reply-to: <20151110041625.GA19875@ZenIV.linux.org.uk>
References: <1444826525-9758-1-git-send-email-l.pawelczyk@samsung.com>
 <1444826525-9758-4-git-send-email-l.pawelczyk@samsung.com>
 <20151110041625.GA19875@ZenIV.linux.org.uk>
Content-type: text/plain; charset=UTF-8
X-Mailer: Evolution 3.16.5 (3.16.5-3.fc22)
MIME-version: 1.0
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA02SfyzUcRjH+9z38/3enXXrG8ontVmn1mZC6o+Hteif+q6tFjMta+niu2M5
	7A7hn07kxxGKokP5kZGYQuRkieU3p1+mkubHUZlflR9zi3C1+e/9PO/X+3mePx4RZZ5JW4sC
	g8N4ZbAsSMqY4a6Vtv6DpS3HvZ2eqfdCVswpyK0sZ6Ay3waGapcZ6FopFcJYUwKCXH0chunr
	RgyrtXFCMLSOCCFpuIeC2KJKBlYn7SF11BPaxw005HwdxdD++wYDmU9mBdCdrICC+IcYXjR2
	YHiny2VgNmWEAb2ugobH45HQ+ECN4fPtLAw5cdM0tDQUUZAx1oyhN2YCg76vVwjLJa8R6P+0
	0e5STqu+yXA56jeYq3n0UcDdip0WcvXaL0Iuvyqc6284z9VXlAm4qrIkhmvPNmLuZV65kDMu
	ZSCuKDWD5uYMn9aSaWt8z7zP2d0+Zkf9+aDACF7peOySWUBm8iIOvUtHzows0mq0QGmQWETY
	I2QwZRmb9E7SN1TJaJCZyJwtRsQ4rEGm4hcimvff6XVKwjqTpMmBjYQF6026dTrhumZYJ7LY
	17gx1ZLdTwY7uwXrYYodF5OSRN2GgdeMnMfZaF2LWSBphT8Epg1PEUlVx29MotgD5Pb9wn/3
	2ZFXEwaBafN2spQxhE2MDakun6LSEavdFNFuwrSbsHxElaEdfLhfqOqyXOHsoJIpVOHBcge/
	EEUVMv3K/HNU3OrajFgRkm6VpC+4e5vTsghVlKIZEREltZS4fVtrSfxlUdG8MsRXGR7Eq5rR
	bhGWWknu6Wa8zFm5LIy/wvOhvPK/KxCJrdUoD44O+otdBie6puZ2GeZsT9cZoj9cKPDYt03q
	9chdr/ue0uTY7lJnLIIG1y3dHo1zPdfcHJN1b70CbnrMGK1Cno6dPHxn+IH8TmumRX3nwNXR
	i4VhE8y3d3aeeTXOHUNnftprlIn+PiUnzh3Ij0217az22VO4MzApQM6l+HIJl2ykWBUgO2RH
	KVWyv60eR6onAwAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On wto, 2015-11-10 at 04:16 +0000, Al Viro wrote:
> On Wed, Oct 14, 2015 at 02:41:57PM +0200, Lukasz Pawelczyk wrote:
> >  	int (*getprocattr)(struct task_struct *p, char *name, char
> > **value);
> > -	int (*setprocattr)(struct task_struct *p, char *name, void
> > *value,
> > -				size_t size);
> > +	int (*setprocattr)(struct task_struct *p, const struct
> > cred *f_cred,
> > +			   char *name, void *value, size_t size);
> 
> *grumble*
> 
> Why the hell is that thing taking char *name - not even const char *?

I was wondering that myself. But as this is unrelated I decided not to
change it. Do you want me to while at it?




--