From: Pankaj Dubey <pankaj.dubey@samsung.com>
To: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Cc: kgene.kim@samsung.com, k.kozlowski@samsung.com,
thomas.ab@samsung.com, amitdanielk@gmail.com, olof@lixom.net,
khilman@linaro.org, arnd@arndb.de,
Pankaj Dubey <pankaj.dubey@samsung.com>
Subject: [PATCH v6 8/9] ARM: EXYNOS: rearrange static and non-static functions of PMU driver
Date: Tue, 17 Nov 2015 11:35:50 +0530 [thread overview]
Message-ID: <1447740351-14246-9-git-send-email-pankaj.dubey@samsung.com> (raw)
In-Reply-To: <1447740351-14246-1-git-send-email-pankaj.dubey@samsung.com>
This patch moves exynos_sys_powerdown_conf function above all
static functions, to avoid confusion causing due to mixing of
static-nonstatic-static functions and to improve readability of this
driver.
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
arch/arm/mach-exynos/pmu.c | 34 +++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos/pmu.c
index 01cb649..a7741d4 100644
--- a/arch/arm/mach-exynos/pmu.c
+++ b/arch/arm/mach-exynos/pmu.c
@@ -39,23 +39,6 @@ u32 pmu_raw_readl(u32 offset)
return readl_relaxed(pmu_base_addr + offset);
}
-static void exynos_power_off(void)
-{
- unsigned int tmp;
-
- pr_info("Power down.\n");
- tmp = pmu_raw_readl(EXYNOS_PS_HOLD_CONTROL);
- tmp ^= (1 << 8);
- pmu_raw_writel(tmp, EXYNOS_PS_HOLD_CONTROL);
-
- /* Wait a little so we don't give a false warning below */
- mdelay(100);
-
- pr_err("Power down failed, please power off system manually.\n");
- while (1)
- ;
-}
-
void exynos_sys_powerdown_conf(enum sys_powerdown mode)
{
unsigned int i;
@@ -85,6 +68,23 @@ void exynos_sys_powerdown_conf(enum sys_powerdown mode)
}
}
+static void exynos_power_off(void)
+{
+ unsigned int tmp;
+
+ pr_info("Power down.\n");
+ tmp = pmu_raw_readl(EXYNOS_PS_HOLD_CONTROL);
+ tmp ^= (1 << 8);
+ pmu_raw_writel(tmp, EXYNOS_PS_HOLD_CONTROL);
+
+ /* Wait a little so we don't give a false warning below */
+ mdelay(100);
+
+ pr_err("Power down failed, please power off system manually.\n");
+ while (1)
+ ;
+}
+
static int pmu_restart_notify(struct notifier_block *this,
unsigned long code, void *unused)
{
--
2.4.5
next prev parent reply other threads:[~2015-11-17 6:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 6:05 [PATCH v6 0/9] samsung: pmu: split up SoC specific PMU data Pankaj Dubey
2015-11-17 6:05 ` [PATCH v6 1/9] ARM: EXYNOS: removing redundant code from regs-pmu.h Pankaj Dubey
2015-11-17 6:05 ` [PATCH v6 2/9] ARM: EXYNOS: Fix potential NULL pointer access in exynos_sys_powerdown_conf Pankaj Dubey
2015-11-17 6:05 ` [PATCH v6 3/9] ARM: EXYNOS: Move pmu specific headers under "linux/soc/samsung" Pankaj Dubey
2015-11-17 6:05 ` [PATCH v6 4/9] ARM: EXYNOS: split up exynos3250 SoC specific PMU data Pankaj Dubey
2015-11-17 6:05 ` [PATCH v6 5/9] ARM: EXYNOS: split up exynos4 " Pankaj Dubey
2015-11-17 6:05 ` [PATCH v6 6/9] ARM: EXYNOS: split up exynos5250 " Pankaj Dubey
2015-11-17 6:05 ` [PATCH v6 7/9] ARM: EXYNOS: split up exynos5420 " Pankaj Dubey
2015-11-17 6:05 ` Pankaj Dubey [this message]
2015-11-20 4:46 ` [PATCH v6 8/9] ARM: EXYNOS: rearrange static and non-static functions of PMU driver Manish Badarkhe
2015-11-20 5:10 ` Krzysztof Kozlowski
2015-11-17 6:05 ` [PATCH v6 9/9] drivers: soc: Add support for Exynos " Pankaj Dubey
2015-11-17 6:16 ` Krzysztof Kozlowski
2015-11-17 6:11 ` [PATCH v6 0/9] samsung: pmu: split up SoC specific PMU data Krzysztof Kozlowski
2015-12-17 5:31 ` Krzysztof Kozlowski
2015-12-18 3:44 ` pankaj.dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447740351-14246-9-git-send-email-pankaj.dubey@samsung.com \
--to=pankaj.dubey@samsung.com \
--cc=amitdanielk@gmail.com \
--cc=arnd@arndb.de \
--cc=k.kozlowski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).