From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757067AbbLAWGW (ORCPT ); Tue, 1 Dec 2015 17:06:22 -0500 Received: from outbound.smtp.vt.edu ([198.82.183.121]:38369 "EHLO omr2.cc.vt.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756313AbbLAWGU (ORCPT ); Tue, 1 Dec 2015 17:06:20 -0500 From: Valdis Kletnieks To: Oleg Drokin , Andreas Dilger Cc: lustre-devel@lists.lustre.org, linux-kernel@vger.kernel.org, Valdis Kletnieks Subject: [lustre cleanups 6/6] Nuke another unsigned >= 0 assert Date: Tue, 1 Dec 2015 17:05:19 -0500 Message-Id: <1449007519-73974-7-git-send-email-Valdis.Kletnieks@vt.edu> X-Mailer: git-send-email 2.6.3 In-Reply-To: <1449007519-73974-1-git-send-email-Valdis.Kletnieks@vt.edu> References: <1449007519-73974-1-git-send-email-Valdis.Kletnieks@vt.edu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Clean up another case of the compiler remininding the programmer they are an idiot: drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c:308:34: warning: comparison of u nsigned expression >= 0 is always true [-Wtype-limits] LASSERT(page_pools.epp_waitqlen >= 0); Just lose the assert, and save a page of compiler spew. Signed-off-by: Valdis Kletnieks --- diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c b/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c index cd8a9987f7ac..1f326673f089 100644 --- a/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c +++ b/drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c @@ -304,7 +304,6 @@ static unsigned long enc_pools_cleanup(struct page ***pools, int npools) static inline void enc_pools_wakeup(void) { assert_spin_locked(&page_pools.epp_lock); - LASSERT(page_pools.epp_waitqlen >= 0); if (unlikely(page_pools.epp_waitqlen)) { LASSERT(waitqueue_active(&page_pools.epp_waitq)); -- 2.6.3