From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932879AbbLBQ7o (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Dec 2015 11:59:44 -0500
Received: from mail-pa0-f50.google.com ([209.85.220.50]:36730 "EHLO
	mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751225AbbLBQ7n (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Dec 2015 11:59:43 -0500
Message-ID: <1449075580.6379.1.camel@edumazet-glaptop2.roam.corp.google.com>
Subject: Re: [PATCH 3/6] net: thunderx: Increase transmit queue length
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Sunil Kovvuri <sunil.kovvuri@gmail.com>
Cc: David Miller <davem@davemloft.net>, Pavel Fedin <p.fedin@samsung.com>,
        Linux Netdev List <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        LAKML <linux-arm-kernel@lists.infradead.org>,
        Sunil Goutham <Sunil.Goutham@caviumnetworks.com>,
        Sunil Goutham <sgoutham@cavium.com>
Date: Wed, 02 Dec 2015 08:59:40 -0800
In-Reply-To: <CA+sq2CfWC0kcxKj1kqMEU3+y9aovqDdpn2G72n5ON9T3Hzew_w@mail.gmail.com>
References: <01d101d12c46$2de43b40$89acb1c0$@samsung.com>
	 <1448983985.25582.35.camel@edumazet-glaptop2.roam.corp.google.com>
	 <CA+sq2Ce9oH-kCDO8hK_wX+ZZdXyyBuT4V2bt5Ab+2=pEX+BO+w@mail.gmail.com>
	 <20151201.143047.82022857078130793.davem@davemloft.net>
	 <CA+sq2CduMnsh_R9zTRMjWT=F5=9U3si-5nO6-gFvGCO9czkDdA@mail.gmail.com>
	 <1449062733.32764.53.camel@edumazet-glaptop2.roam.corp.google.com>
	 <CA+sq2CfWC0kcxKj1kqMEU3+y9aovqDdpn2G72n5ON9T3Hzew_w@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2015-12-02 at 22:20 +0530, Sunil Kovvuri wrote:
> >
> > If the performance increase is 4 %, then surely using twice more memory
> > is not worth it.
> I haven't mentioned anywhere that i am seeing 4% increase in performance.

Yes, this is the complain I made :

No numbers, just a patch increasing ring size by a 100% factor !

I really hope you'll have very convincing numbers, especially if your
driver does not implement BQL.