From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org, Vinod Koul <vinod.koul@intel.com>,
dmaengine@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification
Date: Fri, 4 Dec 2015 23:49:17 +0200 [thread overview]
Message-ID: <1449265765-9393-2-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1449265765-9393-1-git-send-email-andriy.shevchenko@linux.intel.com>
The users of BUS_NOTIFY_BIND_DRIVER have no chance to do any cleanup in case of
a probe failure. In the result there might be problems, such as some resources
that had been allocated will continue to be allocated and therefore lead to a
resource leak.
Introduce a new notification to inform the subscriber that ->probe() failed. Do
the same in case of failed device_bind_driver() call.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/base/dd.c | 10 ++++++++--
include/linux/device.h | 1 +
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 8d4eb4d..7399be7 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -299,6 +299,9 @@ int device_bind_driver(struct device *dev)
ret = driver_sysfs_add(dev);
if (!ret)
driver_bound(dev);
+ else if (dev->bus)
+ blocking_notifier_call_chain(&dev->bus->p->bus_notifier,
+ BUS_NOTIFY_DRIVER_NOT_BOUND, dev);
return ret;
}
EXPORT_SYMBOL_GPL(device_bind_driver);
@@ -332,7 +335,7 @@ static int really_probe(struct device *dev, struct device_driver *drv)
/* If using pinctrl, bind pins now before probing */
ret = pinctrl_bind_pins(dev);
if (ret)
- goto probe_failed;
+ goto pinctrl_bind_failed;
if (driver_sysfs_add(dev)) {
printk(KERN_ERR "%s: driver_sysfs_add(%s) failed\n",
@@ -376,6 +379,10 @@ static int really_probe(struct device *dev, struct device_driver *drv)
goto done;
probe_failed:
+ if (dev->bus)
+ blocking_notifier_call_chain(&dev->bus->p->bus_notifier,
+ BUS_NOTIFY_DRIVER_NOT_BOUND, dev);
+pinctrl_bind_failed:
devres_release_all(dev);
driver_sysfs_remove(dev);
dev->driver = NULL;
@@ -749,7 +756,6 @@ static void __device_release_driver(struct device *dev)
blocking_notifier_call_chain(&dev->bus->p->bus_notifier,
BUS_NOTIFY_UNBOUND_DRIVER,
dev);
-
}
}
diff --git a/include/linux/device.h b/include/linux/device.h
index b8f411b..f627ba2 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -191,6 +191,7 @@ extern int bus_unregister_notifier(struct bus_type *bus,
unbound */
#define BUS_NOTIFY_UNBOUND_DRIVER 0x00000007 /* driver is unbound
from the device */
+#define BUS_NOTIFY_DRIVER_NOT_BOUND 0x00000008 /* driver fails to be bound */
extern struct kset *bus_get_kset(struct bus_type *bus);
extern struct klist *bus_get_device_klist(struct bus_type *bus);
--
2.6.2
next prev parent reply other threads:[~2015-12-04 21:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 21:49 [PATCH v3 0/9] ACPI / LPSS: fix system hangup on BYT/BSW/CHT Andy Shevchenko
2015-12-04 21:49 ` Andy Shevchenko [this message]
2015-12-05 16:14 ` [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification Greg Kroah-Hartman
2015-12-05 16:24 ` Andy Shevchenko
2015-12-05 16:36 ` Greg Kroah-Hartman
2015-12-07 1:31 ` Rafael J. Wysocki
2015-12-07 10:57 ` Andy Shevchenko
2015-12-07 22:59 ` Rafael J. Wysocki
2015-12-08 13:32 ` Thomas Gleixner
2015-12-08 14:05 ` Rafael J. Wysocki
2015-12-08 13:50 ` Andy Shevchenko
2015-12-09 1:20 ` Rafael J. Wysocki
2015-12-09 1:09 ` Andy Shevchenko
2015-12-04 21:49 ` [PATCH v3 2/9] Revert "ACPI / LPSS: allow to use specific PM domain during ->probe()" Andy Shevchenko
2015-12-04 21:49 ` [PATCH v3 3/9] ACPI / LPSS: allow to use specific PM domain during ->probe() Andy Shevchenko
2015-12-04 21:49 ` [PATCH v3 4/9] ACPI / LPSS: power on when probe() and otherwise when remove() Andy Shevchenko
2015-12-04 21:49 ` [PATCH v3 5/9] ACPI / LPSS: do delay for all LPSS devices when D3->D0 Andy Shevchenko
2015-12-04 21:49 ` [PATCH v3 6/9] ACPI / LPSS: override power state for LPSS DMA device Andy Shevchenko
2015-12-04 21:49 ` [PATCH v3 7/9] dmaengine: dw: platform: power on device on shutdown Andy Shevchenko
2015-12-08 17:25 ` Vinod Koul
2015-12-04 21:49 ` [PATCH v3 8/9] dmaengine: dw: return immediately from IRQ when DMA isn't in use Andy Shevchenko
2015-12-08 17:25 ` Vinod Koul
2015-12-04 21:49 ` [PATCH v3 9/9] Revert "dmaengine: dw: platform: provide platform data for Intel" Andy Shevchenko
2015-12-08 17:27 ` Vinod Koul
2015-12-04 23:07 ` [PATCH v3 0/9] ACPI / LPSS: fix system hangup on BYT/BSW/CHT Rafael J. Wysocki
2015-12-04 23:15 ` Andy Shevchenko
2015-12-05 0:07 ` Rafael J. Wysocki
2015-12-08 4:39 ` Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449265765-9393-2-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).