From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933295AbbLHQQd (ORCPT ); Tue, 8 Dec 2015 11:16:33 -0500 Received: from smtprelay0047.hostedemail.com ([216.40.44.47]:51470 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756960AbbLHQQb (ORCPT ); Tue, 8 Dec 2015 11:16:31 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3872:4321:5007:6261:7903:10004:10400:10848:11026:11232:11658:11914:12043:12296:12438:12517:12519:12740:13069:13311:13357:13894:14659:21080:30003:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: club25_3860a0e494f02 X-Filterd-Recvd-Size: 1689 Message-ID: <1449591386.3315.2.camel@perches.com> Subject: Re: [PATCH v2] of/address: replace printk() with pr_debug() / pr_err() From: Joe Perches To: Masahiro Yamada , devicetree@vger.kernel.org Cc: Frank Rowand , Rob Herring , linux-kernel@vger.kernel.org, Grant Likely Date: Tue, 08 Dec 2015 08:16:26 -0800 In-Reply-To: <1449590868-19070-1-git-send-email-yamada.masahiro@socionext.com> References: <1449590868-19070-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.2-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-12-09 at 01:07 +0900, Masahiro Yamada wrote: > Trivial changes suggested by checkpatch.pl. [] > diff --git a/drivers/of/address.c b/drivers/of/address.c [] > @@ -23,7 +23,7 @@ static int __of_address_to_resource(struct device_node *dev, >  #ifdef DEBUG >  static void of_dump_addr(const char *s, const __be32 *addr, int na) >  { > - printk(KERN_DEBUG "%s", s); > + pr_debug("%s", s); >   while (na--) >   printk(" %08x", be32_to_cpu(*(addr++))); >   printk("\n"); mixing pr_debug and printk doesn't make much sense. It might be nicer to use static void of_dumpaddr(const char *s, const __be32 *addr, int na) { #ifdef DEBUG ... #endif } to avoid the other static declaration