From: Sudeep Dutt <sudeep.dutt@intel.com>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: Sudeep Dutt <sudeep.dutt@intel.com>,
ashutosh.dixit@intel.com, nikhil.rao@intel.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: mic: fix incorrect use of error codes in SCIF DMA driver
Date: Fri, 11 Dec 2015 18:50:41 -0800 [thread overview]
Message-ID: <1449888641.93285.549.camel@localhost> (raw)
In-Reply-To: <1449886156-11667-1-git-send-email-ebiggers3@gmail.com>
On Fri, 2015-12-11 at 20:09 -0600, Eric Biggers wrote:
> The error code passed to ERR_PTR() always should be negated. Also, the
> return value of scif_add_mmu_notifier() was never checked.
>
Thanks for the patch Eric.
Reviewed-by: Sudeep Dutt <sudeep.dutt@intel.com>
> Signed-off-by: Eric Biggers <ebiggers3@gmail.com>
> ---
> drivers/misc/mic/scif/scif_dma.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/misc/mic/scif/scif_dma.c b/drivers/misc/mic/scif/scif_dma.c
> index 95a13c6..f6aeebd 100644
> --- a/drivers/misc/mic/scif/scif_dma.c
> +++ b/drivers/misc/mic/scif/scif_dma.c
> @@ -276,13 +276,10 @@ static struct scif_mmu_notif *
> scif_find_mmu_notifier(struct mm_struct *mm, struct scif_endpt_rma_info *rma)
> {
> struct scif_mmu_notif *mmn;
> - struct list_head *item;
>
> - list_for_each(item, &rma->mmn_list) {
> - mmn = list_entry(item, struct scif_mmu_notif, list);
> + list_for_each_entry(mmn, &rma->mmn_list, list)
> if (mmn->mm == mm)
> return mmn;
> - }
> return NULL;
> }
>
> @@ -293,13 +290,12 @@ scif_add_mmu_notifier(struct mm_struct *mm, struct scif_endpt *ep)
> = kzalloc(sizeof(*mmn), GFP_KERNEL);
>
> if (!mmn)
> - return ERR_PTR(ENOMEM);
> + return ERR_PTR(-ENOMEM);
>
> scif_init_mmu_notifier(mmn, current->mm, ep);
> - if (mmu_notifier_register(&mmn->ep_mmu_notifier,
> - current->mm)) {
> + if (mmu_notifier_register(&mmn->ep_mmu_notifier, current->mm)) {
> kfree(mmn);
> - return ERR_PTR(EBUSY);
> + return ERR_PTR(-EBUSY);
> }
> list_add(&mmn->list, &ep->rma_info.mmn_list);
> return mmn;
> @@ -1730,7 +1726,7 @@ static int scif_rma_copy(scif_epd_t epd, off_t loffset, unsigned long addr,
> mutex_lock(&ep->rma_info.mmn_lock);
> mmn = scif_find_mmu_notifier(current->mm, &ep->rma_info);
> if (!mmn)
> - scif_add_mmu_notifier(current->mm, ep);
> + mmn = scif_add_mmu_notifier(current->mm, ep);
> mutex_unlock(&ep->rma_info.mmn_lock);
> if (IS_ERR(mmn)) {
> scif_put_peer_dev(spdev);
prev parent reply other threads:[~2015-12-12 2:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-12 2:09 [PATCH] misc: mic: fix incorrect use of error codes in SCIF DMA driver Eric Biggers
2015-12-12 2:50 ` Sudeep Dutt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449888641.93285.549.camel@localhost \
--to=sudeep.dutt@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=ebiggers3@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).