From: shuah <shuah@kernel.org>
To: Eugene Syromiatnikov <esyr@redhat.com>,
linux-kernel@vger.kernel.org,
Christian Brauner <christian@brauner.io>,
linux-kselftest@vger.kernel.org
Cc: Adrian Reber <areber@redhat.com>, shuah <shuah@kernel.org>
Subject: Re: [PATCH 4/6] selftests/clone3: fix up format strings
Date: Mon, 16 Sep 2019 10:41:51 -0600 [thread overview]
Message-ID: <144cc30f-cfd9-c367-188a-3cdcd4b120af@kernel.org> (raw)
In-Reply-To: <fc4ff67f28c6a6b83afecb6a6e22d632e23b82f2.1568116761.git.esyr@redhat.com>
On 9/10/19 6:03 AM, Eugene Syromiatnikov wrote:
> * tools/testing/selftests/clone3/clone3.c (test_clone3): Change format
> qualifier for printing size field from %d to %zu; place colon right
> after the word "says".
>
Please drop the file name. The rest looks good. I am assuming there is
a reason for doing this. Please include compile warns if applicable.
> Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
> ---
> tools/testing/selftests/clone3/clone3.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c
> index 1746a9b..7b8d927 100644
> --- a/tools/testing/selftests/clone3/clone3.c
> +++ b/tools/testing/selftests/clone3/clone3.c
> @@ -109,11 +109,11 @@ static int test_clone3(uint64_t flags, size_t size, int expected,
> {
> int ret;
>
> - ksft_print_msg("[%d] Trying clone3() with flags %#" PRIx64 " (size %d)"
> + ksft_print_msg("[%d] Trying clone3() with flags %#" PRIx64 " (size %zu)"
> "\n",
> getpid(), flags, size);
> ret = call_clone3(flags, size, test_mode);
> - ksft_print_msg("[%d] clone3() with flags says :%d expected %d\n",
> + ksft_print_msg("[%d] clone3() with flags says: %d expected %d\n",
> getpid(), ret, expected);
> if (ret != expected)
> ksft_exit_fail_msg(
>
thanks,
-- Shuah
next prev parent reply other threads:[~2019-09-16 16:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 12:02 [PATCH 0/6] Update clone3 self-tests Eugene Syromiatnikov
2019-09-10 12:03 ` [PATCH 1/6] selftests/clone3: convert test modes into an enum Eugene Syromiatnikov
2019-09-16 16:28 ` shuah
2019-09-10 12:03 ` [PATCH 2/6] selftests/clone3: add a check for invalid exit_signal Eugene Syromiatnikov
2019-09-16 16:37 ` shuah
2019-09-10 12:03 ` [PATCH 3/6] selftests/clone3: use uint64_t for flags parameter Eugene Syromiatnikov
2019-09-16 16:40 ` shuah
2019-09-10 12:03 ` [PATCH 4/6] selftests/clone3: fix up format strings Eugene Syromiatnikov
2019-09-16 16:41 ` shuah [this message]
2019-09-10 12:03 ` [PATCH 5/6] selftests/clone3: enable clone3 self-tests on all architectures Eugene Syromiatnikov
2019-09-16 16:44 ` shuah
2019-09-10 12:03 ` [PATCH 6/6] selftests: add clone3 to TARGETS Eugene Syromiatnikov
2019-09-16 16:48 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=144cc30f-cfd9-c367-188a-3cdcd4b120af@kernel.org \
--to=shuah@kernel.org \
--cc=areber@redhat.com \
--cc=christian@brauner.io \
--cc=esyr@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).