From: Xiubo Li <lixiubo@cmss.chinamobile.com>
To: broonie@kernel.org
Cc: linux-kernel@vger.kernel.org, Xiubo Li <lixiubo@cmss.chinamobile.com>
Subject: [PATCH] regmap: flat: introduce register striding to save some memories
Date: Mon, 14 Dec 2015 15:14:34 +0800 [thread overview]
Message-ID: <1450077274-25942-1-git-send-email-lixiubo@cmss.chinamobile.com> (raw)
Throughout the regcache-flat code, for the flat cache array, the
actual register address offsets are used to index the values, and
this will waste some memory spaces.
For example, on 64-BIT platform, device A has three registers:
register offsets: {0x00, 0x08, 0x10}
max_register: 0x10
regsiter striding: 8
And the size of flat cache memory space will be:
(max_register + 1 ) * sizeof(unsigned int) =
(0x10 + 1) * sizeof(unsigned int) = 17 * 8 = 136 Bytes
Since map->reg_stride has been introduced and all extant register
addresses are a multiple of this value, it could use the address
offsets divide by the stride to determine the index.
Then the size of flat cache memory space will be:
(max_register / reg_stride + 1 ) * sizeof(unsigned int) =
(0x10 / 8 + 1) * sizeof(unsigned int) = 3 * 8 = 24 Bytes
And the bigger of the striding value, there will be more memory
space wasted. After introducing the register striding here can
save some memeories for the system.
Signed-off-by: Xiubo Li <lixiubo@cmss.chinamobile.com>
---
drivers/base/regmap/regcache-flat.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/base/regmap/regcache-flat.c b/drivers/base/regmap/regcache-flat.c
index 686c9e0..160d636 100644
--- a/drivers/base/regmap/regcache-flat.c
+++ b/drivers/base/regmap/regcache-flat.c
@@ -19,17 +19,19 @@
static int regcache_flat_init(struct regmap *map)
{
int i;
- unsigned int *cache;
+ unsigned int index, *cache;
- map->cache = kcalloc(map->max_register + 1, sizeof(unsigned int),
- GFP_KERNEL);
+ map->cache = kcalloc(map->max_register / map->reg_stride + 1,
+ sizeof(unsigned int), GFP_KERNEL);
if (!map->cache)
return -ENOMEM;
cache = map->cache;
- for (i = 0; i < map->num_reg_defaults; i++)
- cache[map->reg_defaults[i].reg] = map->reg_defaults[i].def;
+ for (i = 0; i < map->num_reg_defaults; i++) {
+ index = map->reg_defaults[i].reg / map->reg_stride;
+ cache[index] = map->reg_defaults[i].def;
+ }
return 0;
}
@@ -45,9 +47,10 @@ static int regcache_flat_exit(struct regmap *map)
static int regcache_flat_read(struct regmap *map,
unsigned int reg, unsigned int *value)
{
+ unsigned int index = reg / map->reg_stride;
unsigned int *cache = map->cache;
- *value = cache[reg];
+ *value = cache[index];
return 0;
}
@@ -55,9 +58,10 @@ static int regcache_flat_read(struct regmap *map,
static int regcache_flat_write(struct regmap *map, unsigned int reg,
unsigned int value)
{
+ unsigned int index = reg / map->reg_stride;
unsigned int *cache = map->cache;
- cache[reg] = value;
+ cache[index] = value;
return 0;
}
--
1.8.3.1
next reply other threads:[~2015-12-14 7:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 7:14 Xiubo Li [this message]
2015-12-14 17:57 ` [PATCH] regmap: flat: introduce register striding to save some memories Mark Brown
[not found] ` <566FD138.4010601@cmss.chinamobile.com>
2015-12-18 8:23 ` [PATCH] regmap: flat: introduce register striding to save somememories Mark Brown
[not found] ` <2015121816593812599420@cmss.chinamobile.com>
2015-12-30 17:58 ` Mark Brown
2015-12-31 1:36 ` [PATCH] regmap: flat: introduce register striding to savesomememories Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450077274-25942-1-git-send-email-lixiubo@cmss.chinamobile.com \
--to=lixiubo@cmss.chinamobile.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).