From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Anton Wuerfel <anton.wuerfel@fau.de>, linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
Peter Hurley <peter@hurleysoftware.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Qipeng Zha <qipeng.zha@intel.com>,
Desmond Liu <desmondl@broadcom.com>,
Wang Long <long.wanglong@huawei.com>,
Matt Redfearn <matt.redfearn@imgtec.com>,
Paul Burton <paul.burton@imgtec.com>,
Ralf Baechle <ralf@linux-mips.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Peter Hung <hpeter@gmail.com>,
Soeren Grunewald <soeren.grunewald@desy.de>,
Adam Lee <adam.lee@canonical.com>,
"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
Mans Rullgard <mans@mansr.com>,
linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-kernel@i4.cs.fau.de,
Phillip Raffeck <phillip.raffeck@fau.de>
Subject: Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro
Date: Thu, 17 Dec 2015 17:16:41 +0200 [thread overview]
Message-ID: <1450365401.30729.142.camel@linux.intel.com> (raw)
In-Reply-To: <1450280177-4460-9-git-send-email-anton.wuerfel@fau.de>
On Wed, 2015-12-16 at 16:36 +0100, Anton Wuerfel wrote:
> This patch fixes a checkpatch warning caused by missing parentheses
> in the definition of a macro.
>
> Signed-off-by: Anton Würfel <anton.wuerfel@fau.de>
> Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de>
> CC: linux-kernel@i4.cs.fau.de
> ---
> drivers/tty/serial/8250/8250_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c
> b/drivers/tty/serial/8250/8250_core.c
> index 67147b2..3c29530 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -686,7 +686,7 @@ static int __init univ8250_console_init(void)
> }
> console_initcall(univ8250_console_init);
>
> -#define SERIAL8250_CONSOLE &univ8250_console
> +#define SERIAL8250_CONSOLE (&univ8250_console)
What about the rest of the drivers under drivers/tty/serial?
What do you propose to do with, for example, the following
drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define
CPM_UART_CONSOLE &cpm_scc_uart_console
drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define
CPM_UART_CONSOLE NULL
> #else
> #define SERIAL8250_CONSOLE NULL
> #endif
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2015-12-17 15:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-16 15:36 [PATCH 00/11] tty: serial: 8250: Fix checkpatch warnings Anton Wuerfel
2015-12-16 15:36 ` [PATCH 01/11] tty: serial: 8250: Fix whitespace errors Anton Wuerfel
2015-12-16 16:43 ` Peter Hurley
2015-12-16 15:36 ` [PATCH 02/11] tty: serial: 8250: Fix indentation warnings Anton Wuerfel
2015-12-16 16:49 ` Peter Hurley
2015-12-16 15:36 ` [PATCH 03/11] tty: serial: 8250: Fix braces after struct Anton Wuerfel
2015-12-16 15:36 ` [PATCH 04/11] tty: serial: 8250: Fix multiline comment style Anton Wuerfel
2015-12-16 16:52 ` Peter Hurley
2015-12-16 15:36 ` [PATCH 05/11] tty: serial: 8250: Remove else after return Anton Wuerfel
2015-12-16 15:36 ` [PATCH 06/11] tty: serial: 8250: Move EXPORT_SYMBOL to function Anton Wuerfel
2015-12-16 17:06 ` Peter Hurley
2015-12-16 15:36 ` [PATCH 07/11] tty: serial: 8250: Fix line continuation warning Anton Wuerfel
2015-12-16 15:36 ` [PATCH 08/11] tty: serial: 8250: Add parentheses to macro Anton Wuerfel
2015-12-17 15:16 ` Andy Shevchenko [this message]
2015-12-18 11:36 ` anton.wuerfel
2015-12-18 12:35 ` Andy Shevchenko
2015-12-16 15:36 ` [PATCH 09/11] tty: serial: 8250: Fix multi-line strings Anton Wuerfel
2015-12-16 15:36 ` [PATCH 10/11] tty: serial: 8250: Replace printk by pr_* Anton Wuerfel
2015-12-16 17:00 ` Peter Hurley
2015-12-16 15:36 ` [PATCH 11/11] tty: serial: 8250: Delete commented code Anton Wuerfel
2015-12-16 17:05 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450365401.30729.142.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adam.lee@canonical.com \
--cc=anton.wuerfel@fau.de \
--cc=deller@gmx.de \
--cc=desmondl@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hpeter@gmail.com \
--cc=jejb@parisc-linux.org \
--cc=jslaby@suse.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@i4.cs.fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=long.wanglong@huawei.com \
--cc=mail@maciej.szmigiero.name \
--cc=mans@mansr.com \
--cc=matt.redfearn@imgtec.com \
--cc=paul.burton@imgtec.com \
--cc=peter@hurleysoftware.com \
--cc=phillip.raffeck@fau.de \
--cc=qipeng.zha@intel.com \
--cc=ralf@linux-mips.org \
--cc=soeren.grunewald@desy.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).