From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jeff Layton <jlayton@poochiereds.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
<linux-fsdevel@vger.kernel.org>
Subject: [PATCH 3/8] fs: make fcntl.c explicitly non-modular
Date: Thu, 17 Dec 2015 14:11:01 -0500 [thread overview]
Message-ID: <1450379466-23115-4-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1450379466-23115-1-git-send-email-paul.gortmaker@windriver.com>
The Makefile currently controlling compilation of this code is obj-y
meaning that it currently is not being built as a module by anyone.
Lets remove the couple traces of modularity so that when reading the
code there is no doubt it is builtin-only.
Since module_init translates to device_initcall in the non-modular
case, the init ordering gets bumped to one level earlier when we
use the more appropriate fs_initcall here. However we've made similar
changes before without any fallout and none is expected here either.
We don't replace module.h with init.h since the file already has that.
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Jeff Layton <jlayton@poochiereds.net>
Cc: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
fs/fcntl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/fcntl.c b/fs/fcntl.c
index ee85cd4e136a..b485864eb357 100644
--- a/fs/fcntl.c
+++ b/fs/fcntl.c
@@ -13,7 +13,6 @@
#include <linux/capability.h>
#include <linux/dnotify.h>
#include <linux/slab.h>
-#include <linux/module.h>
#include <linux/pipe_fs_i.h>
#include <linux/security.h>
#include <linux/ptrace.h>
@@ -755,5 +754,4 @@ static int __init fcntl_init(void)
sizeof(struct fasync_struct), 0, SLAB_PANIC, NULL);
return 0;
}
-
-module_init(fcntl_init)
+fs_initcall(fcntl_init)
--
2.6.1
next prev parent reply other threads:[~2015-12-17 19:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 19:10 [PATCH v2 0/8] fs: don't use module helpers in non-modular code Paul Gortmaker
2015-12-17 19:10 ` [PATCH 1/8] hugetlb: make mm and fs code explicitly non-modular Paul Gortmaker
2015-12-17 22:45 ` Mike Kravetz
2015-12-18 2:46 ` Davidlohr Bueso
2015-12-17 19:11 ` [PATCH 2/8] fs: make notify dnotify.c " Paul Gortmaker
2015-12-17 19:11 ` Paul Gortmaker [this message]
2015-12-17 19:11 ` [PATCH 4/8] fs: make filesystems.c " Paul Gortmaker
2015-12-17 19:11 ` [PATCH 5/8] fs: make locks.c " Paul Gortmaker
2015-12-18 12:07 ` Jeff Layton
2015-12-17 19:11 ` [PATCH 6/8] fs: make direct-io.c " Paul Gortmaker
2015-12-17 19:11 ` [PATCH 7/8] fs: make devpts/inode.c " Paul Gortmaker
2015-12-17 19:46 ` Peter Hurley
2015-12-20 2:52 ` Paul Gortmaker
2015-12-17 19:11 ` [PATCH 8/8] fs: make binfmt_elf.c " Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450379466-23115-4-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).