From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
To: Borislav Petkov <bp@alien8.de>
Cc: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
Matt Fleming <matt@console-pimps.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
Ong Boon Leong <boon.leong.ong@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-efi@vger.kernel.org,
Sam Protsenko <semen.protsenko@linaro.org>,
Peter Jones <pjones@redhat.com>,
Andy Lutomirski <luto@amacapital.net>,
Roy Franz <roy.franz@linaro.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Anvin H Peter <h.peter.anvin@intel.com>
Subject: Re: [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware
Date: Mon, 21 Dec 2015 17:45:59 +0000 [thread overview]
Message-ID: <1450719959.17337.0.camel@nexus-software.ie> (raw)
In-Reply-To: <20151221173715.GE21582@pd.tnic>
On Mon, 2015-12-21 at 18:37 +0100, Borislav Petkov wrote:
> On Mon, Dec 21, 2015 at 05:04:11PM +0000, Bryan O'Donoghue wrote:
> > > This patch also export efi_capsule_supported() function symbol
> > > for
> > > verifying the submitted capsule header in this kernel module.
> >
> > 1. Should be a separate patch
> > 2. Suggested, rewording for that patch log
> >
> > 2/2 Title
> > This patch exports efi_capsule_supported to enable verification of
> > the
> > capsule header.
> >
> > That said - who is the user of this symbol ? Why is it needed ?
> > Anyway
> > please consider splitting and rewording.
>
> Huh?
>
> I still don't really see the reasoning for splitting out the export.
>
> When you do the export and use it in a single patch it is *obvious*
> why
> it is being exported.
>
> And there's no need to mention in the commit message that you're
> exporting a symbol. People export symbols all the time.
>
Yes - saw the export down the end of the patchset. Feel free to ignore
that comment.
next prev parent reply other threads:[~2015-12-21 17:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 12:13 [PATCH v10 0/1] Enable capsule loader interface for efi firmware updating Kweh, Hock Leong
2015-12-18 12:13 ` [PATCH v10 1/1] efi: a misc char interface for user to update efi firmware Kweh, Hock Leong
2015-12-21 17:04 ` Bryan O'Donoghue
2015-12-21 17:37 ` Borislav Petkov
2015-12-21 17:45 ` Bryan O'Donoghue [this message]
2016-01-21 12:35 ` Matt Fleming
2016-01-21 11:51 ` Matt Fleming
2016-01-26 3:09 Kweh, Hock Leong
2016-01-26 3:10 Kweh, Hock Leong
2016-01-28 12:16 ` Matt Fleming
2016-01-29 1:22 Kweh, Hock Leong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450719959.17337.0.camel@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=James.Bottomley@hansenpartnership.com \
--cc=boon.leong.ong@intel.com \
--cc=bp@alien8.de \
--cc=gregkh@linuxfoundation.org \
--cc=h.peter.anvin@intel.com \
--cc=hock.leong.kweh@intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=matt@codeblueprint.co.uk \
--cc=matt@console-pimps.org \
--cc=pjones@redhat.com \
--cc=roy.franz@linaro.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).