From: Roman Volkov <v1ron@mail.ru>
To: arm@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Alexey Charkov <alchark@gmail.com>,
Roman Volkov <rvolkov@v1ros.org>,
Tony Prisk <linux@prisktech.co.nz>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH v2 RESEND 2/3] clocksource/vt8500: Remove the 'loops' variable
Date: Thu, 31 Dec 2015 21:02:06 +0300 [thread overview]
Message-ID: <1451584927-4051-3-git-send-email-v1ron@mail.ru> (raw)
In-Reply-To: <1451584927-4051-1-git-send-email-v1ron@mail.ru>
From: Roman Volkov <rvolkov@v1ros.org>
The purpose of the 'loops' variable is unclear. vt8500 hardware does not
require any protections, in case if these variables intended for preventing
infinite loops (identical PXA timer works perfectly without these ones).
Signed-off-by: Roman Volkov <rvolkov@v1ros.org>
---
drivers/clocksource/vt8500_timer.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/clocksource/vt8500_timer.c b/drivers/clocksource/vt8500_timer.c
index dfc3bb4..eb08d96 100644
--- a/drivers/clocksource/vt8500_timer.c
+++ b/drivers/clocksource/vt8500_timer.c
@@ -48,18 +48,14 @@
#define TIMER_COUNT_W_ACTIVE (1 << 4) /* not ready for write */
#define TIMER_MATCH_W_ACTIVE (1 << 0) /* not ready for write */
-#define msecs_to_loops(t) (loops_per_jiffy / 1000 * HZ * t)
-
#define MIN_OSCR_DELTA 16
static void __iomem *regbase;
static cycle_t vt8500_timer_read(struct clocksource *cs)
{
- int loops = msecs_to_loops(10);
writel(3, regbase + TIMER_CTRL_VAL);
- while ((readl((regbase + TIMER_AS_VAL)) & TIMER_COUNT_R_ACTIVE)
- && --loops)
+ while (readl(regbase + TIMER_AS_VAL) & TIMER_COUNT_R_ACTIVE)
cpu_relax();
return readl(regbase + TIMER_COUNT_VAL);
}
@@ -75,10 +71,8 @@ static struct clocksource clocksource = {
static int vt8500_timer_set_next_event(unsigned long cycles,
struct clock_event_device *evt)
{
- int loops = msecs_to_loops(10);
cycle_t alarm = clocksource.read(&clocksource) + cycles;
- while ((readl(regbase + TIMER_AS_VAL) & TIMER_MATCH_W_ACTIVE)
- && --loops)
+ while (readl(regbase + TIMER_AS_VAL) & TIMER_MATCH_W_ACTIVE)
cpu_relax();
writel((unsigned long)alarm, regbase + TIMER_MATCH_VAL);
--
2.6.2
next prev parent reply other threads:[~2015-12-31 18:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-31 18:02 [PATCH v2 RESEND 0/3] clocksource/vt8500: Fix hangs in small delays Roman Volkov
2015-12-31 18:02 ` [PATCH v2 RESEND 1/3] clocksource/vt8500: Use MIN_OSCR_DELTA from PXA Roman Volkov
2015-12-31 22:33 ` Thomas Gleixner
2015-12-31 23:32 ` Roman Volkov
2016-01-01 20:23 ` Robert Jarzmik
2016-01-01 9:58 ` Thomas Gleixner
2015-12-31 18:02 ` Roman Volkov [this message]
2015-12-31 18:02 ` [PATCH v2 RESEND 3/3] clocksource/vt8500: Add register R/W functions Roman Volkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451584927-4051-3-git-send-email-v1ron@mail.ru \
--to=v1ron@mail.ru \
--cc=alchark@gmail.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@prisktech.co.nz \
--cc=rvolkov@v1ros.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).